yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V10: fix build warnings in test projects (#12509)

Browse Source 
* Run code cleanup

* Dotnet format benchmarks project

* Fix up Test.Common

* Run dotnet format + manual cleanup

* Run code cleanup for unit tests

* Run dotnet format

* Fix up errors

* Manual cleanup of Unit test project

* Update tests/Umbraco.Tests.Benchmarks/HexStringBenchmarks.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Integration/Testing/TestDbMeta.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Benchmarks/TypeFinderBenchmarks.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Update tests/Umbraco.Tests.Integration/Umbraco.Core/Events/EventAggregatorTests.cs

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Fix according to review

* Fix after merge

* Fix errors

Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk>
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Zeegaan <nge@umbraco.dk>
This commit is contained in:
Nikolaj Geisle
2022-06-21 08:09:38 +02:00
committed by GitHub
parent 29961d40a3
commit 7aeb400fce
599 changed files with 87303 additions and 86123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
tests/Umbraco.Tests.UnitTests/Umbraco.Core/TaskHelperTests.cs
View File

@@ -12,66 +12,62 @@ using Umbraco.Cms.Tests.Common;
using Umbraco.Cms.Tests.Common.TestHelpers;
using Umbraco.Cms.Tests.UnitTests.AutoFixture;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core;
[TestFixture]
public class TaskHelperTests
{
[TestFixture]
public class TaskHelperTests
[Test]
[AutoMoqData]
public void RunBackgroundTask__Suppress_Execution_Context(
[Frozen] ILogger<TaskHelper> logger,
TaskHelper sut)
{
[Test]
[AutoMoqData]
public void RunBackgroundTask__Suppress_Execution_Context(
[Frozen] ILogger<TaskHelper> logger,
TaskHelper sut)
var local = new AsyncLocal<string> { Value = "hello" };
string taskResult = null;
var t = sut.ExecuteBackgroundTask(() =>
{
var local = new AsyncLocal<string>
{
Value = "hello"
};
// FireAndForgetTasks ensure that flow is suppressed therefore this value will be null
taskResult = local.Value;
return Task.CompletedTask;
});
string taskResult = null;
Task t = sut.ExecuteBackgroundTask(() =>
{
// FireAndForgetTasks ensure that flow is suppressed therefore this value will be null
taskResult = local.Value;
return Task.CompletedTask;
});
Task.WaitAll(t);
Task.WaitAll(t);
Assert.IsNull(taskResult);
}
Assert.IsNull(taskResult);
}
[Test]
[AutoMoqData]
public void RunBackgroundTask__Must_Run_Func(
[Frozen] ILogger<TaskHelper> logger,
TaskHelper sut)
[Test]
[AutoMoqData]
public void RunBackgroundTask__Must_Run_Func(
[Frozen] ILogger<TaskHelper> logger,
TaskHelper sut)
{
var i = 0;
var t = sut.ExecuteBackgroundTask(() =>
{
var i = 0;
Task t = sut.ExecuteBackgroundTask(() =>
{
Interlocked.Increment(ref i);
return Task.CompletedTask;
});
Interlocked.Increment(ref i);
return Task.CompletedTask;
});
Task.WaitAll(t);
Task.WaitAll(t);
Assert.AreEqual(1, i);
}
Assert.AreEqual(1, i);
}
[Test]
[AutoMoqData]
public void RunBackgroundTask__Log_Error_When_Exception_Happen_In_Background_Task(
[Frozen] ILogger<TaskHelper> logger,
Exception exception,
TaskHelper sut)
{
Task t = sut.ExecuteBackgroundTask(() => throw exception);
[Test]
[AutoMoqData]
public void RunBackgroundTask__Log_Error_When_Exception_Happen_In_Background_Task(
[Frozen] ILogger<TaskHelper> logger,
Exception exception,
TaskHelper sut)
{
var t = sut.ExecuteBackgroundTask(() => throw exception);
Task.WaitAll(t);
Task.WaitAll(t);
Mock.Get(logger).VerifyLogError(exception, "Exception thrown in a background thread", Times.Once());
}
Mock.Get(logger).VerifyLogError(exception, "Exception thrown in a background thread", Times.Once());
}
}