diff --git a/.github/workflows/rich-code-navigation.yml b/.github/workflows/rich-code-navigation.yml deleted file mode 100644 index a965dea768..0000000000 --- a/.github/workflows/rich-code-navigation.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: Microsoft Rich Code Navigation - -on: - pull_request: - push: - branches: [ v8/dev ] - -jobs: - RichNavigation: - runs-on: windows-latest - - steps: - - uses: actions/checkout@v2 - - - name: Run Umbraco Build Script with Powershell - working-directory: 'build' - run: .\build.ps1 - shell: powershell - - - name: Microsoft Rich Code Navigation Indexer - uses: microsoft/RichCodeNavIndexer@v0.1 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - languages: csharp,typescript \ No newline at end of file diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js b/src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js index e3c2913e4e..1d503dd3bc 100644 --- a/src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js +++ b/src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js @@ -562,6 +562,7 @@ view: "views/content/overlays/unpublish.html", variants: $scope.content.variants, //set a model property for the dialog skipFormValidation: true, //when submitting the overlay form, skip any client side validation + includeUnpublished: false, submitButtonLabelKey: "content_unpublish", submitButtonStyle: "warning", submit: function (model) { diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js index 095c4f3fe1..5d4cc7eec7 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js @@ -5,23 +5,28 @@ var vm = this; - vm.includeUnpublished = false; + vm.includeUnpublished = $scope.model.includeUnpublished || false; vm.changeSelection = changeSelection; vm.toggleIncludeUnpublished = toggleIncludeUnpublished; - function onInit() { vm.variants = $scope.model.variants; - vm.displayVariants = vm.variants.slice(0);// shallow copy, we dont want to share the array-object(because we will be performing a sort method) but each entry should be shared (because we need validation and notifications). + vm.displayVariants = vm.variants.slice(0); // shallow copy, we don't want to share the array-object (because we will be performing a sort method) but each entry should be shared (because we need validation and notifications). vm.labels = {}; + // get localized texts for use in directives if (!$scope.model.title) { localizationService.localize("buttons_publishDescendants").then(function (value) { $scope.model.title = value; }); } + if (!vm.labels.includeUnpublished) { + localizationService.localize("content_includeUnpublished").then(function (value) { + vm.labels.includeUnpublished = value; + }); + } _.each(vm.variants, function (variant) { variant.isMandatory = isMandatoryFilter(variant); @@ -72,8 +77,9 @@ } function toggleIncludeUnpublished() { - console.log("toggleIncludeUnpublished") vm.includeUnpublished = !vm.includeUnpublished; + // make sure this value is pushed back to the scope + $scope.model.includeUnpublished = vm.includeUnpublished; } /** Returns true if publishing is possible based on if there are un-published mandatory languages */ diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html index 92373d00ff..1cd829af38 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html @@ -6,12 +6,13 @@