yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed TestOptionAttributeBase type resolving to use Assemby instead of String

Browse Source
This commit is contained in:
Lars-Erik Aabech
2019-10-21 23:01:23 +02:00
parent c56f6c161e
commit 7bd8dee6a2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Umbraco.Tests/Testing/TestOptionAttributeBase.cs
View File

@@ -9,7 +9,7 @@ namespace Umbraco.Tests.Testing
{
public abstract class TestOptionAttributeBase : Attribute
{
public static readonly List<string> ScanAssemblies = new List<string>();
public static readonly List<Assembly> ScanAssemblies = new List<Assembly>();
public static TOptions GetTestOptions<TOptions>(MethodInfo method)
where TOptions : TestOptionAttributeBase, new()
@@ -35,11 +35,11 @@ namespace Umbraco.Tests.Testing
if (type == null)
{
type = ScanAssemblies
.Select(x => Type.GetType(typeName + ", " + x, false))
.Select(assembly => assembly.GetType(typeName, false))
.FirstOrDefault(x => x != null);
if (type == null)
{
throw new PanicException($"Could not resolve the type from type name {typeName}"); // makes no sense
throw new PanicException($"Could not resolve the running test fixture from type name {typeName}"); // makes no sense
}
}
var methodInfo = type.GetMethod(methodName); // what about overloads?