diff --git a/src/Umbraco.Web.UI/umbraco/config/lang/en.xml b/src/Umbraco.Web.UI/umbraco/config/lang/en.xml index 2b5ce44d79..2f9871add8 100644 --- a/src/Umbraco.Web.UI/umbraco/config/lang/en.xml +++ b/src/Umbraco.Web.UI/umbraco/config/lang/en.xml @@ -1351,9 +1351,9 @@ To manage your website, simply open the Umbraco back office and start adding con '%0%' in config file '%1%'.]]> There was an error, check log for full error: %0%. - Total XML: %0%, Total: %1% - Total XML: %0%, Total: %1%, Total invalid %2% - Total XML: %0%, Total published: %1%, Total invalid %2% + Members - Total XML: %0%, Total: %1%, Total invalid: %2% + Media - Total XML: %0%, Total: %1%, Total invalid %2% + Content - Total XML: %0%, Total published: %1%, Total invalid %2% Certificate validation error: '%0%' Error pinging the URL %0% - '%1%' diff --git a/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml b/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml index 05015116ee..e0022eb2c0 100644 --- a/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml +++ b/src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml @@ -1355,9 +1355,9 @@ To manage your website, simply open the Umbraco back office and start adding con '%0%' in config file '%1%'.]]> There was an error, check log for full error: %0%. - Total XML: %0%, Total: %1% - Total XML: %0%, Total: %1%, Total invalid %2% - Total XML: %0%, Total published: %1%, Total invalid %2% + Members - Total XML: %0%, Total: %1%, Total invalid: %2% + Media - Total XML: %0%, Total: %1%, Total invalid: %2% + Content - Total XML: %0%, Total published: %1%, Total invalid: %2% Certificate validation error: '%0%' Error pinging the URL %0% - '%1%' diff --git a/src/Umbraco.Web/HealthCheck/Checks/DataIntegrity/XmlDataIntegrityHealthCheck.cs b/src/Umbraco.Web/HealthCheck/Checks/DataIntegrity/XmlDataIntegrityHealthCheck.cs index 8895e18af9..5d888ef117 100644 --- a/src/Umbraco.Web/HealthCheck/Checks/DataIntegrity/XmlDataIntegrityHealthCheck.cs +++ b/src/Umbraco.Web/HealthCheck/Checks/DataIntegrity/XmlDataIntegrityHealthCheck.cs @@ -14,7 +14,7 @@ namespace Umbraco.Web.HealthCheck.Checks.DataIntegrity [HealthCheck( "D999EB2B-64C2-400F-B50C-334D41F8589A", "XML Data Integrity", - Description = "Checks the integrity of the XML data in Umbraco", + Description = "This checks the data integrity for the xml structures for content, media and members that are stored in the cmsContentXml table. This does not check the data integrity of the xml cache file, only the xml structures stored in the database used to create the xml cache file.", Group = "Data Integrity")] public class XmlDataIntegrityHealthCheck : HealthCheck { @@ -85,7 +85,7 @@ namespace Umbraco.Web.HealthCheck.Checks.DataIntegrity if (totalXml != total) actions.Add(new HealthCheckAction(CheckMembersXmlTableAction, Id)); - return new HealthCheckStatus(_textService.Localize("healthcheck/xmlDataIntegrityCheckMembers", new[] { totalXml.ToString(), total.ToString() })) + return new HealthCheckStatus(_textService.Localize("healthcheck/xmlDataIntegrityCheckMembers", new[] { totalXml.ToString(), total.ToString(), (total - totalXml).ToString() })) { ResultType = totalXml == total ? StatusResultType.Success : StatusResultType.Error, Actions = actions @@ -122,7 +122,7 @@ namespace Umbraco.Web.HealthCheck.Checks.DataIntegrity .InnerJoin(_sqlSyntax) .On(_sqlSyntax, left => left.NodeId, right => right.NodeId) .Where(dto => dto.NodeObjectType == mediaObjectType) - .Where(string.Format("cmsContentXml.{0} NOT LIKE '% key=\"%'", _sqlSyntax.GetQuotedColumnName("xml"))); + .Where(string.Format("{0}.{1} NOT LIKE '% key=\"%'", _sqlSyntax.GetQuotedTableName("cmsContentXml"), _sqlSyntax.GetQuotedColumnName("xml"))); var totalNonGuidXml = _database.ExecuteScalar(countNonGuidQuery); var hasError = false; @@ -160,7 +160,7 @@ namespace Umbraco.Web.HealthCheck.Checks.DataIntegrity //count entires var countTotalSubQuery = new Sql() - .Select("DISTINCT cmsContentXml.nodeId") + .Select(string.Format("DISTINCT {0}.{1}", _sqlSyntax.GetQuotedTableName("cmsContentXml"), _sqlSyntax.GetQuotedColumnName("nodeId"))) .From(_sqlSyntax) .InnerJoin(_sqlSyntax) .On(_sqlSyntax, left => left.NodeId, right => right.NodeId); @@ -173,7 +173,7 @@ namespace Umbraco.Web.HealthCheck.Checks.DataIntegrity .InnerJoin(_sqlSyntax) .On(_sqlSyntax, left => left.NodeId, right => right.NodeId) .Where(dto => dto.NodeObjectType == documentObjectType) - .Where(string.Format("cmsContentXml.{0} NOT LIKE '% key=\"%'", _sqlSyntax.GetQuotedColumnName("xml"))); + .Where(string.Format("{0}.{1} NOT LIKE '% key=\"%'", _sqlSyntax.GetQuotedTableName("cmsContentXml"), _sqlSyntax.GetQuotedColumnName("xml"))); var totalNonGuidXml = _database.ExecuteScalar(countNonGuidQuery); var hasError = false;