From 7c54064f59cfeefd5835c659df2a6d2b3aa12e8f Mon Sep 17 00:00:00 2001
From: Busra Sengul <aysebusrasengul@gmail.com>
Date: Mon, 21 Oct 2024 12:05:39 +0100
Subject: [PATCH] Bugfix: Tiptap RTE custom dimensions configuration (#2469)

* tiptop min height configuration

* Removed `min-height`; credit to @innovoix

* Clarified the use of `display:flex`

* Changed to use `height` instead of `min-height`

as this will control the maximum height of the editor input area.

---------

Co-authored-by: leekelleher <leekelleher@gmail.com>
---
 .../tiptap/components/input-tiptap/input-tiptap.element.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts b/src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
index e0f083f65a..367d2c6edc 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
@@ -93,7 +93,7 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
 
 		const dimensions = this.configuration?.getValueByAlias<{ width?: number; height?: number }>('dimensions');
 		if (dimensions?.width) this.setAttribute('style', `max-width: ${dimensions.width}px;`);
-		if (dimensions?.height) element.setAttribute('style', `max-height: ${dimensions.height}px;`);
+		if (dimensions?.height) element.setAttribute('style', `height: ${dimensions.height}px;`);
 
 		this._toolbar = this.configuration?.getValueByAlias<UmbTiptapToolbarValue>('toolbar') ?? [[[]]];
 
@@ -173,6 +173,8 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
 			}
 
 			#editor {
+				/* Required as overflow is set to auto, so that the scrollbars don't appear. */
+				display: flex;
 				overflow: auto;
 				border-radius: var(--uui-border-radius);
 				border: 1px solid var(--uui-color-border);
@@ -183,8 +185,7 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
 				box-sizing: border-box;
 				height: 100%;
 				width: 100%;
-				min-height: 400px;
-				display: grid; /* Don't ask me why this is needed, but it is. */
+
 				pre {
 					background-color: var(--uui-color-surface-alt);
 					padding: var(--uui-size-space-2) var(--uui-size-space-4);