yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

implement and use appendToFrozenArray

Browse Source
This commit is contained in:
Niels Lyngsø
2023-01-11 11:29:04 +01:00
parent 8f75b7b6ec
commit 7ee2665781
2 changed files with 31 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Umbraco.Web.UI.Client/src/backoffice/settings/data-types/workspace/workspace-data-type.context.ts
View File

@@ -2,6 +2,7 @@ import { UmbWorkspaceContentContext } from '../../../shared/components/workspace
import type { UmbDataTypeStore, UmbDataTypeStoreItemType } from 'src/backoffice/settings/data-types/data-type.store';
import type { DataTypeDetails } from '@umbraco-cms/models';
import { UmbControllerHostInterface } from 'src/core/controller/controller-host.mixin';
import { appendToFrozenArray } from 'src/core/observable-api/unique-behavior-subject';
const DefaultDataTypeData = {
key: '',
@@ -26,18 +27,11 @@ export class UmbWorkspaceDataTypeContext extends UmbWorkspaceContentContext<
public setPropertyValue(alias: string, value: unknown) {
// TODO: make sure to check that we have a details model? otherwise fail? 8This can be relevant if we use the same context for tree actions?
const data = this._data.getValue();
const entry = {alias: alias, value: value};
// TODO: Can we move this into a method of its own?
const newDataSet = [...(data as DataTypeDetails).data];
const indexToReplace = newDataSet.findIndex(x => x.alias === alias);
if(indexToReplace !== -1) {
newDataSet[indexToReplace] = entry;
} else {
newDataSet.push(entry);
}
const newDataSet = appendToFrozenArray((this._data.getValue() as DataTypeDetails).data, entry, x => x.alias === alias);
this.update({data: newDataSet});
}

29
src/Umbraco.Web.UI.Client/src/core/observable-api/unique-behavior-subject.ts
View File

@@ -27,6 +27,35 @@ export function naiveObjectComparison(objOne: any, objTwo: any): boolean {
/**
* @export
* @method CreateObservablePart
* @param {Observable<T>} source - RxJS Subject to use for this Observable.
* @param {(mappable: T) => R} mappingFunction - Method to return the part for this Observable to return.
* @param {(previousResult: R, currentResult: R) => boolean} [memoizationFunction] - Method to Compare if the data has changed. Should return true when data is different.
* @description - Creates a RxJS Observable from RxJS Subject.
* @example <caption>Example create a Observable for part of the data Subject.</caption>
* public readonly myPart = CreateObservablePart(this._data, (data) => data.myPart);
*/
export function appendToFrozenArray<T>(data: T[], entry: T, uniqueMethod?: (entry: T) => boolean): T[] {
const unFrozenDataSet = [...data];
if(uniqueMethod) {
const indexToReplace = unFrozenDataSet.findIndex(uniqueMethod);
if(indexToReplace !== -1) {
unFrozenDataSet[indexToReplace] = entry;
} else {
unFrozenDataSet.push(entry);
}
} else {
unFrozenDataSet.push(entry);
}
return unFrozenDataSet;
}
type MappingFunction<T, R> = (mappable: T) => R;
type MemoizationFunction<R> = (previousResult: R, currentResult: R) => boolean;