From 7f3733d4b572eb226929e5fce0f4097275042c82 Mon Sep 17 00:00:00 2001 From: Stephan Date: Wed, 14 Feb 2018 11:27:43 +0100 Subject: [PATCH] cleanup --- src/Umbraco.Core/Services/UserService.cs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Umbraco.Core/Services/UserService.cs b/src/Umbraco.Core/Services/UserService.cs index 0c8b82b092..4117d582c2 100644 --- a/src/Umbraco.Core/Services/UserService.cs +++ b/src/Umbraco.Core/Services/UserService.cs @@ -933,7 +933,7 @@ namespace Umbraco.Core.Services /// /// UserGroup to save /// - /// If null than no changes are made to the users who are assigned to this group, however if a value is passed in + /// If null than no changes are made to the users who are assigned to this group, however if a value is passed in /// than all users will be removed from this group and only these users will be added /// /// Optional parameter to raise events. @@ -955,8 +955,6 @@ namespace Umbraco.Core.Services var xGroupUsers = groupUsers.ToDictionary(x => x.Id, x => x); var groupIds = groupUsers.Select(x => x.Id).ToArray(); - var temp = userIds.Except(groupIds).Where(x => x > 0).ToArray(); - addedUsers = urepository.GetAll(userIds.Except(groupIds).ToArray()).Where(x => x.Id != 0).ToArray(); removedUsers = groupIds.Except(userIds).Select(x => xGroupUsers[x]).Where(x => x.Id != 0).ToArray(); } @@ -1178,8 +1176,8 @@ namespace Umbraco.Core.Services if (byGroup.Value.TryGetValue(pathId, out permissionsForNodeAndGroup) == false) continue; - //In theory there will only be one EntityPermission in this group - // but there's nothing stopping the logic of this method + //In theory there will only be one EntityPermission in this group + // but there's nothing stopping the logic of this method // from having more so we deal with it here foreach (var entityPermission in permissionsForNodeAndGroup) { @@ -1215,7 +1213,7 @@ namespace Umbraco.Core.Services /// Returns the resulting permission set for a group for the path based on all permissions provided for the branch /// /// - /// The collective set of permissions provided to calculate the resulting permissions set for the path + /// The collective set of permissions provided to calculate the resulting permissions set for the path /// based on a single group /// /// Must be ordered deepest to shallowest (right to left)