Fix items found in PVS-Studio analysis

This commit is contained in:
Sebastiaan Janssen
2022-02-11 09:44:48 +01:00
committed by Nathan Woulfe
parent d1f1817744
commit 7f9b143e1a
8 changed files with 17 additions and 47 deletions

View File

@@ -760,27 +760,7 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
if (id == Constants.System.Root && startNodes.Length > 0 &&
startNodes.Contains(Constants.System.Root) == false && !ignoreUserStartNodes)
{
if (pageNumber > 0)
{
return new PagedResult<EntityBasic>(0, 0, 0);
}
IEntitySlim[] nodes = _entityService.GetAll(objectType.Value, startNodes).ToArray();
if (nodes.Length == 0)
{
return new PagedResult<EntityBasic>(0, 0, 0);
}
if (pageSize < nodes.Length)
{
pageSize = nodes.Length; // bah
}
var pr = new PagedResult<EntityBasic>(nodes.Length, pageNumber, pageSize)
{
Items = nodes.Select(_umbracoMapper.Map<EntityBasic>)
};
return pr;
return new PagedResult<EntityBasic>(0, 0, 0);
}
// else proceed as usual