From 80f3fc68649b0543e431e9ea3cf3d1f0aa0ccec8 Mon Sep 17 00:00:00 2001
From: Stephan <stephane@umbraco.dk>
Date: Tue, 27 Nov 2018 15:20:26 +0100
Subject: [PATCH] Get rid of IContainer.GetRegistered

---
 .../Composing/ContainerExtensions.cs          |  8 -----
 src/Umbraco.Core/Composing/IContainer.cs      |  9 +-----
 .../LightInject/LightInjectContainer.cs       |  4 ---
 src/Umbraco.Core/Composing/Registration.cs    | 31 -------------------
 src/Umbraco.Core/Umbraco.Core.csproj          |  1 -
 5 files changed, 1 insertion(+), 52 deletions(-)
 delete mode 100644 src/Umbraco.Core/Composing/Registration.cs

diff --git a/src/Umbraco.Core/Composing/ContainerExtensions.cs b/src/Umbraco.Core/Composing/ContainerExtensions.cs
index 789cdf6366..047bcd2ae5 100644
--- a/src/Umbraco.Core/Composing/ContainerExtensions.cs
+++ b/src/Umbraco.Core/Composing/ContainerExtensions.cs
@@ -33,14 +33,6 @@ namespace Umbraco.Core.Composing
         public static T TryGetInstance<T>(this IContainer container)
             => (T) container.TryGetInstance(typeof(T));
 
-        /// <summary>
-        /// Gets registrations for a service.
-        /// </summary>
-        /// <typeparam name="TService">The type of the service.</typeparam>
-        /// <returns>The registrations for the service.</returns>
-        public static IEnumerable<Registration> GetRegistered<TService>(this IContainer container)
-            => container.GetRegistered(typeof(TService));
-
         /// <summary>
         /// Creates an instance with arguments.
         /// </summary>
diff --git a/src/Umbraco.Core/Composing/IContainer.cs b/src/Umbraco.Core/Composing/IContainer.cs
index d068339eb1..4975f5d08d 100644
--- a/src/Umbraco.Core/Composing/IContainer.cs
+++ b/src/Umbraco.Core/Composing/IContainer.cs
@@ -61,13 +61,6 @@ namespace Umbraco.Core.Composing
         /// <typeparam name="TService">The type of the service.</typeparam>
         IEnumerable<TService> GetAllInstances<TService>();
 
-        /// <summary>
-        /// Gets registrations for a service.
-        /// </summary>
-        /// <param name="serviceType">The type of the service.</param>
-        /// <returns>The registrations for the service.</returns>
-        IEnumerable<Registration> GetRegistered(Type serviceType);
-
         /// <summary>
         /// Releases an instance.
         /// </summary>
@@ -76,7 +69,7 @@ namespace Umbraco.Core.Composing
         /// See https://stackoverflow.com/questions/14072208 and http://kozmic.net/2010/08/27/must-i-release-everything-when-using-windsor/,
         /// you only need to release instances you specifically resolved, and even then, if done right, that might never be needed. For
         /// instance, LightInject does not require this and does not support it - should work with scopes.
-        /// </remarks> 
+        /// </remarks>
         void Release(object instance);
 
         #endregion
diff --git a/src/Umbraco.Core/Composing/LightInject/LightInjectContainer.cs b/src/Umbraco.Core/Composing/LightInject/LightInjectContainer.cs
index 90c2903bc7..e3b93f5aea 100644
--- a/src/Umbraco.Core/Composing/LightInject/LightInjectContainer.cs
+++ b/src/Umbraco.Core/Composing/LightInject/LightInjectContainer.cs
@@ -117,10 +117,6 @@ namespace Umbraco.Core.Composing.LightInject
         public IEnumerable<object> GetAllInstances(Type type)
             => Container.GetAllInstances(type);
 
-        /// <inheritdoc />
-        public IEnumerable<Registration> GetRegistered(Type type)
-            => Container.AvailableServices.Where(x => x.ServiceType == type).Select(x => new Registration(x.ServiceType, x.ServiceName));
-
         /// <inheritdoc />
         public void Release(object instance)
         {
diff --git a/src/Umbraco.Core/Composing/Registration.cs b/src/Umbraco.Core/Composing/Registration.cs
deleted file mode 100644
index a3cb62522b..0000000000
--- a/src/Umbraco.Core/Composing/Registration.cs
+++ /dev/null
@@ -1,31 +0,0 @@
-using System;
-
-namespace Umbraco.Core.Composing
-{
-    /// <summary>
-    /// Represents a service registration in the container.
-    /// </summary>
-    public class Registration
-    {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="Registration"/> class.
-        /// </summary>
-        /// <param name="serviceType"></param>
-        /// <param name="serviceName"></param>
-        public Registration(Type serviceType, string serviceName)
-        {
-            ServiceType = serviceType;
-            ServiceName = serviceName;
-        }
-
-        /// <summary>
-        /// Gets the service type.
-        /// </summary>
-        public Type ServiceType { get; }
-
-        /// <summary>
-        /// Gets the service name.
-        /// </summary>
-        public string ServiceName { get; }
-    }
-}
diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj
index 57f7208d03..2e235dcd23 100755
--- a/src/Umbraco.Core/Umbraco.Core.csproj
+++ b/src/Umbraco.Core/Umbraco.Core.csproj
@@ -190,7 +190,6 @@
     <Compile Include="Composing\LightInject\LightInjectContainer.cs" />
     <Compile Include="Composing\LightInject\MixedLightInjectScopeManagerProvider.cs" />
     <Compile Include="Composing\OrderedCollectionBuilderBase.cs" />
-    <Compile Include="Composing\Registration.cs" />
     <Compile Include="Composing\TypeFinder.cs" />
     <Compile Include="Composing\TypeHelper.cs" />
     <Compile Include="Composing\TypeLoader.cs" />