yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v10 misc - Removed some redundant event handling code. (#11842)

Browse Source 
* Removed some redundant event handling code.

* Cleanup

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
This commit is contained in:
Paul Johnson
2022-01-13 11:31:25 +00:00
committed by GitHub
parent 52f5269e01
commit 81d68f48ad
3 changed files with 1 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/Umbraco.PublishedCache.NuCache/PublishedSnapshotServiceEventHandler.cs
View File

@@ -1,12 +1,9 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Events;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Notifications;
using Umbraco.Cms.Core.PublishedCache;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Services.Changes;
using Umbraco.Cms.Infrastructure.PublishedCache.Persistence;
using Umbraco.Extensions;
@@ -17,7 +14,6 @@ namespace Umbraco.Cms.Infrastructure.PublishedCache
/// Subscribes to Umbraco events to ensure nucache remains consistent with the source data
/// </summary>
public class PublishedSnapshotServiceEventHandler :
IDisposable,
INotificationHandler<LanguageSavedNotification>,
INotificationHandler<MemberDeletingNotification>,
INotificationHandler<ContentRefreshNotification>,
@@ -28,47 +24,18 @@ namespace Umbraco.Cms.Infrastructure.PublishedCache
INotificationHandler<MemberTypeRefreshedNotification>,
INotificationHandler<ScopedEntityRemoveNotification>
{
private readonly IRuntimeState _runtime;
private bool _disposedValue;
private readonly IPublishedSnapshotService _publishedSnapshotService;
private readonly INuCacheContentService _publishedContentService;
private readonly IContentService _contentService;
private readonly IMediaService _mediaService;
/// <summary>
/// Initializes a new instance of the <see cref="PublishedSnapshotServiceEventHandler"/> class.
/// </summary>
public PublishedSnapshotServiceEventHandler(
IRuntimeState runtime,
IPublishedSnapshotService publishedSnapshotService,
INuCacheContentService publishedContentService,
IContentService contentService,
IMediaService mediaService)
INuCacheContentService publishedContentService)
{
_runtime = runtime;
_publishedSnapshotService = publishedSnapshotService;
_publishedContentService = publishedContentService;
_contentService = contentService;
_mediaService = mediaService;
}
/// <summary>
/// Binds to the Umbraco events
/// </summary>
/// <returns>Returns true if binding occurred</returns>
public bool Initialize()
{
// however, the cache is NOT available until we are configured, because loading
// content (and content types) from database cannot be consistent (see notes in "Handle
// Notifications" region), so
// - notifications will be ignored
// - trying to obtain a published snapshot from the service will throw
if (_runtime.Level != RuntimeLevel.Run)
{
return false;
}
return true;
}
// note: if the service is not ready, ie _isReady is false, then we still handle repository events,
@@ -136,20 +103,5 @@ namespace Umbraco.Cms.Infrastructure.PublishedCache
_publishedSnapshotService.Rebuild(contentTypeIds: Array.Empty<int>());
}
}
protected virtual void Dispose(bool disposing)
{
if (!_disposedValue)
{
_disposedValue = true;
}
}
public void Dispose()
{
// Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
Dispose(disposing: true);
GC.SuppressFinalize(this);
}
}
}