yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the non-controversial, straightforward obsoleted constructs for Umbraco 16 (#18661)

Browse Source 
* Removed obsoletes from IConfigManipulator.

* Removed obsolete models builder extensions.

* Removed the obsolete ContentDashboardSettings.

* Removed the obsolete InstallMissingDatabase setting on GlobalSettings.

* Removed obsolete NuCache settings.

* Removed obsolete RuntimeMinificationSettings.

* Removed obsolete health check constant.

* Removed obsolete icon constant.

* Removed obsolete telemetry constant.

* Removed obsolete property and constructor on UmbracoBuilder.

* Removed obsolete constructor on AuditNotificationsHandler.

* Removed obsolete constructor on HTTP header health checks.

* Removed obsolete constructor on MediaFileManager.

* Removed obsolete GetDefaultFileContent on ViewHelper.

* Remove obsoleted methods on embed providers.

* Fix tests.

* Removed obsolete constructors on BlockEditorDataConverter.

* Removed obsolete SeedCacheDuration property on CacheSettings.

* Removed obsolete PublishCulture on ContentRepositoryExtensions.

* Removed obsolete MonitorLock.

* Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository.

* Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository.

* Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository.

* Removed obsolete DateValueEditor constructors.

* Removed obsolete GetAutomaticRelationTypesAliases.

* Removed obsolete constructor on TextOnlyValueEditor.

* Removed obsolete constructors on RegexValidator and RequiredValidator.

* Removed obsolete constructs on SliderValueConverter and TagsValueConverter.

* Removed obsolete GetContentType methods from IPublishedCache.

* Removed ContentFinderByIdPath.

* Removed obsolete constructor on DefaultMediaUrlProvider.

* Removed obsolete constructor on Domain.

* Removed obsolete constructor on PublishedRequest.

* Removed obsolete methods on CheckPermissions.

* Removed obsolete GetUserId from IBackOfficeSecurity.

* Removed obsolete methods on LegacyPasswordSecurity.

* Removed obsolete constructors on AuditService.

* Removed obsolete methods on IContentEditingService.

* Remove obsolete constructors and methods on ContentService/IContentService.

* Removed obsolete constructor in ContentTypeEditingService.

* Removed obsolete constructor in MediaTypeEditingService.

* Removed obsolete constructor in MemberTypeEditingService.

* Removed obsolete constructor in ContentTypeService.

* Removed obsolete constructors in ContentTypeServiceBase.

* Removed obsolete constructors and methods in ContentVersionService.

* Removed obsolete constructor in DataTypeUsageService.

* Removed obsolete constructor in DomainService.

* Removed obsolete constructor in FileService.

* Removes obsolete AttemptMove from IContentService.

* Removes obsolete SetPreventCleanup from IContentVersionService.

* Removes obsolete GetReferences from IDataTypeService.

* Removed obsolete SetConsentLevel from IMetricsConsentService.

* Removed obsolete methods from IPackageDataInstallation.

* Removed obsolete methods from IPackagingService.

* Removed obsolete methods on ITwoFactorLoginService.
Removed obsolete ITemporaryMediaService.

* Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService.

* More obsolete constructors.

* Removed obsoleted overloads on IPropertyValidationService.

* Fixed build for tests.

* Removed obsolete constructor for PublicAccessService, UserService and RelationService.

* Removed GetDefaultMemberType.

* Removed obsolete user group functionality from IUserService.

* Removed obsolete extension methods on IUserService.

* Removed obsolete method from ITelemetryService.

* Removed obsolete UdiParserServiceConnectors.

* Removed obsolete method on ICookieManager.

* Removed obsolete DynamicContext.

* Removed obsolete XmlHelper.

* Fixed failing integration tests.

* Removed obsoletes in Umbraco.Cms.Api.Common

* Removed obsoletes in Umbraco.Cms.Api.Delivery

* Removed obsoletes in Umbraco.Cms.Api.Management

* Removed obsoletes in Umbraco.Examine.Lucene

* Removed obsoletes in Umbraco.Infrastructure

* Fix failing delivery API contract integration test.

* Made integration tests internal.

* Removed obsoletes from web projects.

* Fix build.

* Removed Twitter OEmbed provider

* Removed obsolete constructor on PublishedDataType.

* Removed obsolete constructors on PublishedCacheBase.

* Removed the obsolete PropertyEditorTagsExtensions.

* Removed obsoletion properties on configuration response  models (#18697)

* Removed obsolete methods from server-side models.

* Update client-side types and sdk.

* Update client-side files.

* Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694)

* Removed obsolete method in UserService. (#18710)

* Removed obsoleted group alias keys from being publicly available. (#18682)

* Removed unneceessary ApiVersion attribute.

* Clean-up obsoletions on MemberService (#18703)

* Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers.

* Removed obsoletion on member service method that's not obsolete on the interface.
This commit is contained in:
Andy Butland
2025-03-21 18:02:31 +01:00
committed by GitHub
parent fb3a56a240
commit 825f791d01
481 changed files with 704 additions and 7908 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/Umbraco.Core/Configuration/IConfigManipulator.cs
View File

@@ -2,30 +2,11 @@ namespace Umbraco.Cms.Core.Configuration;
public interface IConfigManipulator
{
[Obsolete("Use RemoveConnectionStringAsync instead, scheduled for removal in V16.")]
void RemoveConnectionString();
[Obsolete("Use SaveConnectionStringAsync instead, scheduled for removal in V16.")]
void SaveConnectionString(string connectionString, string? providerName);
[Obsolete("Use SaveConfigValueAsync instead, scheduled for removal in V16.")]
void SaveConfigValue(string itemPath, object value);
[Obsolete("Use SaveDisableRedirectUrlTrackingAsync instead, scheduled for removal in V16.")]
void SaveDisableRedirectUrlTracking(bool disable);
[Obsolete("Use SetGlobalIdAsync instead, scheduled for removal in V16.")]
void SetGlobalId(string id);
/// <summary>
/// Removes the connection string from the configuration file
/// </summary>
/// <returns></returns>
Task RemoveConnectionStringAsync()
{
RemoveConnectionString();
return Task.CompletedTask;
}
Task RemoveConnectionStringAsync();
/// <summary>
/// Saves the connection string to the configuration file
@@ -33,11 +14,7 @@ public interface IConfigManipulator
/// <param name="connectionString"></param>
/// <param name="providerName"></param>
/// <returns></returns>
Task SaveConnectionStringAsync(string connectionString, string? providerName)
{
SaveConnectionString(connectionString, providerName);
return Task.CompletedTask;
}
Task SaveConnectionStringAsync(string connectionString, string? providerName);
/// <summary>
/// Updates a value in the configuration file.
@@ -46,11 +23,7 @@ public interface IConfigManipulator
/// <param name="itemPath">Path to update, uses : as the separator.</param>
/// <param name="value">The new value.</param>
/// <returns></returns>
Task SaveConfigValueAsync(string itemPath, object value)
{
SaveConfigValue(itemPath, value);
return Task.CompletedTask;
}
Task SaveConfigValueAsync(string itemPath, object value);
/// <summary>
/// Updates the disableRedirectUrlTracking value in the configuration file.
@@ -60,11 +33,7 @@ public interface IConfigManipulator
/// </summary>
/// <param name="disable">The value to save.</param>
/// <returns></returns>
Task SaveDisableRedirectUrlTrackingAsync(bool disable)
{
SaveDisableRedirectUrlTracking(disable);
return Task.CompletedTask;
}
Task SaveDisableRedirectUrlTrackingAsync(bool disable);
/// <summary>
/// Sets the global id in the configuration file.
@@ -74,9 +43,5 @@ public interface IConfigManipulator
/// </summary>
/// <param name="id">The ID to save.</param>
/// <returns></returns>
Task SetGlobalIdAsync(string id)
{
SetGlobalId(id);
return Task.CompletedTask;
}
Task SetGlobalIdAsync(string id);
}

35
src/Umbraco.Core/Configuration/Models/ContentDashboardSettings.cs
View File

@@ -1,35 +0,0 @@
using System.ComponentModel;
using Umbraco.Cms.Core.Configuration.Models;
namespace Umbraco.Cms.Core.Configuration;
/// <summary>
/// Typed configuration options for content dashboard settings.
/// </summary>
[Obsolete("Scheduled for removal in v16, dashboard manipulation is now done trough frontend extensions.")]
[UmbracoOptions(Constants.Configuration.ConfigContentDashboard)]
public class ContentDashboardSettings
{
private const string DefaultContentDashboardPath = "cms";
/// <summary>
/// Gets a value indicating whether the content dashboard should be available to all users.
/// </summary>
/// <value>
/// <c>true</c> if the dashboard is visible for all user groups; otherwise, <c>false</c>
/// and the default access rules for that dashboard will be in use.
/// </value>
public bool AllowContentDashboardAccessToAllUsers { get; set; } = true;
/// <summary>
/// Gets the path to use when constructing the URL for retrieving data for the content dashboard.
/// </summary>
/// <value>The URL path.</value>
[DefaultValue(DefaultContentDashboardPath)]
public string ContentDashboardPath { get; set; } = DefaultContentDashboardPath;
/// <summary>
/// Gets the allowed addresses to retrieve data for the content dashboard.
/// </summary>
public ISet<string> ContentDashboardUrlAllowlist { get; set; } = new HashSet<string>();
}

8
src/Umbraco.Core/Configuration/Models/GlobalSettings.cs
View File

@@ -25,7 +25,6 @@ public class GlobalSettings
internal const string StaticUmbracoCssPath = "~/css";
internal const string StaticUmbracoScriptsPath = "~/scripts";
internal const string StaticUmbracoMediaPath = "~/media";
internal const bool StaticInstallMissingDatabase = false;
internal const bool StaticDisableElectionForSingleServer = false;
internal const string StaticNoNodesViewPath = "~/umbraco/UmbracoWebsite/NoNodes.cshtml";
internal const string StaticDistributedLockingReadLockDefaultTimeout = "00:01:00";
@@ -114,13 +113,6 @@ public class GlobalSettings
/// </remarks>
public string UmbracoMediaPhysicalRootPath { get; set; } = null!;
/// <summary>
/// Gets or sets a value indicating whether to install the database when it is missing.
/// </summary>
[Obsolete("This option will be removed in V16.")]
[DefaultValue(StaticInstallMissingDatabase)]
public bool InstallMissingDatabase { get; set; } = StaticInstallMissingDatabase;
/// <summary>
/// Gets or sets a value indicating whether to disable the election for a single server.
/// </summary>

17
src/Umbraco.Core/Configuration/Models/NuCacheSettings.cs
View File

@@ -13,15 +13,8 @@ public class NuCacheSettings
{
internal const string StaticNuCacheSerializerType = "MessagePack";
internal const int StaticSqlPageSize = 1000;
internal const int StaticKitBatchSize = 1;
internal const bool StaticUsePagedSqlQuery = true;
/// <summary>
/// Gets or sets a value defining the BTree block size.
/// </summary>
[Obsolete("This property is no longer used. Scheduled for removal in v16")]
public int? BTreeBlockSize { get; set; }
/// <summary>
/// The serializer type that nucache uses to persist documents in the database.
/// </summary>
@@ -34,16 +27,6 @@ public class NuCacheSettings
[DefaultValue(StaticSqlPageSize)]
public int SqlPageSize { get; set; } = StaticSqlPageSize;
/// <summary>
/// The size to use for nucache Kit batches. Higher value means more content loaded into memory at a time.
/// </summary>
[DefaultValue(StaticKitBatchSize)]
[Obsolete("This property is no longer used")]
public int KitBatchSize { get; set; } = StaticKitBatchSize;
[Obsolete("This property is no longer used")]
public bool UnPublishedContentCompression { get; set; } = false;
[DefaultValue(StaticUsePagedSqlQuery)]
public bool UsePagedSqlQuery { get; set; } = true;
}

9
src/Umbraco.Core/Configuration/Models/RuntimeMinificationCacheBuster.cs
View File

@@ -1,9 +0,0 @@
namespace Umbraco.Cms.Core.Configuration.Models;
[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
public enum RuntimeMinificationCacheBuster
{
Version,
AppDomain,
Timestamp,
}

30
src/Umbraco.Core/Configuration/Models/RuntimeMinificationSettings.cs
View File

@@ -1,30 +0,0 @@
using System.ComponentModel;
namespace Umbraco.Cms.Core.Configuration.Models;
[Obsolete("Runtime minification is no longer supported. Will be removed entirely in V16.")]
[UmbracoOptions(Constants.Configuration.ConfigRuntimeMinification)]
public class RuntimeMinificationSettings
{
internal const bool StaticUseInMemoryCache = false;
internal const string StaticCacheBuster = "Version";
internal const string? StaticVersion = null;
/// <summary>
/// Use in memory cache
/// </summary>
[DefaultValue(StaticUseInMemoryCache)]
public bool UseInMemoryCache { get; set; } = StaticUseInMemoryCache;
/// <summary>
/// The cache buster type to use
/// </summary>
[DefaultValue(StaticCacheBuster)]
public RuntimeMinificationCacheBuster CacheBuster { get; set; } = Enum.Parse<RuntimeMinificationCacheBuster>(StaticCacheBuster);
/// <summary>
/// The unique version string used if CacheBuster is 'Version'.
/// </summary>
[DefaultValue(StaticVersion)]
public string? Version { get; set; } = StaticVersion;
}

17
src/Umbraco.Core/Configuration/ModelsBuilderConfigExtensions.cs
View File

@@ -2,7 +2,6 @@ using Microsoft.Extensions.Hosting;
using Umbraco.Cms.Core.Configuration.Models;
using Umbraco.Cms.Core.Exceptions;
using Umbraco.Cms.Core.Extensions;
using IHostingEnvironment = Umbraco.Cms.Core.Hosting.IHostingEnvironment;
namespace Umbraco.Extensions;
@@ -25,22 +24,6 @@ public static class ModelsBuilderConfigExtensions
return _modelsDirectoryAbsolute;
}
[Obsolete("Use the non obsoleted equivalent instead. Scheduled for removal in v16")]
public static string ModelsDirectoryAbsolute(
this ModelsBuilderSettings modelsBuilderConfig,
IHostingEnvironment hostingEnvironment)
{
if (_modelsDirectoryAbsolute is null)
{
var modelsDirectory = modelsBuilderConfig.ModelsDirectory;
var root = hostingEnvironment.MapPathContentRoot("~/");
_modelsDirectoryAbsolute = GetModelsDirectory(root, modelsDirectory, modelsBuilderConfig.AcceptUnsafeModelsDirectory);
}
return _modelsDirectoryAbsolute;
}
// internal for tests
internal static string GetModelsDirectory(string root, string config, bool acceptUnsafe)
{