From 85e6ebee4579a0548302b2ce78b5f1baeca219a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Tue, 14 Nov 2023 15:18:46 +0100 Subject: [PATCH] minor changes --- .../controller/base-extensions-initializer.test.ts | 8 +++++--- .../functions/create-extension-api.function.ts | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extensions-initializer.test.ts b/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extensions-initializer.test.ts index 3f60e57760..80f7f48008 100644 --- a/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extensions-initializer.test.ts +++ b/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extensions-initializer.test.ts @@ -48,7 +48,7 @@ class UmbTestExtensionsController< UmbTestExtensionController, MyPermittedControllerType > { - #host: UmbControllerHost; + #extensionRegistry: UmbExtensionRegistry; constructor( host: UmbControllerHost, extensionRegistry: UmbExtensionRegistry, @@ -57,12 +57,13 @@ class UmbTestExtensionsController< onChange: (permittedManifests: Array) => void ) { super(host, extensionRegistry, type, filter, onChange); - this.#host = host; + this.#extensionRegistry = extensionRegistry; this._init(); } protected _createController(manifest: ManifestWithDynamicConditions) { - return new UmbTestExtensionController(this.#host, testExtensionRegistry, manifest.alias, this._extensionChanged); + return new UmbTestExtensionController(this, this.#extensionRegistry, manifest.alias, this._extensionChanged); + } } @@ -109,6 +110,7 @@ describe('UmbBaseExtensionsController', () => { it('exposes both manifests', (done) => { let count = 0; + const extensionController = new UmbTestExtensionsController( hostElement, testExtensionRegistry, diff --git a/src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-api.function.ts b/src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-api.function.ts index 7db714a19c..c85d3e50bc 100644 --- a/src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-api.function.ts +++ b/src/Umbraco.Web.UI.Client/src/libs/extension-api/functions/create-extension-api.function.ts @@ -2,7 +2,7 @@ import { UmbApi } from "../models/api.interface.js"; import { ManifestApi, ManifestElementAndApi } from "../types/base.types.js"; import { loadManifestApi } from "./load-manifest-api.function.js"; -export async function createExtensionApi(manifest: ManifestApi | ManifestElementAndApi, constructorArguments: unknown[] = []): Promise { +export async function createExtensionApi(manifest: ManifestApi | ManifestElementAndApi, constructorArguments: Array = []): Promise { if(manifest.api) { const apiConstructor = await loadManifestApi(manifest.api);