Updated healthchecks to show a link to documentation instead of trying to fix something that can often not be fixed automatically.
This commit is contained in:
@@ -1,98 +0,0 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Linq;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Umbraco.Core.Configuration.Models;
|
||||
using Umbraco.Core.Services;
|
||||
|
||||
namespace Umbraco.Core.HealthCheck.Checks.Configuration
|
||||
{
|
||||
[HealthCheck("D0F7599E-9B2A-4D9E-9883-81C7EDC5616F", "Macro errors",
|
||||
Description =
|
||||
"Checks to make sure macro errors are not set to throw a YSOD (yellow screen of death), which would prevent certain or all pages from loading completely.",
|
||||
Group = "Configuration")]
|
||||
public class MacroErrorsCheck : AbstractSettingsCheck
|
||||
{
|
||||
private readonly ILocalizedTextService _textService;
|
||||
private readonly ILoggerFactory _loggerFactory;
|
||||
private readonly IOptionsMonitor<ContentSettings> _contentSettings;
|
||||
|
||||
public MacroErrorsCheck(ILocalizedTextService textService, ILoggerFactory loggerFactory,
|
||||
IOptionsMonitor<ContentSettings> contentSettings)
|
||||
: base(textService, loggerFactory)
|
||||
{
|
||||
_textService = textService;
|
||||
_loggerFactory = loggerFactory;
|
||||
_contentSettings = contentSettings;
|
||||
}
|
||||
|
||||
public override ValueComparisonType ValueComparisonType => ValueComparisonType.ShouldEqual;
|
||||
|
||||
public override string ItemPath => Constants.Configuration.ConfigContentMacroErrors;
|
||||
|
||||
|
||||
/// <summary>
|
||||
/// Gets the values to compare against.
|
||||
/// </summary>
|
||||
public override IEnumerable<AcceptableConfiguration> Values
|
||||
{
|
||||
get
|
||||
{
|
||||
var values = new List<AcceptableConfiguration>
|
||||
{
|
||||
new AcceptableConfiguration
|
||||
{
|
||||
IsRecommended = true,
|
||||
Value = "inline"
|
||||
},
|
||||
new AcceptableConfiguration
|
||||
{
|
||||
IsRecommended = false,
|
||||
Value = "silent"
|
||||
}
|
||||
};
|
||||
|
||||
return values;
|
||||
}
|
||||
}
|
||||
|
||||
public override string CurrentValue => _contentSettings.CurrentValue.MacroErrors.ToString();
|
||||
|
||||
/// <summary>
|
||||
/// Gets the message for when the check has succeeded.
|
||||
/// </summary>
|
||||
public override string CheckSuccessMessage
|
||||
{
|
||||
get
|
||||
{
|
||||
return _textService.Localize("healthcheck/macroErrorModeCheckSuccessMessage",
|
||||
new[] { CurrentValue, Values.First(v => v.IsRecommended).Value });
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Gets the message for when the check has failed.
|
||||
/// </summary>
|
||||
public override string CheckErrorMessage
|
||||
{
|
||||
get
|
||||
{
|
||||
return _textService.Localize("healthcheck/macroErrorModeCheckErrorMessage",
|
||||
new[] { CurrentValue, Values.First(v => v.IsRecommended).Value });
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Gets the rectify success message.
|
||||
/// </summary>
|
||||
public override string RectifySuccessMessage
|
||||
{
|
||||
get
|
||||
{
|
||||
return TextService.Localize("healthcheck/macroErrorModeCheckRectifySuccessMessage",
|
||||
new[] { Values.First(v => v.IsRecommended).Value });
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -2,7 +2,7 @@
|
||||
// See LICENSE for more details.
|
||||
|
||||
using System.Collections.Generic;
|
||||
using Umbraco.Core.HealthCheck;
|
||||
using Umbraco.Core.HealthChecks;
|
||||
|
||||
namespace Umbraco.Core.Configuration.Models
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user