diff --git a/build/azure-pipelines.yml b/build/azure-pipelines.yml index 1a6ca02fd2..d95949d865 100644 --- a/build/azure-pipelines.yml +++ b/build/azure-pipelines.yml @@ -25,7 +25,8 @@ stages: vmImage: windows-latest steps: - task: PowerShell@1 - displayName: Set $isRelease variable + name: setReleaseVariable + displayName: Set isRelease variable inputs: scriptType: inlineScript inlineScript: > @@ -33,9 +34,9 @@ stages: if ($isRelease.Count -gt 0){ Write-Host "##vso[build.addbuildtag]Release build" - Write-Host "##vso[task.setvariable variable=isRelease]true" + Write-Host "##vso[task.setvariable variable=isRelease;isOutput=true]true" }else{ - Write-Host "##vso[task.setvariable variable=isRelease]false" + Write-Host "##vso[task.setvariable variable=isRelease;isOutput=true]false" } - stage: Unit_Tests displayName: Unit Tests @@ -356,6 +357,7 @@ stages: $version = $ubuild.GetUmbracoVersion() + $isRelease = [regex]::matches($env:BUILD_SOURCEBRANCH,"v\d+\/\d+.\d+.*") if ($isRelease.Count -gt 0){ $continuous = $version.Semver @@ -476,11 +478,11 @@ stages: - stage: Artifacts_Docs displayName: 'Static Code Documentation' dependsOn: [Determine_build_type] - condition: 'eq(variables.IsRelease, true)' jobs: - job: Generate_Docs_CSharp timeoutInMinutes: 60 displayName: Generate C# Docs + condition: eq(stageDependencies.Determine_build_type.Set_build_variables.outputs['setReleaseVariable.isRelease'], 'true') pool: vmImage: windows-latest steps: @@ -521,10 +523,10 @@ stages: targetPath: $(Build.ArtifactStagingDirectory)\docs\csharp-docs.zip artifact: docs-cs publishLocation: pipeline - - job: Generate_Docs_JS timeoutInMinutes: 60 displayName: Generate JS Docs + condition: eq(stageDependencies.Determine_build_type.Set_build_variables.outputs['setReleaseVariable.isRelease'], 'true') pool: vmImage: windows-latest steps: diff --git a/src/Directory.Build.props b/src/Directory.Build.props index a1220f9b3f..431bd07fd3 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -2,7 +2,7 @@ 9.0.0 9.0.0 - 9.0.0-beta004 + 9.0.0-rc001.pre001 9.0.0 9.0 en-US diff --git a/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs b/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs index 0aa6fca5a9..51bf3c477c 100644 --- a/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs +++ b/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs @@ -15,15 +15,18 @@ namespace Umbraco.Cms.Core.PropertyEditors.ValueConverters { private readonly IPublishedSnapshotAccessor _publishedSnapshotAccessor; private readonly IPublishedUrlProvider _publishedUrlProvider; + private readonly IPublishedValueFallback _publishedValueFallback; private readonly IJsonSerializer _jsonSerializer; public MediaPickerWithCropsValueConverter( IPublishedSnapshotAccessor publishedSnapshotAccessor, IPublishedUrlProvider publishedUrlProvider, + IPublishedValueFallback publishedValueFallback, IJsonSerializer jsonSerializer) { _publishedSnapshotAccessor = publishedSnapshotAccessor ?? throw new ArgumentNullException(nameof(publishedSnapshotAccessor)); _publishedUrlProvider = publishedUrlProvider; + _publishedValueFallback = publishedValueFallback; _jsonSerializer = jsonSerializer; } @@ -77,7 +80,7 @@ namespace Umbraco.Cms.Core.PropertyEditors.ValueConverters // TODO: This should be optimized/cached, as calling Activator.CreateInstance is slow var mediaWithCropsType = typeof(MediaWithCrops<>).MakeGenericType(mediaItem.GetType()); - var mediaWithCrops = (MediaWithCrops)Activator.CreateInstance(mediaWithCropsType, mediaItem, localCrops); + var mediaWithCrops = (MediaWithCrops)Activator.CreateInstance(mediaWithCropsType, mediaItem, _publishedValueFallback, localCrops); mediaItems.Add(mediaWithCrops); diff --git a/src/Umbraco.Web.UI.NetCore/Umbraco.Web.UI.NetCore.csproj b/src/Umbraco.Web.UI.NetCore/Umbraco.Web.UI.NetCore.csproj index 0b345753d0..9ebbc7b562 100644 --- a/src/Umbraco.Web.UI.NetCore/Umbraco.Web.UI.NetCore.csproj +++ b/src/Umbraco.Web.UI.NetCore/Umbraco.Web.UI.NetCore.csproj @@ -5,63 +5,62 @@ Umbraco.Cms.Web.UI.NetCore - bin\Release\Umbraco.Web.UI.NetCore.xml + bin/Release/Umbraco.Web.UI.NetCore.xml true - - - - - + + + + + - - - - - - + + + + + - - - - + + + + - - - - - + + + + + - + true Always - + true Always - - - - - + + + + + @@ -83,8 +82,8 @@ - $(ProjectDir)wwwroot\umbraco - $(ProjectDir)umbraco\config\appsettings-schema.json + $(ProjectDir)wwwroot/umbraco + $(ProjectDir)umbraco/config/appsettings-schema.json @@ -103,10 +102,10 @@ - + - +