From 8a6d2cc3b05fc8101cade34a8ac2470acea4e1a2 Mon Sep 17 00:00:00 2001
From: Jose Marcenaro <josem@tercerplaneta.com>
Date: Tue, 28 Apr 2020 21:36:11 -0300
Subject: [PATCH] Add varchar(max) support in DTO attributes

[SpecialDbType(SpecialDbTypes.NVARCHARMAX)]
---
 .../Persistence/DatabaseAnnotations/SpecialDbTypes.cs       | 3 ++-
 src/Umbraco.Core/Persistence/PocoDataDataReader.cs          | 3 +++
 .../Persistence/SqlSyntax/SqlCeSyntaxProvider.cs            | 6 ++++++
 .../Persistence/SqlSyntax/SqlSyntaxProviderBase.cs          | 6 ++++++
 4 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/Umbraco.Core/Persistence/DatabaseAnnotations/SpecialDbTypes.cs b/src/Umbraco.Core/Persistence/DatabaseAnnotations/SpecialDbTypes.cs
index 4b606bc0f5..6d211ebbd9 100644
--- a/src/Umbraco.Core/Persistence/DatabaseAnnotations/SpecialDbTypes.cs
+++ b/src/Umbraco.Core/Persistence/DatabaseAnnotations/SpecialDbTypes.cs
@@ -7,6 +7,7 @@
     public enum SpecialDbTypes
     {
         NTEXT,
-        NCHAR
+        NCHAR,
+        NVARCHARMAX
     }
 }
diff --git a/src/Umbraco.Core/Persistence/PocoDataDataReader.cs b/src/Umbraco.Core/Persistence/PocoDataDataReader.cs
index 1d7d301b87..460a4d3d90 100644
--- a/src/Umbraco.Core/Persistence/PocoDataDataReader.cs
+++ b/src/Umbraco.Core/Persistence/PocoDataDataReader.cs
@@ -79,6 +79,9 @@ namespace Umbraco.Core.Persistence
                         case SpecialDbTypes.NCHAR:
                             sqlDbType = SqlDbType.NChar;
                             break;
+                        case SpecialDbTypes.NVARCHARMAX:
+                            sqlDbType = SqlDbType.NVarChar;
+                            break;
                         default:
                             throw new ArgumentOutOfRangeException();
                     }
diff --git a/src/Umbraco.Core/Persistence/SqlSyntax/SqlCeSyntaxProvider.cs b/src/Umbraco.Core/Persistence/SqlSyntax/SqlCeSyntaxProvider.cs
index 2ed0fb878c..ffdeb3bb2a 100644
--- a/src/Umbraco.Core/Persistence/SqlSyntax/SqlCeSyntaxProvider.cs
+++ b/src/Umbraco.Core/Persistence/SqlSyntax/SqlCeSyntaxProvider.cs
@@ -231,5 +231,11 @@ where table_name=@0 and column_name=@1", tableName, columnName).FirstOrDefault()
 
         public override string DropIndex { get { return "DROP INDEX {1}.{0}"; } }
 
+        public override string GetSpecialDbType(SpecialDbTypes dbTypes)
+        {
+            if (dbTypes == SpecialDbTypes.NVARCHARMAX) // SqlCE does not have nvarchar(max) for now
+                return "NTEXT";
+            return base.GetSpecialDbType(dbTypes);
+        }
     }
 }
diff --git a/src/Umbraco.Core/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs b/src/Umbraco.Core/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs
index b2e03df96e..8cd9932eaf 100644
--- a/src/Umbraco.Core/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs
+++ b/src/Umbraco.Core/Persistence/SqlSyntax/SqlSyntaxProviderBase.cs
@@ -196,7 +196,13 @@ namespace Umbraco.Core.Persistence.SqlSyntax
                 return "NCHAR";
             }
             else if (dbTypes == SpecialDbTypes.NTEXT)
+            {
                 return "NTEXT";
+            }
+            else if (dbTypes == SpecialDbTypes.NVARCHARMAX)
+            {
+                return "NVARCHAR(MAX)";
+            }
 
             return "NVARCHAR";
         }