yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

no need to support object with asObservable

Browse Source
This commit is contained in:
Niels Lyngsø
2023-08-03 11:02:17 +02:00
parent c53915ce3f
commit 8a9124f79c
2 changed files with 5 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Umbraco.Web.UI.Client/src/libs/class-api/class.mixin.ts
View File

@@ -71,17 +71,8 @@ export const UmbClassMixin = <T extends ClassConstructor>(superClass: T) => {
* @return {UmbObserverController} Reference to a Observer Controller instance
* @memberof UmbElementMixin
*/
observe<T>(
source: Observable<T> | { asObservable: () => Observable<T> },
callback: (_value: T) => void,
controllerAlias?: UmbControllerAlias
) {
return new UmbObserverController<T>(
this,
(source as any).asObservable ? (source as any).asObservable() : source,
callback,
controllerAlias
);
observe<T>(source: Observable<T>, callback: (_value: T) => void, controllerAlias?: UmbControllerAlias) {
return new UmbObserverController<T>(this, source, callback, controllerAlias);
}
/**

15
src/Umbraco.Web.UI.Client/src/libs/element-api/element.mixin.ts
View File

@@ -1,3 +1,4 @@
import { UmbLocalizeController } from '@umbraco-cms/backoffice/localization-api';
import type { Observable } from '@umbraco-cms/backoffice/external/rxjs';
import type { HTMLElementConstructor } from '@umbraco-cms/backoffice/extension-api';
import { UmbControllerHostElementMixin } from '@umbraco-cms/backoffice/controller-api';
@@ -9,7 +10,6 @@ import {
UmbContextProviderController,
} from '@umbraco-cms/backoffice/context-api';
import { ObserverCallback, UmbObserverController } from '@umbraco-cms/backoffice/observable-api';
import { UmbLocalizeController } from '@umbraco-cms/backoffice/localization-api';
import { property } from '@umbraco-cms/backoffice/external/lit';
export declare class UmbElement extends UmbControllerHostElement {
@@ -47,17 +47,8 @@ export const UmbElementMixin = <T extends HTMLElementConstructor>(superClass: T)
* @return {UmbObserverController} Reference to a Observer Controller instance
* @memberof UmbElementMixin
*/
observe<T>(
source: Observable<T> | { asObservable: () => Observable<T> },
callback: ObserverCallback<T>,
unique?: string
) {
return new UmbObserverController<T>(
this,
(source as any).asObservable ? (source as any).asObservable() : source,
callback,
unique
);
observe<T>(source: Observable<T>, callback: ObserverCallback<T>, unique?: string) {
return new UmbObserverController<T>(this, source, callback, unique);
}
/**