From 8bc9d05a3fed83010d0556918040d8d47339ffcc Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Wed, 3 Feb 2021 11:37:32 +0100 Subject: [PATCH] Better description of success when value is null --- .../Checks/Configuration/NotificationEmailCheck.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Core/HealthChecks/Checks/Configuration/NotificationEmailCheck.cs b/src/Umbraco.Core/HealthChecks/Checks/Configuration/NotificationEmailCheck.cs index 474a450e82..be0793635f 100644 --- a/src/Umbraco.Core/HealthChecks/Checks/Configuration/NotificationEmailCheck.cs +++ b/src/Umbraco.Core/HealthChecks/Checks/Configuration/NotificationEmailCheck.cs @@ -39,14 +39,17 @@ namespace Umbraco.Core.HealthChecks.Checks.Configuration /// public override IEnumerable Values => new List { - new AcceptableConfiguration { IsRecommended = false, Value = DefaultFromEmail } + new AcceptableConfiguration { IsRecommended = false, Value = DefaultFromEmail }, + new AcceptableConfiguration { IsRecommended = false, Value = string.Empty } }; /// public override string CurrentValue => _contentSettings.CurrentValue.Notifications.Email; /// - public override string CheckSuccessMessage => LocalizedTextService.Localize("healthcheck/notificationEmailsCheckSuccessMessage", new[] { CurrentValue }); + public override string CheckSuccessMessage => + LocalizedTextService.Localize("healthcheck/notificationEmailsCheckSuccessMessage", + new[] { CurrentValue ?? "<null>" }); /// public override string CheckErrorMessage => LocalizedTextService.Localize("healthcheck/notificationEmailsCheckErrorMessage", new[] { DefaultFromEmail });