From 8d0df6cec39bda3ae4d8d440132a86a60c8d4303 Mon Sep 17 00:00:00 2001
From: Jan Skovgaard <jaskov@gmail.com>
Date: Wed, 14 Aug 2019 17:21:56 +0200
Subject: [PATCH] =?UTF-8?q?Accessibility:=20Open=20User=20Details=20-=20Ba?=
 =?UTF-8?q?ck=20icon=20arrow=20is=20identifie=E2=80=A6=20(#5970)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/Umbraco.Web.UI.Client/src/less/components/editor.less  | 7 +++++--
 .../views/components/editor/umb-editor-content-header.html | 5 +++--
 .../src/views/components/editor/umb-editor-header.html     | 5 +++--
 src/Umbraco.Web.UI/Umbraco/config/lang/da.xml              | 3 +++
 src/Umbraco.Web.UI/Umbraco/config/lang/en.xml              | 5 ++++-
 src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml           | 3 +++
 6 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/less/components/editor.less b/src/Umbraco.Web.UI.Client/src/less/components/editor.less
index 52dd7ea678..2a1d047ca1 100644
--- a/src/Umbraco.Web.UI.Client/src/less/components/editor.less
+++ b/src/Umbraco.Web.UI.Client/src/less/components/editor.less
@@ -74,8 +74,11 @@
 }
 
 .umb-editor-header__back {
-	color: @gray-6;
-    margin-bottom: 1px;
+    background: transparent;
+    border: 0;
+    color: @gray-6;
+    margin: 0 0 1px 0;
+    padding: 0;
 	transition: color 0.1s ease-in-out;
 }
 
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
index ba6714987c..6856daf42b 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
@@ -3,9 +3,10 @@
     <div class="flex items-center" style="height: 100%;">
 
         <div ng-if="showBackButton === true && splitViewOpen !== true" style="margin-right: 15px;">
-            <a class="umb-editor-header__back" href="#" ng-click="goBack()" prevent-default>
+            <button type="button" class="umb-editor-header__back" ng-click="goBack()" prevent-default>
                 <i class="fa fa-arrow-left" aria-hidden="true"></i>
-            </a>
+                <span class="sr-only"><localize key="visuallyHiddenTexts_goBack">Go back</localize></span>
+            </button>
         </div>
 
         <div class="flex items-center" style="flex: 1;">
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-header.html b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-header.html
index cc2ef0f2fa..aca27da7be 100644
--- a/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-header.html
+++ b/src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-header.html
@@ -3,9 +3,10 @@
     <div class="flex items-center" style="height: 100%;">
 
         <div ng-if="showBackButton === true && splitViewOpen !== true" style="margin-right: 15px;">
-            <a class="umb-editor-header__back" href="#" ng-click="goBack()" prevent-default>
+            <button type="button" class="umb-editor-header__back" ng-click="goBack()" prevent-default>
                 <i class="fa fa-arrow-left" aria-hidden="true"></i>
-            </a>
+                <span class="sr-only"><localize key="visuallyHiddenTexts_goBack">Go back</localize></span>
+            </button>
         </div>
 
         <div class="flex items-center" style="flex: 1;">
diff --git a/src/Umbraco.Web.UI/Umbraco/config/lang/da.xml b/src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
index c200f1f35e..614e5f8e8e 100644
--- a/src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
+++ b/src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
@@ -1610,4 +1610,7 @@ Mange hilsner fra Umbraco robotten
     <key alias="memberIntro">Kom godt i gang</key>
     <key alias="formsInstall">Installer Umbraco Forms</key>
   </area>
+  <area alias="visuallyHiddenTexts">
+    <key alias="goBack">Gå tilbage</key>
+  </area>
 </language>
diff --git a/src/Umbraco.Web.UI/Umbraco/config/lang/en.xml b/src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
index f3e8ba135b..b9351e324f 100644
--- a/src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
+++ b/src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
@@ -2127,5 +2127,8 @@ To manage your website, simply open the Umbraco back office and start adding con
     <key alias="settingsProfiler">Profiling</key>
     <key alias="memberIntro">Getting Started</key>
     <key alias="formsInstall">Install Umbraco Forms</key>
-  </area>>
+  </area>
+  <area alias="visuallyHiddenTexts">
+    <key alias="goBack">Go back</key>
+  </area>
 </language>
diff --git a/src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml b/src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
index a171d00d32..5f2b1eccf3 100644
--- a/src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
+++ b/src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
@@ -2142,4 +2142,7 @@ To manage your website, simply open the Umbraco back office and start adding con
     <key alias="memberIntro">Getting Started</key>
     <key alias="formsInstall">Install Umbraco Forms</key>
   </area>
+  <area alias="visuallyHiddenTexts">
+    <key alias="goBack">Go back</key>
+  </area>
 </language>