From 8edf5bb403887623904ebbb64c52aef3deb26000 Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Wed, 31 Jul 2024 14:51:05 +0200 Subject: [PATCH] only render overlay if the editor doesn't support readonly --- .../property/property/property.element.ts | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property/property/property.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property/property/property.element.ts index 13ff6952d9..927bdee191 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property/property/property.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property/property/property.element.ts @@ -171,7 +171,10 @@ export class UmbPropertyElement extends UmbLitElement { private _mandatory?: boolean; @state() - _isReadOnly = false; + private _supportsReadOnly: boolean = false; + + @state() + private _isReadOnly = false; #propertyContext = new UmbPropertyContext(this); @@ -272,6 +275,7 @@ export class UmbPropertyElement extends UmbLitElement { } const el = await createExtensionElement(manifest); + this._supportsReadOnly = manifest.meta.supportsReadOnly || false; if (el) { const oldElement = this._element; @@ -347,9 +351,7 @@ export class UmbPropertyElement extends UmbLitElement { ${this._variantDifference ? html`${this._variantDifference}` : ''} -
- ${this._isReadOnly ? html`
` : nothing}${this._element} -
+ ${this.#renderPropertyEditor()} `; } @@ -365,6 +367,15 @@ export class UmbPropertyElement extends UmbLitElement { `; } + #renderPropertyEditor() { + return html` +
+ ${this._isReadOnly && this._supportsReadOnly === false ? html`
` : nothing} + ${this._element} +
+ `; + } + static override styles = [ UmbTextStyles, css`