V10: merge release branch 20220620 (#12590)
* Add Umbraco specific global usings * Enable implicit usings * v10: Wait for updated ConnectionStrings during install (#12536) * Do not change/reload configuration * Wait for updated connection string options * recase assigndomain (#12448) * Add depth property to ICoreScope (#12540) * Remove ambient scope stack from httpcontext.items. (#12539) This change makes it easier to use service calls in parallel whilst a httpcontext is available. * v10: Prefer SQLite primitive types to flexible types (#12541) * Prefer SQLite primitive types to flexible types. * SQLite - column mappings use TEXT for decimals Thanks @mattbrailsford for sense check. * Fix issue where languages files are not found in subdir of package dir (#12543) * Make FindContent return type nullable (#12545) * Updated nuget dependencies (07-06-2022) (#12525) * Updated nuget dependencies * Move Nerdbank.GitVersioning update to Directory.Build.props * Updated more dependencies * Improve FlagOutOfDateModels property behaviour. (cherry picked from commit 54077725c373495fce0d3fbc5cdb6469aad3b676) * Fix logic error WRT models builder flag out of date models. (#12548) (cherry picked from commit 6b0149803a879d1c6902a5f61d1f2e9dc8545aac) * Fixed issue with expected null value. (#12550) Fixes https://github.com/umbraco/Umbraco-CMS/issues/12526 * Updated Examine to 3.0.0 * Fixes relation issue, when moving a root item to recycle bin, the "Relate Parent Media Folder On Delete"/"Relate Parent Document On Delete" cannot get the parent node type, because it is a fake root. * Fix possible null error * Bump version to 10.0.0 final * Fix attempting to write lock files to LocalTempPath before it exists (#12563) * Re fix usage statements Co-authored-by: Ronald Barendse <ronald@barend.se> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> Co-authored-by: Paul Johnson <pmj@umbraco.com> Co-authored-by: Bjarke Berg <mail@bergmania.dk>
This commit is contained in:
@@ -226,56 +226,6 @@ namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Scoping
|
||||
Assert.IsNull(scopeProvider.AmbientScope);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void NestedMigrateScope()
|
||||
{
|
||||
// Get the request cache mock and re-configure it to be available and used
|
||||
var requestCacheDictionary = new Dictionary<string, object>();
|
||||
IRequestCache requestCache = AppCaches.RequestCache;
|
||||
var requestCacheMock = Mock.Get(requestCache);
|
||||
requestCacheMock
|
||||
.Setup(x => x.IsAvailable)
|
||||
.Returns(true);
|
||||
requestCacheMock
|
||||
.Setup(x => x.Set(It.IsAny<string>(), It.IsAny<object>()))
|
||||
.Returns((string key, object val) =>
|
||||
{
|
||||
requestCacheDictionary.Add(key, val);
|
||||
return true;
|
||||
});
|
||||
requestCacheMock
|
||||
.Setup(x => x.Get(It.IsAny<string>()))
|
||||
.Returns((string key) => requestCacheDictionary.TryGetValue(key, out var val) ? val : null);
|
||||
|
||||
ScopeProvider scopeProvider = ScopeProvider;
|
||||
Assert.IsNull(scopeProvider.AmbientScope);
|
||||
|
||||
using (IScope scope = scopeProvider.CreateScope())
|
||||
{
|
||||
Assert.IsInstanceOf<Scope>(scope);
|
||||
Assert.IsNotNull(scopeProvider.AmbientScope);
|
||||
Assert.AreSame(scope, scopeProvider.AmbientScope);
|
||||
|
||||
using (IScope nested = scopeProvider.CreateScope(callContext: true))
|
||||
{
|
||||
Assert.IsInstanceOf<Scope>(nested);
|
||||
Assert.IsNotNull(scopeProvider.AmbientScope);
|
||||
Assert.AreSame(nested, scopeProvider.AmbientScope);
|
||||
Assert.AreSame(scope, ((Scope)nested).ParentScope);
|
||||
|
||||
// it's moved over to call context
|
||||
ConcurrentStack<IScope> callContextScope = scopeProvider.GetCallContextScopeValue();
|
||||
|
||||
Assert.IsNotNull(callContextScope);
|
||||
Assert.AreEqual(2, callContextScope.Count);
|
||||
}
|
||||
|
||||
// it's naturally back in http context
|
||||
}
|
||||
|
||||
Assert.IsNull(scopeProvider.AmbientScope);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void NestedCreateScopeContext()
|
||||
{
|
||||
|
||||
@@ -134,11 +134,6 @@ namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Services
|
||||
{
|
||||
try
|
||||
{
|
||||
ConcurrentStack<IScope>
|
||||
currentStack = ((ScopeProvider)ScopeProvider).GetCallContextScopeValue();
|
||||
log.LogInformation("[{ThreadId}] Current Stack? {CurrentStack}",
|
||||
Thread.CurrentThread.ManagedThreadId, currentStack?.Count);
|
||||
|
||||
// NOTE: This is NULL because we have supressed the execution context flow.
|
||||
// If we don't do that we will get various exceptions because we're trying to run concurrent threads
|
||||
// against an ambient context which cannot be done due to the rules of scope creation and completion.
|
||||
@@ -234,11 +229,6 @@ namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Services
|
||||
{
|
||||
try
|
||||
{
|
||||
ConcurrentStack<IScope>
|
||||
currentStack = ((ScopeProvider)ScopeProvider).GetCallContextScopeValue();
|
||||
log.LogInformation("[{ThreadId}] Current Stack? {CurrentStack}",
|
||||
Thread.CurrentThread.ManagedThreadId, currentStack?.Count);
|
||||
|
||||
// NOTE: This is NULL because we have supressed the execution context flow.
|
||||
// If we don't do that we will get various exceptions because we're trying to run concurrent threads
|
||||
// against an ambient context which cannot be done due to the rules of scope creation and completion.
|
||||
|
||||
Reference in New Issue
Block a user