From 916e442ee498ede35549e1a84646ca57caf8a24f Mon Sep 17 00:00:00 2001
From: Sebastiaan Janssen <sebastiaan@umbraco.com>
Date: Thu, 28 Feb 2013 09:53:57 -0100
Subject: [PATCH] Fix errors in log caused by no prevalues beind selected.

---
 .../DefaultDataKeyValue.cs                    | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/umbraco.editorControls/DefaultDataKeyValue.cs b/src/umbraco.editorControls/DefaultDataKeyValue.cs
index d8bcacf26f..ea67ac299a 100644
--- a/src/umbraco.editorControls/DefaultDataKeyValue.cs
+++ b/src/umbraco.editorControls/DefaultDataKeyValue.cs
@@ -20,17 +20,22 @@ namespace umbraco.editorControls
 		{
 			// Get the value from 
 			string v = "";
-			try 
+			try
 			{
-                IRecordsReader dr = SqlHelper.ExecuteReader("Select [value] from cmsDataTypeprevalues where id in (" + SqlHelper.EscapeString(Value.ToString()) + ")");
+                // Don't query if there's nothing to query for..
+                if (string.IsNullOrWhiteSpace(Value.ToString()) == false)
+                {
+                    IRecordsReader dr = SqlHelper.ExecuteReader("Select [value] from cmsDataTypeprevalues where id in (@id)", SqlHelper.CreateParameter("id", Value.ToString()));
 
-				while (dr.Read()) {
-					if (v.Length == 0)
-						v += dr.GetString("value");
-					else
-						v += "," + dr.GetString("value");
-				}
-				dr.Close();
+                    while (dr.Read())
+                    {
+                        if (v.Length == 0)
+                            v += dr.GetString("value");
+                        else
+                            v += "," + dr.GetString("value");
+                    }
+                    dr.Close();
+                }
 			} 
 			catch {}
 			return d.CreateCDataSection(v);