diff --git a/src/Umbraco.Core/Cache/CacheHelper.cs b/src/Umbraco.Core/Cache/CacheHelper.cs
index 2b43e857f0..cd2225ae9d 100644
--- a/src/Umbraco.Core/Cache/CacheHelper.cs
+++ b/src/Umbraco.Core/Cache/CacheHelper.cs
@@ -8,23 +8,6 @@ namespace Umbraco.Core.Cache
///
public class CacheHelper
{
- public static CacheHelper NoCache { get; } = new CacheHelper(NullCacheProvider.Instance, NullCacheProvider.Instance, NullCacheProvider.Instance, new IsolatedRuntimeCache(_ => NullCacheProvider.Instance));
-
- ///
- /// Creates a cache helper with disabled caches
- ///
- ///
- ///
- /// Good for unit testing
- ///
- public static CacheHelper CreateDisabledCacheHelper()
- {
- // do *not* return NoCache
- // NoCache is a special instance that is detected by RepositoryBase and disables all cache policies
- // CreateDisabledCacheHelper is used in tests to use no cache, *but* keep all cache policies
- return new DisabledCacheHelper();
- }
-
///
/// Initializes a new instance for use in the web
///
@@ -64,6 +47,24 @@ namespace Umbraco.Core.Cache
IsolatedRuntimeCache = isolatedCacheManager ?? throw new ArgumentNullException(nameof(isolatedCacheManager));
}
+ ///
+ /// Gets the special disabled instance.
+ ///
+ ///
+ /// When used by repositories, all cache policies apply, but the underlying caches do not cache anything.
+ /// Used by tests.
+ ///
+ public static CacheHelper Disabled { get; } = new CacheHelper(NullCacheProvider.Instance, NullCacheProvider.Instance, NullCacheProvider.Instance, new IsolatedRuntimeCache(_ => NullCacheProvider.Instance));
+
+ ///
+ /// Gets the special no-cache instance.
+ ///
+ ///
+ /// When used by repositories, all cache policies are bypassed.
+ /// Used by repositories that do no cache.
+ ///
+ public static CacheHelper NoCache { get; } = new CacheHelper(NullCacheProvider.Instance, NullCacheProvider.Instance, NullCacheProvider.Instance, new IsolatedRuntimeCache(_ => NullCacheProvider.Instance));
+
///
/// Returns the current Request cache
///
diff --git a/src/Umbraco.Core/Cache/DisabledCacheHelper.cs b/src/Umbraco.Core/Cache/DisabledCacheHelper.cs
deleted file mode 100644
index 104c6b8bc0..0000000000
--- a/src/Umbraco.Core/Cache/DisabledCacheHelper.cs
+++ /dev/null
@@ -1,15 +0,0 @@
-namespace Umbraco.Core.Cache
-{
- ///
- /// Represent disabled application-wide caches.
- ///
- public class DisabledCacheHelper : CacheHelper
- {
- ///
- /// Initializes a new instance of the .
- ///
- public DisabledCacheHelper()
- : base(NullCacheProvider.Instance, NullCacheProvider.Instance, NullCacheProvider.Instance, new IsolatedRuntimeCache(_ => NullCacheProvider.Instance))
- { }
- }
-}
\ No newline at end of file
diff --git a/src/Umbraco.Core/Composing/CompositionRoots/RepositoryCompositionRoot.cs b/src/Umbraco.Core/Composing/CompositionRoots/RepositoryCompositionRoot.cs
index fb90707fee..afea71a074 100644
--- a/src/Umbraco.Core/Composing/CompositionRoots/RepositoryCompositionRoot.cs
+++ b/src/Umbraco.Core/Composing/CompositionRoots/RepositoryCompositionRoot.cs
@@ -19,11 +19,6 @@ namespace Umbraco.Core.Composing.CompositionRoots
public void Compose(IServiceRegistry container)
{
- // register cache helpers
- // the main cache helper is registered by CoreBootManager and is used by most repositories
- // the disabled one is used by those repositories that require it
- container.RegisterSingleton();
-
// resolve ctor dependency from GetInstance() runtimeArguments, if possible - 'factory' is
// the container, 'info' describes the ctor argument, and 'args' contains the args that
// were passed to GetInstance() - use first arg if it is the right type,
diff --git a/src/Umbraco.Core/Persistence/Repositories/Implement/AuditRepository.cs b/src/Umbraco.Core/Persistence/Repositories/Implement/AuditRepository.cs
index 403efd7e59..cd9d37aa0f 100644
--- a/src/Umbraco.Core/Persistence/Repositories/Implement/AuditRepository.cs
+++ b/src/Umbraco.Core/Persistence/Repositories/Implement/AuditRepository.cs
@@ -14,8 +14,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement
{
internal class AuditRepository : NPocoRepositoryBase, IAuditRepository
{
- public AuditRepository(IScopeAccessor scopeAccessor, DisabledCacheHelper cache, ILogger logger)
- : base(scopeAccessor, cache, logger)
+ public AuditRepository(IScopeAccessor scopeAccessor, ILogger logger)
+ : base(scopeAccessor, CacheHelper.NoCache, logger)
{ }
protected override void PersistNewItem(IAuditItem entity)
diff --git a/src/Umbraco.Core/Persistence/Repositories/Implement/RelationRepository.cs b/src/Umbraco.Core/Persistence/Repositories/Implement/RelationRepository.cs
index 732d01a868..fb5ba00ea0 100644
--- a/src/Umbraco.Core/Persistence/Repositories/Implement/RelationRepository.cs
+++ b/src/Umbraco.Core/Persistence/Repositories/Implement/RelationRepository.cs
@@ -20,8 +20,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement
{
private readonly IRelationTypeRepository _relationTypeRepository;
- public RelationRepository(IScopeAccessor scopeAccessor, DisabledCacheHelper cache, ILogger logger, IRelationTypeRepository relationTypeRepository)
- : base(scopeAccessor, cache, logger)
+ public RelationRepository(IScopeAccessor scopeAccessor, ILogger logger, IRelationTypeRepository relationTypeRepository)
+ : base(scopeAccessor, CacheHelper.NoCache, logger)
{
_relationTypeRepository = relationTypeRepository;
}
diff --git a/src/Umbraco.Core/Persistence/Repositories/Implement/ServerRegistrationRepository.cs b/src/Umbraco.Core/Persistence/Repositories/Implement/ServerRegistrationRepository.cs
index 531df1ba13..2679f8f92f 100644
--- a/src/Umbraco.Core/Persistence/Repositories/Implement/ServerRegistrationRepository.cs
+++ b/src/Umbraco.Core/Persistence/Repositories/Implement/ServerRegistrationRepository.cs
@@ -14,9 +14,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement
{
internal class ServerRegistrationRepository : NPocoRepositoryBase, IServerRegistrationRepository
{
- // fixme - should we use NoCache instead of CreateDisabledCacheHelper?!
public ServerRegistrationRepository(IScopeAccessor scopeAccessor, ILogger logger)
- : base(scopeAccessor, CacheHelper.CreateDisabledCacheHelper(), logger)
+ : base(scopeAccessor, CacheHelper.NoCache, logger)
{ }
protected override IRepositoryCachePolicy CreateCachePolicy()
diff --git a/src/Umbraco.Core/Persistence/Repositories/Implement/TaskRepository.cs b/src/Umbraco.Core/Persistence/Repositories/Implement/TaskRepository.cs
index 972b528d76..1b44fd8cc8 100644
--- a/src/Umbraco.Core/Persistence/Repositories/Implement/TaskRepository.cs
+++ b/src/Umbraco.Core/Persistence/Repositories/Implement/TaskRepository.cs
@@ -15,8 +15,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement
{
internal class TaskRepository : NPocoRepositoryBase, ITaskRepository
{
- public TaskRepository(IScopeAccessor scopeAccessor, DisabledCacheHelper cache, ILogger logger)
- : base(scopeAccessor, cache, logger)
+ public TaskRepository(IScopeAccessor scopeAccessor, ILogger logger)
+ : base(scopeAccessor, CacheHelper.NoCache, logger)
{ }
protected override Task PerformGet(int id)
diff --git a/src/Umbraco.Core/Persistence/Repositories/Implement/TaskTypeRepository.cs b/src/Umbraco.Core/Persistence/Repositories/Implement/TaskTypeRepository.cs
index 55f6905dde..ada49b4ec7 100644
--- a/src/Umbraco.Core/Persistence/Repositories/Implement/TaskTypeRepository.cs
+++ b/src/Umbraco.Core/Persistence/Repositories/Implement/TaskTypeRepository.cs
@@ -14,8 +14,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement
{
internal class TaskTypeRepository : NPocoRepositoryBase, ITaskTypeRepository
{
- public TaskTypeRepository(IScopeAccessor scopeAccessor, DisabledCacheHelper cache, ILogger logger)
- : base(scopeAccessor, cache, logger)
+ public TaskTypeRepository(IScopeAccessor scopeAccessor, ILogger logger)
+ : base(scopeAccessor, CacheHelper.NoCache, logger)
{ }
protected override TaskType PerformGet(int id)
diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj
index 31d4548198..7c362eef2c 100644
--- a/src/Umbraco.Core/Umbraco.Core.csproj
+++ b/src/Umbraco.Core/Umbraco.Core.csproj
@@ -106,7 +106,6 @@
-
diff --git a/src/Umbraco.Tests/FrontEnd/UmbracoHelperTests.cs b/src/Umbraco.Tests/FrontEnd/UmbracoHelperTests.cs
index 3d6d380fe9..8487e24768 100644
--- a/src/Umbraco.Tests/FrontEnd/UmbracoHelperTests.cs
+++ b/src/Umbraco.Tests/FrontEnd/UmbracoHelperTests.cs
@@ -8,6 +8,7 @@ using Umbraco.Core;
using Umbraco.Tests.TestHelpers;
using Umbraco.Core.Cache;
using Umbraco.Core.Composing;
+using Umbraco.Core.Composing.LightInject;
using Umbraco.Core.Logging;
using Umbraco.Web;
@@ -631,7 +632,7 @@ namespace Umbraco.Tests.FrontEnd
private void SetUpDependencyContainer()
{
// fixme - bad in a unit test - but Udi has a static ctor that wants it?!
- var container = new Mock();
+ var container = new Mock();
var globalSettings = SettingsForTests.GenerateMockGlobalSettings();
container
diff --git a/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs b/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs
index 23a9eafe76..edb9f2b97f 100644
--- a/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs
+++ b/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs
@@ -22,7 +22,7 @@ namespace Umbraco.Tests.Models.Mapping
base.Compose();
var manifestBuilder = new ManifestParser(
- CacheHelper.CreateDisabledCacheHelper().RuntimeCache,
+ CacheHelper.Disabled.RuntimeCache,
new ManifestValueValidatorCollection(Enumerable.Empty()),
Logger)
{
diff --git a/src/Umbraco.Tests/Persistence/Repositories/AuditRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/AuditRepositoryTest.cs
index 3bb4a42ba4..a8cdbfcdac 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/AuditRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/AuditRepositoryTest.cs
@@ -1,5 +1,6 @@
using System.Linq;
using NUnit.Framework;
+using Umbraco.Core.Cache;
using Umbraco.Core.Models;
using Umbraco.Core.Persistence.DatabaseModelDefinitions;
using Umbraco.Core.Persistence.Dtos;
@@ -22,7 +23,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var sp = TestObjects.GetScopeProvider(Logger);
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
repo.Save(new AuditItem(-1, "This is a System audit trail", AuditType.System, 0));
var dtos = scope.Database.Fetch("WHERE id > -1");
@@ -38,7 +39,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var sp = TestObjects.GetScopeProvider(Logger);
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
for (var i = 0; i < 100; i++)
{
@@ -51,7 +52,7 @@ namespace Umbraco.Tests.Persistence.Repositories
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
var page = repo.GetPagedResultsByQuery(sp.SqlContext.Query(), 0, 10, out var total, Direction.Descending, null, null);
@@ -66,7 +67,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var sp = TestObjects.GetScopeProvider(Logger);
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
for (var i = 0; i < 100; i++)
{
@@ -79,7 +80,7 @@ namespace Umbraco.Tests.Persistence.Repositories
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
var page = repo.GetPagedResultsByQuery(sp.SqlContext.Query(), 0, 9, out var total, Direction.Descending,
new[] {AuditType.Publish}, null)
@@ -97,7 +98,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var sp = TestObjects.GetScopeProvider(Logger);
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
for (var i = 0; i < 100; i++)
{
@@ -110,7 +111,7 @@ namespace Umbraco.Tests.Persistence.Repositories
using (var scope = sp.CreateScope())
{
- var repo = new AuditRepository((IScopeAccessor) sp, CacheHelper, Logger);
+ var repo = new AuditRepository((IScopeAccessor) sp, Logger);
var page = repo.GetPagedResultsByQuery(sp.SqlContext.Query(), 0, 8, out var total, Direction.Descending,
null, sp.SqlContext.Query().Where(item => item.Comment == "Content created"))
diff --git a/src/Umbraco.Tests/Persistence/Repositories/ContentTypeRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/ContentTypeRepositoryTest.cs
index 31105aa28e..9be7fe434a 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/ContentTypeRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/ContentTypeRepositoryTest.cs
@@ -35,7 +35,7 @@ namespace Umbraco.Tests.Persistence.Repositories
private DocumentRepository CreateRepository(IScopeAccessor scopeAccessor, out ContentTypeRepository contentTypeRepository)
{
- var cacheHelper = CacheHelper.CreateDisabledCacheHelper();
+ var cacheHelper = CacheHelper.Disabled;
var templateRepository = new TemplateRepository(scopeAccessor, cacheHelper, Logger, Mock.Of(), Mock.Of(), Mock.Of());
var tagRepository = new TagRepository(scopeAccessor, cacheHelper, Logger);
contentTypeRepository = new ContentTypeRepository(scopeAccessor, cacheHelper, Logger, templateRepository);
@@ -46,20 +46,20 @@ namespace Umbraco.Tests.Persistence.Repositories
private ContentTypeRepository CreateRepository(IScopeAccessor scopeAccessor)
{
- var templateRepository = new TemplateRepository(scopeAccessor, CacheHelper.CreateDisabledCacheHelper(), Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var contentTypeRepository = new ContentTypeRepository(scopeAccessor, CacheHelper.CreateDisabledCacheHelper(), Logger, templateRepository);
+ var templateRepository = new TemplateRepository(scopeAccessor, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var contentTypeRepository = new ContentTypeRepository(scopeAccessor, CacheHelper.Disabled, Logger, templateRepository);
return contentTypeRepository;
}
private MediaTypeRepository CreateMediaTypeRepository(IScopeAccessor scopeAccessor)
{
- var contentTypeRepository = new MediaTypeRepository(scopeAccessor, CacheHelper.CreateDisabledCacheHelper(), Logger);
+ var contentTypeRepository = new MediaTypeRepository(scopeAccessor, CacheHelper.Disabled, Logger);
return contentTypeRepository;
}
private EntityContainerRepository CreateContainerRepository(IScopeAccessor scopeAccessor, Guid containerEntityType)
{
- return new EntityContainerRepository(scopeAccessor, CacheHelper.CreateDisabledCacheHelper(), Logger, containerEntityType);
+ return new EntityContainerRepository(scopeAccessor, CacheHelper.Disabled, Logger, containerEntityType);
}
//TODO Add test to verify SetDefaultTemplates updates both AllowedTemplates and DefaultTemplate(id).
@@ -72,7 +72,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var templateRepo = new TemplateRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var templateRepo = new TemplateRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
var repository = CreateRepository((IScopeAccessor) provider);
var templates = new[]
{
diff --git a/src/Umbraco.Tests/Persistence/Repositories/DataTypeDefinitionRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/DataTypeDefinitionRepositoryTest.cs
index 41daa05022..4a40bfacd0 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/DataTypeDefinitionRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/DataTypeDefinitionRepositoryTest.cs
@@ -25,7 +25,7 @@ namespace Umbraco.Tests.Persistence.Repositories
private EntityContainerRepository CreateContainerRepository(IScopeAccessor scopeAccessor)
{
- return new EntityContainerRepository(scopeAccessor, CacheHelper.CreateDisabledCacheHelper(), Logger, Constants.ObjectTypes.DataTypeContainer);
+ return new EntityContainerRepository(scopeAccessor, CacheHelper.Disabled, Logger, Constants.ObjectTypes.DataTypeContainer);
}
[Test]
diff --git a/src/Umbraco.Tests/Persistence/Repositories/DomainRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/DomainRepositoryTest.cs
index e88b6e3f44..070ef781cf 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/DomainRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/DomainRepositoryTest.cs
@@ -22,12 +22,12 @@ namespace Umbraco.Tests.Persistence.Repositories
private DomainRepository CreateRepository(IScopeProvider provider, out ContentTypeRepository contentTypeRepository, out DocumentRepository documentRepository, out LanguageRepository languageRepository)
{
var accessor = (IScopeAccessor) provider;
- var templateRepository = new TemplateRepository(accessor, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepository = new TagRepository(accessor, DisabledCache, Logger);
- contentTypeRepository = new ContentTypeRepository(accessor, DisabledCache, Logger, templateRepository);
- languageRepository = new LanguageRepository(accessor, DisabledCache, Logger);
- documentRepository = new DocumentRepository(accessor, DisabledCache, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
- var domainRepository = new DomainRepository(accessor, DisabledCache, Logger);
+ var templateRepository = new TemplateRepository(accessor, Core.Cache.CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepository = new TagRepository(accessor, Core.Cache.CacheHelper.Disabled, Logger);
+ contentTypeRepository = new ContentTypeRepository(accessor, Core.Cache.CacheHelper.Disabled, Logger, templateRepository);
+ languageRepository = new LanguageRepository(accessor, Core.Cache.CacheHelper.Disabled, Logger);
+ documentRepository = new DocumentRepository(accessor, Core.Cache.CacheHelper.Disabled, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
+ var domainRepository = new DomainRepository(accessor, Core.Cache.CacheHelper.Disabled, Logger);
return domainRepository;
}
diff --git a/src/Umbraco.Tests/Persistence/Repositories/LanguageRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/LanguageRepositoryTest.cs
index cd1fe47f39..6edf85718d 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/LanguageRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/LanguageRepositoryTest.cs
@@ -26,7 +26,7 @@ namespace Umbraco.Tests.Persistence.Repositories
private LanguageRepository CreateRepository(IScopeProvider provider)
{
- return new LanguageRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ return new LanguageRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
}
[Test]
diff --git a/src/Umbraco.Tests/Persistence/Repositories/MacroRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/MacroRepositoryTest.cs
index a3b9035c8d..b089f5418c 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/MacroRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/MacroRepositoryTest.cs
@@ -35,7 +35,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = new Macro("test1", "Test", "~/views/macropartials/test.cshtml", MacroTypes.PartialView);
;
@@ -52,7 +52,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = repository.Get(1);
macro.Alias = "test2";
@@ -69,7 +69,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Assert
Assert.That(repository, Is.Not.Null);
@@ -83,7 +83,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var macro = repository.Get(1);
@@ -111,7 +111,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var macros = repository.GetMany();
@@ -129,7 +129,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var query = scope.SqlContext.Query().Where(x => x.Alias.ToUpper() == "TEST1");
@@ -147,7 +147,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var query = scope.SqlContext.Query().Where(x => x.Name.StartsWith("Test"));
@@ -165,7 +165,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var macro = new Macro("test", "Test", "~/views/macropartials/test.cshtml", MacroTypes.PartialView);
@@ -186,7 +186,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var macro = repository.Get(2);
@@ -221,7 +221,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var macro = repository.Get(3);
@@ -242,7 +242,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
// Act
var exists = repository.Exists(3);
@@ -261,7 +261,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = repository.Get(1);
macro.Properties.Add(new MacroProperty("new1", "New1", 3, "test"));
@@ -288,7 +288,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = new Macro("newmacro", "A new macro", "~/views/macropartials/test1.cshtml", MacroTypes.PartialView);
macro.Properties.Add(new MacroProperty("blah1", "New1", 4, "test.editor"));
@@ -313,7 +313,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = new Macro("newmacro", "A new macro", "~/views/macropartials/test1.cshtml", MacroTypes.PartialView);
macro.Properties.Add(new MacroProperty("blah1", "New1", 4, "test.editor"));
@@ -337,7 +337,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = new Macro("newmacro", "A new macro", "~/views/macropartials/test1.cshtml", MacroTypes.PartialView);
var prop1 = new MacroProperty("blah1", "New1", 4, "test.editor");
@@ -368,7 +368,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = repository.Get(1);
macro.Properties.Add(new MacroProperty("new1", "New1", 3, "test"));
@@ -395,7 +395,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
var macro = repository.Get(1);
macro.Properties.Add(new MacroProperty("new1", "New1", 3, "test"));
@@ -423,7 +423,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
repository.Save(new Macro("test1", "Test1", "~/views/macropartials/test1.cshtml", MacroTypes.PartialView));
repository.Save(new Macro("test2", "Test2", "~/views/macropartials/test2.cshtml", MacroTypes.PartialView));
diff --git a/src/Umbraco.Tests/Persistence/Repositories/MediaTypeRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/MediaTypeRepositoryTest.cs
index 85f49306d2..ae4308db55 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/MediaTypeRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/MediaTypeRepositoryTest.cs
@@ -2,6 +2,7 @@
using System.Linq;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Cache;
using Umbraco.Core.Models;
using Umbraco.Core.Persistence;
using Umbraco.Core.Persistence.Dtos;
@@ -20,12 +21,12 @@ namespace Umbraco.Tests.Persistence.Repositories
{
private MediaTypeRepository CreateRepository(IScopeProvider provider)
{
- return new MediaTypeRepository((IScopeAccessor) provider, DisabledCache, Logger);
+ return new MediaTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
}
private EntityContainerRepository CreateContainerRepository(IScopeProvider provider)
{
- return new EntityContainerRepository((IScopeAccessor) provider, DisabledCache, Logger, Constants.ObjectTypes.MediaTypeContainer);
+ return new EntityContainerRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Constants.ObjectTypes.MediaTypeContainer);
}
diff --git a/src/Umbraco.Tests/Persistence/Repositories/MemberRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/MemberRepositoryTest.cs
index 38ecc6c8ae..18bfc4fcea 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/MemberRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/MemberRepositoryTest.cs
@@ -6,6 +6,7 @@ using Moq;
using NPoco;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Cache;
using Umbraco.Core.Configuration.UmbracoSettings;
using Umbraco.Core.Logging;
using Umbraco.Core.Models;
@@ -28,10 +29,10 @@ namespace Umbraco.Tests.Persistence.Repositories
private MemberRepository CreateRepository(IScopeProvider provider, out MemberTypeRepository memberTypeRepository, out MemberGroupRepository memberGroupRepository)
{
var accessor = (IScopeAccessor) provider;
- memberTypeRepository = new MemberTypeRepository(accessor, DisabledCache, Logger);
- memberGroupRepository = new MemberGroupRepository(accessor, DisabledCache, Logger);
- var tagRepo = new TagRepository(accessor, DisabledCache, Logger);
- var repository = new MemberRepository(accessor, DisabledCache, Logger, memberTypeRepository, memberGroupRepository, tagRepo, Mock.Of());
+ memberTypeRepository = new MemberTypeRepository(accessor, CacheHelper.Disabled, Logger);
+ memberGroupRepository = new MemberGroupRepository(accessor, CacheHelper.Disabled, Logger);
+ var tagRepo = new TagRepository(accessor, CacheHelper.Disabled, Logger);
+ var repository = new MemberRepository(accessor, CacheHelper.Disabled, Logger, memberTypeRepository, memberGroupRepository, tagRepo, Mock.Of());
return repository;
}
diff --git a/src/Umbraco.Tests/Persistence/Repositories/MemberTypeRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/MemberTypeRepositoryTest.cs
index e3d15613c2..87d146f9f4 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/MemberTypeRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/MemberTypeRepositoryTest.cs
@@ -22,7 +22,7 @@ namespace Umbraco.Tests.Persistence.Repositories
{
private MemberTypeRepository CreateRepository(IScopeProvider provider)
{
- return new MemberTypeRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ return new MemberTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
}
[Test]
diff --git a/src/Umbraco.Tests/Persistence/Repositories/RelationRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/RelationRepositoryTest.cs
index 9ffcfa4442..697951d021 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/RelationRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/RelationRepositoryTest.cs
@@ -30,8 +30,8 @@ namespace Umbraco.Tests.Persistence.Repositories
private RelationRepository CreateRepository(IScopeProvider provider, out RelationTypeRepository relationTypeRepository)
{
var accessor = (IScopeAccessor) provider;
- relationTypeRepository = new RelationTypeRepository(accessor, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
- var repository = new RelationRepository(accessor, CacheHelper.CreateDisabledCacheHelper(), Mock.Of(), relationTypeRepository);
+ relationTypeRepository = new RelationTypeRepository(accessor, CacheHelper.Disabled, Mock.Of());
+ var repository = new RelationRepository(accessor, Mock.Of(), relationTypeRepository);
return repository;
}
@@ -266,12 +266,11 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var relationTypeRepository = new RelationTypeRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
- var relationRepository = new RelationRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of(), relationTypeRepository);
+ var relationTypeRepository = new RelationTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
+ var relationRepository = new RelationRepository((IScopeAccessor) provider, Mock.Of(), relationTypeRepository);
relationTypeRepository.Save(relateContent);
- relationTypeRepository.Save(relateContentType);
-
+ relationTypeRepository.Save(relateContentType);
//Create and Save ContentType "umbTextpage" -> (NodeDto.NodeIdSeed)
ContentType contentType = MockedContentTypes.CreateSimpleContentType("umbTextpage", "Textpage");
diff --git a/src/Umbraco.Tests/Persistence/Repositories/RelationTypeRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/RelationTypeRepositoryTest.cs
index 1925f3cb03..76a5a3726e 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/RelationTypeRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/RelationTypeRepositoryTest.cs
@@ -28,7 +28,7 @@ namespace Umbraco.Tests.Persistence.Repositories
private RelationTypeRepository CreateRepository(IScopeProvider provider)
{
- return new RelationTypeRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ return new RelationTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
}
@@ -232,7 +232,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repository = new RelationTypeRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new RelationTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
repository.Save(relateContent);//Id 2
repository.Save(relateContentType);//Id 3
diff --git a/src/Umbraco.Tests/Persistence/Repositories/TagRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/TagRepositoryTest.cs
index d53d680e94..65156df08d 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/TagRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/TagRepositoryTest.cs
@@ -1,6 +1,7 @@
using System.Linq;
using Moq;
using NUnit.Framework;
+using Umbraco.Core.Cache;
using Umbraco.Core.Configuration.UmbracoSettings;
using Umbraco.Core.IO;
using Umbraco.Core.Models;
@@ -946,26 +947,26 @@ namespace Umbraco.Tests.Persistence.Repositories
private TagRepository CreateRepository(IScopeProvider provider)
{
- return new TagRepository((IScopeAccessor) provider, DisabledCache, Logger);
+ return new TagRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
}
private DocumentRepository CreateContentRepository(IScopeProvider provider, out ContentTypeRepository contentTypeRepository)
{
var accessor = (IScopeAccessor) provider;
- var templateRepository = new TemplateRepository(accessor, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepository = new TagRepository(accessor, DisabledCache, Logger);
- contentTypeRepository = new ContentTypeRepository(accessor, DisabledCache, Logger, templateRepository);
- var languageRepository = new LanguageRepository(accessor, DisabledCache, Logger);
- var repository = new DocumentRepository(accessor, DisabledCache, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
+ var templateRepository = new TemplateRepository(accessor, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepository = new TagRepository(accessor, CacheHelper.Disabled, Logger);
+ contentTypeRepository = new ContentTypeRepository(accessor, CacheHelper.Disabled, Logger, templateRepository);
+ var languageRepository = new LanguageRepository(accessor, CacheHelper.Disabled, Logger);
+ var repository = new DocumentRepository(accessor, CacheHelper.Disabled, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
return repository;
}
private MediaRepository CreateMediaRepository(IScopeProvider provider, out MediaTypeRepository mediaTypeRepository)
{
var accessor = (IScopeAccessor) provider;
- var tagRepository = new TagRepository(accessor, DisabledCache, Logger);
- mediaTypeRepository = new MediaTypeRepository(accessor, DisabledCache, Logger);
- var repository = new MediaRepository(accessor, DisabledCache, Logger, mediaTypeRepository, tagRepository, Mock.Of(), Mock.Of());
+ var tagRepository = new TagRepository(accessor, CacheHelper.Disabled, Logger);
+ mediaTypeRepository = new MediaTypeRepository(accessor, CacheHelper.Disabled, Logger);
+ var repository = new MediaRepository(accessor, CacheHelper.Disabled, Logger, mediaTypeRepository, tagRepository, Mock.Of(), Mock.Of());
return repository;
}
}
diff --git a/src/Umbraco.Tests/Persistence/Repositories/TaskRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/TaskRepositoryTest.cs
index 1434fa6cea..a4b01aef9e 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/TaskRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/TaskRepositoryTest.cs
@@ -2,6 +2,7 @@
using System.Linq;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Cache;
using Umbraco.Core.Models;
using Umbraco.Core.Persistence.Repositories;
using Umbraco.Core.Persistence.Repositories.Implement;
@@ -21,7 +22,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var created = DateTime.Now;
var task = new Task(new TaskType("asdfasdf"))
@@ -49,7 +50,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var created = DateTime.Now;
repo.Save(new Task(new TaskType("asdfasdf"))
@@ -82,7 +83,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var task = new Task(new TaskType("asdfasdf"))
{
@@ -119,7 +120,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var task = new Task(new TaskType("asdfasdf"))
{
@@ -148,7 +149,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var found = repo.GetMany().ToArray();
Assert.AreEqual(20, found.Count());
@@ -164,7 +165,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var found = repo.GetTasks(includeClosed: true).ToArray();
Assert.AreEqual(15, found.Count());
@@ -180,7 +181,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var found = repo.GetTasks(itemId:-20).ToArray();
Assert.AreEqual(10, found.Count());
@@ -196,7 +197,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
var found = repo.GetTasks(includeClosed: false);
Assert.AreEqual(10, found.Count());
@@ -208,7 +209,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = ScopeProvider.CreateScope())
{
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
for (int i = 0; i < count; i++)
{
diff --git a/src/Umbraco.Tests/Persistence/Repositories/TaskTypeRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/TaskTypeRepositoryTest.cs
index f37fa37dca..7f159215b7 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/TaskTypeRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/TaskTypeRepositoryTest.cs
@@ -2,6 +2,7 @@
using System.Linq;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Cache;
using Umbraco.Core.Models;
using Umbraco.Core.Persistence.Repositories;
using Umbraco.Core.Persistence.Repositories.Implement;
@@ -22,8 +23,8 @@ namespace Umbraco.Tests.Persistence.Repositories
using (var scope = ScopeProvider.CreateScope())
{
var taskType = new TaskType("asdfasdf");
- var repo = new TaskRepository((IScopeAccessor) provider, CacheHelper, Logger);
- var taskTypeRepo = new TaskTypeRepository((IScopeAccessor) provider, CacheHelper, Logger);
+ var repo = new TaskRepository((IScopeAccessor) provider, Logger);
+ var taskTypeRepo = new TaskTypeRepository((IScopeAccessor) provider, Logger);
var created = DateTime.Now;
var task = new Task(taskType)
diff --git a/src/Umbraco.Tests/Persistence/Repositories/TemplateRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/TemplateRepositoryTest.cs
index 39128eb60a..69bbc46b57 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/TemplateRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/TemplateRepositoryTest.cs
@@ -6,6 +6,7 @@ using System.Text;
using Moq;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Cache;
using Umbraco.Core.Configuration.UmbracoSettings;
using Umbraco.Core.IO;
using Umbraco.Core.Models;
@@ -27,7 +28,7 @@ namespace Umbraco.Tests.Persistence.Repositories
private ITemplateRepository CreateRepository(IScopeProvider provider, ITemplatesSection templatesSection = null)
{
- return new TemplateRepository((IScopeAccessor) provider, DisabledCache, Logger,
+ return new TemplateRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger,
templatesSection ?? Mock.Of(t => t.DefaultRenderingEngine == RenderingEngine.Mvc),
_masterPageFileSystem, _viewsFileSystem);
}
@@ -404,10 +405,10 @@ namespace Umbraco.Tests.Persistence.Repositories
{
var templateRepository = CreateRepository(provider);
- var tagRepository = new TagRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var contentTypeRepository = new ContentTypeRepository((IScopeAccessor) provider, DisabledCache, Logger, templateRepository);
- var languageRepository = new LanguageRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var contentRepo = new DocumentRepository((IScopeAccessor) provider, DisabledCache, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
+ var tagRepository = new TagRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var contentTypeRepository = new ContentTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, templateRepository);
+ var languageRepository = new LanguageRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var contentRepo = new DocumentRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
var contentType = MockedContentTypes.CreateSimpleContentType("umbTextpage2", "Textpage");
ServiceContext.FileService.SaveTemplate(contentType.DefaultTemplate); // else, FK violation on contentType!
diff --git a/src/Umbraco.Tests/Persistence/Repositories/UserGroupRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/UserGroupRepositoryTest.cs
index aeec6065df..f0fb8cff88 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/UserGroupRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/UserGroupRepositoryTest.cs
@@ -19,7 +19,7 @@ namespace Umbraco.Tests.Persistence.Repositories
{
private UserGroupRepository CreateRepository(IScopeProvider provider)
{
- return new UserGroupRepository((IScopeAccessor) provider, Core.Cache.CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ return new UserGroupRepository((IScopeAccessor) provider, Core.Cache.CacheHelper.Disabled, Mock.Of());
}
[Test]
@@ -131,7 +131,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var id = userGroup.Id;
- var repository2 = new UserGroupRepository((IScopeAccessor) provider, Core.Cache.CacheHelper.CreateDisabledCacheHelper(), Logger);
+ var repository2 = new UserGroupRepository((IScopeAccessor) provider, Core.Cache.CacheHelper.Disabled, Logger);
repository2.Delete(userGroup);
scope.Complete();
diff --git a/src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs b/src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
index 1ee8d8fe00..5a46bc805f 100644
--- a/src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
+++ b/src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
@@ -50,14 +50,14 @@ namespace Umbraco.Tests.Persistence.Repositories
private UserRepository CreateRepository(IScopeProvider provider)
{
var accessor = (IScopeAccessor) provider;
- var repository = new UserRepository(accessor, CacheHelper.CreateDisabledCacheHelper(), Mock.Of(), Mock.Of(), TestObjects.GetGlobalSettings());
+ var repository = new UserRepository(accessor, CacheHelper.Disabled, Mock.Of(), Mock.Of(), TestObjects.GetGlobalSettings());
return repository;
}
private UserGroupRepository CreateUserGroupRepository(IScopeProvider provider)
{
var accessor = (IScopeAccessor) provider;
- return new UserGroupRepository(accessor, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ return new UserGroupRepository(accessor, CacheHelper.Disabled, Mock.Of());
}
[Test]
@@ -205,7 +205,7 @@ namespace Umbraco.Tests.Persistence.Repositories
var id = user.Id;
- var repository2 = new UserRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Logger, Mock.Of(),TestObjects.GetGlobalSettings());
+ var repository2 = new UserRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Mock.Of(),TestObjects.GetGlobalSettings());
repository2.Delete(user);
diff --git a/src/Umbraco.Tests/Services/ContentServicePerformanceTest.cs b/src/Umbraco.Tests/Services/ContentServicePerformanceTest.cs
index 28021f1e22..b1d6934043 100644
--- a/src/Umbraco.Tests/Services/ContentServicePerformanceTest.cs
+++ b/src/Umbraco.Tests/Services/ContentServicePerformanceTest.cs
@@ -5,6 +5,7 @@ using System.Linq;
using Moq;
using NUnit.Framework;
using Umbraco.Core;
+using Umbraco.Core.Cache;
using Umbraco.Core.Configuration.UmbracoSettings;
using Umbraco.Core.IO;
using Umbraco.Core.Logging;
@@ -161,11 +162,11 @@ namespace Umbraco.Tests.Services
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var tRepository = new TemplateRepository((IScopeAccessor) provider, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepo = new TagRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, DisabledCache, Logger, tRepository);
- var languageRepository = new LanguageRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var repository = new DocumentRepository((IScopeAccessor) provider, DisabledCache, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
+ var tRepository = new TemplateRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepo = new TagRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, tRepository);
+ var languageRepository = new LanguageRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var repository = new DocumentRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
// Act
Stopwatch watch = Stopwatch.StartNew();
@@ -194,11 +195,11 @@ namespace Umbraco.Tests.Services
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var tRepository = new TemplateRepository((IScopeAccessor) provider, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepo = new TagRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, DisabledCache, Logger, tRepository);
- var languageRepository = new LanguageRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var repository = new DocumentRepository((IScopeAccessor) provider, DisabledCache, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
+ var tRepository = new TemplateRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepo = new TagRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, tRepository);
+ var languageRepository = new LanguageRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var repository = new DocumentRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
// Act
Stopwatch watch = Stopwatch.StartNew();
@@ -225,11 +226,11 @@ namespace Umbraco.Tests.Services
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var tRepository = new TemplateRepository((IScopeAccessor) provider, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepo = new TagRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, DisabledCache, Logger, tRepository);
- var languageRepository = new LanguageRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var repository = new DocumentRepository((IScopeAccessor) provider, DisabledCache, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
+ var tRepository = new TemplateRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepo = new TagRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, tRepository);
+ var languageRepository = new LanguageRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var repository = new DocumentRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
// Act
var contents = repository.GetMany();
@@ -259,11 +260,11 @@ namespace Umbraco.Tests.Services
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var tRepository = new TemplateRepository((IScopeAccessor) provider, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepo = new TagRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, DisabledCache, Logger, tRepository);
- var languageRepository = new LanguageRepository((IScopeAccessor) provider, DisabledCache, Logger);
- var repository = new DocumentRepository((IScopeAccessor) provider, DisabledCache, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
+ var tRepository = new TemplateRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepo = new TagRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var ctRepository = new ContentTypeRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, tRepository);
+ var languageRepository = new LanguageRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger);
+ var repository = new DocumentRepository((IScopeAccessor) provider, CacheHelper.Disabled, Logger, ctRepository, tRepository, tagRepo, languageRepository, Mock.Of());
// Act
var contents = repository.GetMany();
diff --git a/src/Umbraco.Tests/Services/ContentServiceTests.cs b/src/Umbraco.Tests/Services/ContentServiceTests.cs
index 7a68b36c21..c3661c1a18 100644
--- a/src/Umbraco.Tests/Services/ContentServiceTests.cs
+++ b/src/Umbraco.Tests/Services/ContentServiceTests.cs
@@ -25,6 +25,7 @@ using Umbraco.Core.Services.Implement;
using Umbraco.Tests.Testing;
using Umbraco.Web.PropertyEditors;
using System.Reflection;
+using Umbraco.Core.Cache;
namespace Umbraco.Tests.Services
{
@@ -2951,11 +2952,11 @@ namespace Umbraco.Tests.Services
private DocumentRepository CreateRepository(IScopeProvider provider, out ContentTypeRepository contentTypeRepository)
{
var accessor = (IScopeAccessor) provider;
- var templateRepository = new TemplateRepository(accessor, DisabledCache, Logger, Mock.Of(), Mock.Of(), Mock.Of());
- var tagRepository = new TagRepository(accessor, DisabledCache, Logger);
- contentTypeRepository = new ContentTypeRepository(accessor, DisabledCache, Logger, templateRepository);
- var languageRepository = new LanguageRepository(accessor, DisabledCache, Logger);
- var repository = new DocumentRepository(accessor, DisabledCache, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
+ var templateRepository = new TemplateRepository(accessor, CacheHelper.Disabled, Logger, Mock.Of(), Mock.Of(), Mock.Of());
+ var tagRepository = new TagRepository(accessor, CacheHelper.Disabled, Logger);
+ contentTypeRepository = new ContentTypeRepository(accessor, CacheHelper.Disabled, Logger, templateRepository);
+ var languageRepository = new LanguageRepository(accessor, CacheHelper.Disabled, Logger);
+ var repository = new DocumentRepository(accessor, CacheHelper.Disabled, Logger, contentTypeRepository, templateRepository, tagRepository, languageRepository, Mock.Of());
return repository;
}
}
diff --git a/src/Umbraco.Tests/Services/MacroServiceTests.cs b/src/Umbraco.Tests/Services/MacroServiceTests.cs
index fa86f4baab..730b80a9df 100644
--- a/src/Umbraco.Tests/Services/MacroServiceTests.cs
+++ b/src/Umbraco.Tests/Services/MacroServiceTests.cs
@@ -26,7 +26,7 @@ namespace Umbraco.Tests.Services
var provider = TestObjects.GetScopeProvider(Logger);
using (var scope = provider.CreateScope())
{
- var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.CreateDisabledCacheHelper(), Mock.Of());
+ var repository = new MacroRepository((IScopeAccessor) provider, CacheHelper.Disabled, Mock.Of());
repository.Save(new Macro("test1", "Test1", "~/views/macropartials/test1.cshtml", MacroTypes.PartialView));
repository.Save(new Macro("test2", "Test2", "~/views/macropartials/test2.cshtml", MacroTypes.PartialView));
diff --git a/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs b/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs
index 25a0dc72fa..38cd8f727d 100644
--- a/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs
+++ b/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs
@@ -49,13 +49,9 @@ namespace Umbraco.Tests.TestHelpers
[UmbracoTest(WithApplication = true)]
public abstract class TestWithDatabaseBase : UmbracoTestBase
{
- private CacheHelper _disabledCacheHelper;
-
private string _databasePath;
private static byte[] _databaseBytes;
- protected CacheHelper DisabledCache => _disabledCacheHelper ?? (_disabledCacheHelper = CacheHelper.CreateDisabledCacheHelper());
-
protected PublishedContentTypeCache ContentTypesCache { get; private set; }
protected override ISqlSyntaxProvider SqlSyntax => GetSyntaxProvider();
diff --git a/src/Umbraco.Tests/Testing/TestingTests/MockTests.cs b/src/Umbraco.Tests/Testing/TestingTests/MockTests.cs
index 7769a3318e..e64eda1ab4 100644
--- a/src/Umbraco.Tests/Testing/TestingTests/MockTests.cs
+++ b/src/Umbraco.Tests/Testing/TestingTests/MockTests.cs
@@ -55,7 +55,7 @@ namespace Umbraco.Tests.Testing.TestingTests
Container.Register(_ => Mock.Of());
Container.Register(_ => Mock.Of());
Container.Register(_ => Mock.Of());
- Container.Register(_ => CacheHelper.CreateDisabledCacheHelper());
+ Container.Register(_ => CacheHelper.Disabled);
Container.Register();
// ReSharper disable once UnusedVariable
@@ -68,7 +68,7 @@ namespace Umbraco.Tests.Testing.TestingTests
Mock.Of(),
new MembershipHelper(new TestUmbracoContextAccessor(umbracoContext), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), null),
new ServiceContext(),
- CacheHelper.CreateDisabledCacheHelper());
+ CacheHelper.Disabled);
Assert.Pass();
}
diff --git a/src/Umbraco.Tests/Testing/UmbracoTestBase.cs b/src/Umbraco.Tests/Testing/UmbracoTestBase.cs
index 9778542a01..4005ea0607 100644
--- a/src/Umbraco.Tests/Testing/UmbracoTestBase.cs
+++ b/src/Umbraco.Tests/Testing/UmbracoTestBase.cs
@@ -196,7 +196,7 @@ namespace Umbraco.Tests.Testing
protected virtual void ComposeCacheHelper()
{
- Container.RegisterSingleton(f => CacheHelper.CreateDisabledCacheHelper());
+ Container.RegisterSingleton(f => CacheHelper.Disabled);
Container.RegisterSingleton(f => f.GetInstance().RuntimeCache);
}
diff --git a/src/Umbraco.Tests/Web/Mvc/SurfaceControllerTests.cs b/src/Umbraco.Tests/Web/Mvc/SurfaceControllerTests.cs
index dfa917459f..22bf9ef602 100644
--- a/src/Umbraco.Tests/Web/Mvc/SurfaceControllerTests.cs
+++ b/src/Umbraco.Tests/Web/Mvc/SurfaceControllerTests.cs
@@ -132,7 +132,7 @@ namespace Umbraco.Tests.Web.Mvc
Mock.Of(),
new MembershipHelper(new TestUmbracoContextAccessor(umbracoContext), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), Mock.Of(), null),
new ServiceContext(),
- CacheHelper.CreateDisabledCacheHelper());
+ CacheHelper.Disabled);
var ctrl = new TestSurfaceController(umbracoContext, helper);
var result = ctrl.GetContent(2) as PublishedContentResult;