remove editable workspace kind

This commit is contained in:
Niels Lyngsø
2024-06-28 10:28:09 +02:00
parent 9d76cce610
commit 93ffebd221
5 changed files with 4 additions and 79 deletions

View File

@@ -1,38 +0,0 @@
import type { UmbSubmittableWorkspaceContext } from '../../contexts/tokens/submittable-workspace-context.interface.js';
import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
import { html, customElement, state, css } from '@umbraco-cms/backoffice/external/lit';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import type { UmbRoute } from '@umbraco-cms/backoffice/router';
import { UmbExtensionsApiInitializer } from '@umbraco-cms/backoffice/extension-api';
@customElement('umb-editable-workspace')
export class UmbEditableWorkspaceElement extends UmbLitElement {
@state()
_routes: UmbRoute[] = [];
public set api(api: UmbSubmittableWorkspaceContext) {
this.observe(api.routes.routes, (routes) => (this._routes = routes));
new UmbExtensionsApiInitializer(this, umbExtensionsRegistry, 'workspaceContext', [api]);
}
override render() {
return html` <umb-router-slot .routes="${this._routes}"></umb-router-slot>`;
}
static override styles = [
css`
form {
display: contents;
}
`,
];
}
export default UmbEditableWorkspaceElement;
declare global {
interface HTMLElementTagNameMap {
'umb-editable-workspace': UmbEditableWorkspaceElement;
}
}

View File

@@ -1,13 +0,0 @@
import type { UmbBackofficeManifestKind } from '@umbraco-cms/backoffice/extension-registry';
export const manifest: UmbBackofficeManifestKind = {
type: 'kind',
alias: 'Umb.Kind.Workspace.Editable',
matchKind: 'editable',
matchType: 'workspace',
manifest: {
type: 'workspace',
kind: 'editable',
element: () => import('./editable-workspace.element.js'),
},
};

View File

@@ -1,22 +0,0 @@
import { expect, fixture, html } from '@open-wc/testing';
import { UmbEditableWorkspaceElement } from './editable-workspace.element.js';
import { type UmbTestRunnerWindow, defaultA11yConfig } from '@umbraco-cms/internal/test-utils';
describe('UmbEditableWorkspaceElement', () => {
let element: UmbEditableWorkspaceElement;
beforeEach(async () => {
element = await fixture(html`<umb-editable-workspace></umb-editable-workspace>`);
});
it('is defined with its own instance', () => {
expect(element).to.be.instanceOf(UmbEditableWorkspaceElement);
});
if ((window as UmbTestRunnerWindow).__UMBRACO_TEST_RUN_A11Y_TEST) {
it('passes the a11y audit', async () => {
// TODO: should we use shadowDom here?
await expect(element).to.be.accessible(defaultA11yConfig);
});
}
});

View File

@@ -1,6 +1,3 @@
import { UmbDataTypeDetailRepository } from '../repository/detail/data-type-detail.repository.js';
import type { UmbDataTypeDetailModel, UmbDataTypePropertyModel } from '../types.js';
import { UmbDataTypeWorkspaceEditorElement } from './data-type-workspace-editor.element.js';
import type { UmbPropertyDatasetContext } from '@umbraco-cms/backoffice/property';
import type {
UmbInvariantDatasetWorkspaceContext,
@@ -10,7 +7,6 @@ import {
UmbSubmittableWorkspaceContextBase,
UmbInvariantWorkspacePropertyDatasetContext,
UmbWorkspaceIsNewRedirectController,
UmbWorkspaceRouteManager,
} from '@umbraco-cms/backoffice/workspace';
import {
appendToFrozenArray,
@@ -29,7 +25,9 @@ import {
UmbRequestReloadChildrenOfEntityEvent,
UmbRequestReloadStructureForEntityEvent,
} from '@umbraco-cms/backoffice/entity-action';
import { UMB_PROPERTY_EDITOR_SCHEMA_ALIAS_DEFAULT } from '@umbraco-cms/backoffice/property-editor';
import type { UmbDataTypeDetailModel, UmbDataTypePropertyModel } from '../types.js';
import { UmbDataTypeDetailRepository } from '../repository/detail/data-type-detail.repository.js';
import { UmbDataTypeWorkspaceEditorElement } from './data-type-workspace-editor.element.js';
type EntityType = UmbDataTypeDetailModel;
export class UmbDataTypeWorkspaceContext

View File

@@ -10,7 +10,7 @@ const DATA_TYPE_WORKSPACE_ALIAS = 'Umb.Workspace.DataType';
const workspace: ManifestWorkspaces = {
type: 'workspace',
kind: 'editable',
kind: 'routable',
alias: DATA_TYPE_WORKSPACE_ALIAS,
name: 'Data Type Workspace',
api: () => import('./data-type-workspace.context.js'),