yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V15: Add textbox and text area serverside validation (#18596)

Browse Source 
* Add validation to TextOnlyValueEditor

* Fix tests

* Add tests
This commit is contained in:
Mole
2025-03-06 13:19:28 +01:00
committed by GitHub
parent 7b6cef6083
commit 95c892000d
8 changed files with 130 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/VariationTests.cs
View File

@@ -632,6 +632,7 @@ public class VariationTests
var dataValueEditorFactory = Mock.Of<IDataValueEditorFactory>(x
=> x.Create<TextOnlyValueEditor>(It.IsAny<DataEditorAttribute>()) == new TextOnlyValueEditor(
attribute,
Mock.Of<ILocalizedTextService>(),
Mock.Of<IShortStringHelper>(),
new SystemTextJsonSerializer(),
Mock.Of<IIOHelper>()));

1
tests/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/DataValueEditorReuseTests.cs
View File

@@ -29,6 +29,7 @@ public class DataValueEditorReuseTests
.Setup(m => m.Create<TextOnlyValueEditor>(It.IsAny<DataEditorAttribute>()))
.Returns(() => new TextOnlyValueEditor(
new DataEditorAttribute("a"),
Mock.Of<ILocalizedTextService>(),
Mock.Of<IShortStringHelper>(),
Mock.Of<IJsonSerializer>(),
Mock.Of<IIOHelper>()));

66
tests/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/Validators/TextOnlyValueEditorValidatorTests.cs Normal file
View File

@@ -0,0 +1,66 @@
using System.ComponentModel.DataAnnotations;
using Moq;
using NUnit.Framework;
using Umbraco.Cms.Core.IO;
using Umbraco.Cms.Core.Models.Validation;
using Umbraco.Cms.Core.PropertyEditors;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Strings;
using Umbraco.Cms.Infrastructure.Serialization;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.PropertyEditors.Validators;
[TestFixture]
internal class TextOnlyValueEditorValidatorTests
{
internal enum ConfigurationType
{
TextAreaConfiguration,
TextboxConfiguration,
}
[TestCase(true, ConfigurationType.TextboxConfiguration, null, "123")]
[TestCase(true, ConfigurationType.TextAreaConfiguration, null, "123")]
[TestCase(false, ConfigurationType.TextAreaConfiguration, 2, "123")]
[TestCase(false, ConfigurationType.TextboxConfiguration, 2, "123")]
[TestCase(true, ConfigurationType.TextboxConfiguration, 10, "123")]
[TestCase(true, ConfigurationType.TextAreaConfiguration, 10, "123")]
public void Validates_String_Length(bool shouldSucceed, ConfigurationType configurationType, int? maxChars, string value)
{
var editor = CreateValueEditor();
editor.ConfigurationObject = CreateConfiguration(configurationType, maxChars);
var results = editor.Validate(value, false, null, PropertyValidationContext.Empty());
ValidateResult(shouldSucceed, results);
}
private static object CreateConfiguration(ConfigurationType type, int? maxChars) =>
type switch
{
ConfigurationType.TextboxConfiguration => new TextboxConfiguration { MaxChars = maxChars },
ConfigurationType.TextAreaConfiguration => new TextAreaConfiguration { MaxChars = maxChars },
_ => throw new InvalidOperationException(),
};
private static void ValidateResult(bool succeed, IEnumerable<ValidationResult> result)
{
if (succeed)
{
Assert.IsEmpty(result);
}
else
{
Assert.IsNotEmpty(result);
}
}
private TextOnlyValueEditor CreateValueEditor() =>
new(
new DataEditorAttribute("alias"),
Mock.Of<ILocalizedTextService>(),
Mock.Of<IShortStringHelper>(),
new SystemTextJsonSerializer(),
Mock.Of<IIOHelper>());
}