diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/validation/valserver.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/validation/valserver.directive.js index 04f1496a30..701a344838 100644 --- a/src/Umbraco.Web.UI.Client/src/common/directives/validation/valserver.directive.js +++ b/src/Umbraco.Web.UI.Client/src/common/directives/validation/valserver.directive.js @@ -58,8 +58,6 @@ function valServer(serverValidationManager) { function getPropertyValidationKey() { // Get the property validation path if there is one, this is how wiring up any nested/virtual property validation works var propertyValidationPath = umbPropCtrl ? umbPropCtrl.getValidationPath() : null; - // TODO: Is this going to break with nested content because it changes the alias? - // Hrm, don't think so because NC will use the property validation path return propertyValidationPath ? propertyValidationPath : currentProperty.alias; } diff --git a/src/Umbraco.Web/Editors/Filters/ContentSaveModelValidator.cs b/src/Umbraco.Web/Editors/Filters/ContentSaveModelValidator.cs index f9d7203d12..09995c1104 100644 --- a/src/Umbraco.Web/Editors/Filters/ContentSaveModelValidator.cs +++ b/src/Umbraco.Web/Editors/Filters/ContentSaveModelValidator.cs @@ -17,29 +17,5 @@ namespace Umbraco.Web.Editors.Filters { } - protected override void AddPropertyError(ContentItemSave model, ContentVariantSave modelWithProperties, IDataEditor editor, ContentPropertyDto property, ValidationResult validationResult, ModelStateDictionary modelState) - { - // Original idea: See if we can build up the JSON + JSON Path - // SD: I'm just keeping these notes here for later just to remind myself that we might want to take into account the tab number in validation - // which we might be able to get in the PropertyValidationService anyways? - - // Create a JSON + JSON Path key, see https://gist.github.com/Shazwazza/ad9fcbdb0fdacff1179a9eed88393aa6 - - //var json = new PropertyError - //{ - // Culture = property.Culture, - // Segment = property.Segment - //}; - - // TODO: Hrm, we can't get the tab index without a reference to the content type itself! the IContent doesn't contain a reference to groups/indexes - // BUT! I think it contains a reference to the group alias so we could use JSON Path for a group alias instead of index like: - // .tabs[?(@.alias=='Content')] - //var tabIndex = ?? - - //var jsonPath = "$.variants[0].tabs[0].properties[?(@.alias=='title')].value[0]"; - - base.AddPropertyError(model, modelWithProperties, editor, property, validationResult, modelState); - } - } }