yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added unit test for TryGetBasicAuthCredentials extension method and minor code tidy.

Browse Source
This commit is contained in:
Andy Butland
2021-08-06 12:05:08 +02:00
parent 7859798e8b
commit 9732381933
4 changed files with 50 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Umbraco.Web.Common/Extensions/HttpContextExtensions.cs
View File

@@ -5,13 +5,12 @@ using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Http.Features;
using Microsoft.Extensions.Primitives;
namespace Umbraco.Extensions
{
public static class HttpContextExtensions
{
/// <summary>
/// Try to get the basic auth username and password from the http context.
/// </summary>
@@ -20,14 +19,14 @@ namespace Umbraco.Extensions
username = null;
password = null;
if ( httpContext.Request.Headers.TryGetValue("Authorization", out var authHeaders))
if (httpContext.Request.Headers.TryGetValue("Authorization", out StringValues authHeaders))
{
var authHeader = authHeaders.ToString();
if (authHeader is not null && authHeader.StartsWith("Basic"))
{
//Extract credentials
// Extract credentials.
var encodedUsernamePassword = authHeader.Substring(6).Trim();
var encoding = Encoding.UTF8;
Encoding encoding = Encoding.UTF8;
var usernamePassword = encoding.GetString(Convert.FromBase64String(encodedUsernamePassword));
var seperatorIndex = usernamePassword.IndexOf(':');