From 8fa3f8e06a554bdb157e205be4cbac97e20ec6ec Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Mon, 20 May 2019 17:25:29 +0200 Subject: [PATCH 1/3] Moved more stuff --- src/{Umbraco.Core => Umbraco.Abstractions}/IEmailSender.cs | 0 src/{Umbraco.Core => Umbraco.Abstractions}/IMainDom.cs | 0 .../LambdaExpressionCacheKey.cs | 2 +- src/{Umbraco.Core => Umbraco.Abstractions}/MonitorLock.cs | 0 src/Umbraco.Core/Umbraco.Core.csproj | 4 ---- 5 files changed, 1 insertion(+), 5 deletions(-) rename src/{Umbraco.Core => Umbraco.Abstractions}/IEmailSender.cs (100%) rename src/{Umbraco.Core => Umbraco.Abstractions}/IMainDom.cs (100%) rename src/{Umbraco.Core => Umbraco.Abstractions}/LambdaExpressionCacheKey.cs (98%) rename src/{Umbraco.Core => Umbraco.Abstractions}/MonitorLock.cs (100%) diff --git a/src/Umbraco.Core/IEmailSender.cs b/src/Umbraco.Abstractions/IEmailSender.cs similarity index 100% rename from src/Umbraco.Core/IEmailSender.cs rename to src/Umbraco.Abstractions/IEmailSender.cs diff --git a/src/Umbraco.Core/IMainDom.cs b/src/Umbraco.Abstractions/IMainDom.cs similarity index 100% rename from src/Umbraco.Core/IMainDom.cs rename to src/Umbraco.Abstractions/IMainDom.cs diff --git a/src/Umbraco.Core/LambdaExpressionCacheKey.cs b/src/Umbraco.Abstractions/LambdaExpressionCacheKey.cs similarity index 98% rename from src/Umbraco.Core/LambdaExpressionCacheKey.cs rename to src/Umbraco.Abstractions/LambdaExpressionCacheKey.cs index 52ec786a6d..c191732acc 100644 --- a/src/Umbraco.Core/LambdaExpressionCacheKey.cs +++ b/src/Umbraco.Abstractions/LambdaExpressionCacheKey.cs @@ -9,7 +9,7 @@ namespace Umbraco.Core /// Represents a simple in a form which is suitable for using as a dictionary key /// by exposing the return type, argument types and expression string form in a single concatenated string. /// - internal struct LambdaExpressionCacheKey + public struct LambdaExpressionCacheKey { public LambdaExpressionCacheKey(string returnType, string expression, params string[] argTypes) { diff --git a/src/Umbraco.Core/MonitorLock.cs b/src/Umbraco.Abstractions/MonitorLock.cs similarity index 100% rename from src/Umbraco.Core/MonitorLock.cs rename to src/Umbraco.Abstractions/MonitorLock.cs diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj index f400595e81..00d64f4649 100755 --- a/src/Umbraco.Core/Umbraco.Core.csproj +++ b/src/Umbraco.Core/Umbraco.Core.csproj @@ -326,7 +326,6 @@ - @@ -620,7 +619,6 @@ - @@ -638,7 +636,6 @@ - @@ -868,7 +865,6 @@ - From d576be35934258ace012eb8264cc3d2f58ae27f6 Mon Sep 17 00:00:00 2001 From: Lars-Erik Aabech Date: Mon, 20 May 2019 17:25:49 +0200 Subject: [PATCH 2/3] Made DataTableExtensions and made it/methods public. --- src/Umbraco.Abstractions/DataTableExtensions.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Abstractions/DataTableExtensions.cs b/src/Umbraco.Abstractions/DataTableExtensions.cs index 1c547b9d44..63b2671d09 100644 --- a/src/Umbraco.Abstractions/DataTableExtensions.cs +++ b/src/Umbraco.Abstractions/DataTableExtensions.cs @@ -8,7 +8,7 @@ namespace Umbraco.Core /// /// Static and extension methods for the DataTable object /// - internal static class DataTableExtensions + public static class DataTableExtensions { /// /// Creates a DataTable with the specified alias and columns and uses a callback to populate the headers. @@ -57,7 +57,7 @@ namespace Umbraco.Core /// /// This is for legacy code, I didn't want to go creating custom classes for these /// - internal static List>, IEnumerable>>> CreateTableData() + public static List>, IEnumerable>>> CreateTableData() { return new List>, IEnumerable>>>(); } @@ -71,7 +71,7 @@ namespace Umbraco.Core /// /// This is for legacy code, I didn't want to go creating custom classes for these /// - internal static void AddRowData( + public static void AddRowData( List>, IEnumerable>>> rowData, IEnumerable> standardVals, IEnumerable> userVals) From 837a7b506eff4b7e701954bbe07da1d56663a518 Mon Sep 17 00:00:00 2001 From: Lars-Erik Aabech Date: Mon, 20 May 2019 17:25:55 +0200 Subject: [PATCH 3/3] Moved first core DI abstractions --- .../Composing/IFactory.cs | 0 .../Composing/IRegister.cs | 0 .../Composing/Lifetime.cs | 0 src/Umbraco.Core/Umbraco.Core.csproj | 5 +---- 4 files changed, 1 insertion(+), 4 deletions(-) rename src/{Umbraco.Core => Umbraco.Abstractions}/Composing/IFactory.cs (100%) rename src/{Umbraco.Core => Umbraco.Abstractions}/Composing/IRegister.cs (100%) rename src/{Umbraco.Core => Umbraco.Abstractions}/Composing/Lifetime.cs (100%) diff --git a/src/Umbraco.Core/Composing/IFactory.cs b/src/Umbraco.Abstractions/Composing/IFactory.cs similarity index 100% rename from src/Umbraco.Core/Composing/IFactory.cs rename to src/Umbraco.Abstractions/Composing/IFactory.cs diff --git a/src/Umbraco.Core/Composing/IRegister.cs b/src/Umbraco.Abstractions/Composing/IRegister.cs similarity index 100% rename from src/Umbraco.Core/Composing/IRegister.cs rename to src/Umbraco.Abstractions/Composing/IRegister.cs diff --git a/src/Umbraco.Core/Composing/Lifetime.cs b/src/Umbraco.Abstractions/Composing/Lifetime.cs similarity index 100% rename from src/Umbraco.Core/Composing/Lifetime.cs rename to src/Umbraco.Abstractions/Composing/Lifetime.cs diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj index 50a378fa0e..67d7bf9b97 100755 --- a/src/Umbraco.Core/Umbraco.Core.csproj +++ b/src/Umbraco.Core/Umbraco.Core.csproj @@ -196,10 +196,7 @@ - - - @@ -1508,7 +1505,7 @@ - +