From c37ba0dc8a06c856594c890fb3d9519211f2f22a Mon Sep 17 00:00:00 2001 From: Dennis Spijkerboer Date: Thu, 29 Oct 2015 12:56:07 +0100 Subject: [PATCH 01/68] Checked if the trimmed value starts and ends with brackets. If so, use the trimmed value. --- src/Umbraco.Web/umbraco.presentation/helper.cs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web/umbraco.presentation/helper.cs b/src/Umbraco.Web/umbraco.presentation/helper.cs index f9292702e0..0d133fee66 100644 --- a/src/Umbraco.Web/umbraco.presentation/helper.cs +++ b/src/Umbraco.Web/umbraco.presentation/helper.cs @@ -112,14 +112,17 @@ namespace umbraco foreach (var attributeValueItem in attributeValueSplit) { attributeValue = attributeValueItem; + var trimmedValue = attributeValue.Trim(); // Check for special variables (always in square-brackets like [name]) - if (attributeValueItem.StartsWith("[") && - attributeValueItem.EndsWith("]")) + if (trimmedValue.StartsWith("[") && + trimmedValue.EndsWith("]")) { + attributeValue = trimmedValue; + // find key name - var keyName = attributeValueItem.Substring(2, attributeValueItem.Length - 3); - var keyType = attributeValueItem.Substring(1, 1); + var keyName = attributeValue.Substring(2, attributeValue.Length - 3); + var keyType = attributeValue.Substring(1, 1); switch (keyType) { From 63af822bad54ab6258768dfec79393153c3b72f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Asbj=C3=B8rn=20Riis-Knudsen?= Date: Thu, 29 Oct 2015 14:52:18 +0100 Subject: [PATCH 02/68] U4-6657: Use flexbox for mediapicker search field and upload button to allow button to scale for different translations --- src/Umbraco.Web.UI.Client/src/less/panel.less | 17 +++++++++++++++++ .../src/views/common/dialogs/mediapicker.html | 18 ++++++++---------- 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/less/panel.less b/src/Umbraco.Web.UI.Client/src/less/panel.less index f86ba46f59..82c272564a 100644 --- a/src/Umbraco.Web.UI.Client/src/less/panel.less +++ b/src/Umbraco.Web.UI.Client/src/less/panel.less @@ -42,6 +42,23 @@ bottom: 90px; } +.umb-mediapicker-upload { + display: -ms-flexbox; + display: -webkit-box; + display: -webkit-flex; + display: flex; + + .form-search { + -ms-flex: 1; + -webkit-flex: 1; + flex: 1; + } + + .upload-button { + margin-left: 16px; + } +} + .umb-panel.editor-breadcrumb .umb-panel-body, .umb-panel.editor-breadcrumb .umb-bottom-bar { bottom: 31px !important; } diff --git a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html index 597dcdaa4b..1594de0e12 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html @@ -62,18 +62,16 @@
-
-
- +
+ -
+
From bd69820028a880cce8c060d088fe4d557a82a056 Mon Sep 17 00:00:00 2001 From: Benas Brazdziunas Date: Thu, 29 Oct 2015 16:29:33 +0000 Subject: [PATCH 03/68] Member Picker search results doesn't show correct icons --- src/Umbraco.Core/Services/EntityXmlSerializer.cs | 2 ++ src/UmbracoExamine/UmbracoMemberIndexer.cs | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/Umbraco.Core/Services/EntityXmlSerializer.cs b/src/Umbraco.Core/Services/EntityXmlSerializer.cs index 772009e89a..712f98aeb2 100644 --- a/src/Umbraco.Core/Services/EntityXmlSerializer.cs +++ b/src/Umbraco.Core/Services/EntityXmlSerializer.cs @@ -100,6 +100,8 @@ namespace Umbraco.Core.Services xml.Add(new XAttribute("loginName", member.Username)); xml.Add(new XAttribute("email", member.Email)); + + xml.Add(new XAttribute("icon", member.ContentType.Icon)); return xml; } diff --git a/src/UmbracoExamine/UmbracoMemberIndexer.cs b/src/UmbracoExamine/UmbracoMemberIndexer.cs index c93172b9a1..873391da50 100644 --- a/src/UmbracoExamine/UmbracoMemberIndexer.cs +++ b/src/UmbracoExamine/UmbracoMemberIndexer.cs @@ -207,6 +207,9 @@ namespace UmbracoExamine if (e.Fields.ContainsKey("_searchEmail") == false) e.Fields.Add("_searchEmail", e.Node.Attribute("email").Value.Replace(".", " ").Replace("@", " ")); } + + if (e.Fields.ContainsKey(IconFieldName) == false) + e.Fields.Add(IconFieldName, (string)e.Node.Attribute("icon")); } private static XElement GetMemberItem(int nodeId) From 5749f80a7fbfb574735f20b3b43df9be8794f2c8 Mon Sep 17 00:00:00 2001 From: andydale1982 Date: Thu, 29 Oct 2015 17:10:39 +0000 Subject: [PATCH 04/68] Added instructions to manually install node_modules. --- src/Umbraco.Web.UI/Umbraco/js/install.loader.js | 11 +++++++++-- .../umbraco/Install/Views/Index.cshtml | 15 ++++++++++++++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Web.UI/Umbraco/js/install.loader.js b/src/Umbraco.Web.UI/Umbraco/js/install.loader.js index 869521ec7d..f61c9d2878 100644 --- a/src/Umbraco.Web.UI/Umbraco/js/install.loader.js +++ b/src/Umbraco.Web.UI/Umbraco/js/install.loader.js @@ -1,4 +1,5 @@ -LazyLoad.js( [ +try { + LazyLoad.js([ 'lib/jquery/jquery.min.js', /* 1.1.5 */ 'lib/angular/1.1.5/angular.min.js', @@ -13,5 +14,11 @@ LazyLoad.js( [ jQuery(document).ready(function () { angular.bootstrap(document, ['ngSanitize', 'umbraco.install', 'umbraco.directives.validation']); }); + }); +} +catch (err) { + if (err.message == 'LazyLoad is not defined') { + document.getElementById("feedback").style.display = "none"; + document.getElementById("missinglazyload").style.display = "block"; } -); \ No newline at end of file +} \ No newline at end of file diff --git a/src/Umbraco.Web.UI/umbraco/Install/Views/Index.cshtml b/src/Umbraco.Web.UI/umbraco/Install/Views/Index.cshtml index 8171aad9e2..f0cb808264 100644 --- a/src/Umbraco.Web.UI/umbraco/Install/Views/Index.cshtml +++ b/src/Umbraco.Web.UI/umbraco/Install/Views/Index.cshtml @@ -45,7 +45,20 @@

-

{{installer.feedback}}

+

{{installer.feedback}}

+ + +