From 99736717cc8e96a301abc9435a3bec0b3c53613d Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Thu, 8 Feb 2024 15:20:57 +0100 Subject: [PATCH] remove unused methods on tree interfaces --- .../core/tree/tree-repository.interface.ts | 26 ++++--------------- .../core/tree/tree-store.interface.ts | 2 -- 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-repository.interface.ts b/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-repository.interface.ts index 3eca4d2847..1b2f0615eb 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-repository.interface.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-repository.interface.ts @@ -13,34 +13,18 @@ export interface UmbTreeRepository< error?: ProblemDetails; }>; - requestTreeItemsOf: (parentUnique: string | null) => Promise<{ - data?: UmbPagedModel; - error?: ProblemDetails; - asObservable?: () => Observable; - }>; - - treeItemsOf: (parentUnique: string | null) => Promise>; - - /* TODO: remove this. It is not used client side. - Logic to call the root endpoint should be in the data source - because it is a server decision to split them - */ requestRootTreeItems: () => Promise<{ data?: UmbPagedModel; error?: ProblemDetails; asObservable?: () => Observable; }>; - // TODO: remove - rootTreeItems: () => Promise>; - - // TODO: remove this when all repositories are migrated to the new interface items interface - requestItemsLegacy?: (uniques: string[]) => Promise<{ - data?: Array; + requestTreeItemsOf: (parentUnique: string | null) => Promise<{ + data?: UmbPagedModel; error?: ProblemDetails; - asObservable?: () => Observable; + asObservable?: () => Observable; }>; - // TODO: remove this when all repositories are migrated to the new items interface - itemsLegacy?: (uniques: string[]) => Promise>; + rootTreeItems: () => Promise>; + treeItemsOf: (parentUnique: string | null) => Promise>; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-store.interface.ts b/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-store.interface.ts index e52551355c..b573021677 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-store.interface.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-store.interface.ts @@ -6,6 +6,4 @@ import type { UmbApi } from '@umbraco-cms/backoffice/extension-api'; export interface UmbTreeStore extends UmbStore, UmbApi { rootItems: Observable>; childrenOf: (parentUnique: string | null) => Observable>; - // TODO: remove this one when all repositories are using an item store - items: (uniques: Array) => Observable>; }