yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cleanup TODOs

Browse Source
This commit is contained in:
Shannon
2020-07-30 15:47:14 +10:00
parent f7a0afb459
commit 99fc6ef587
4 changed files with 42 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
.editorconfig
View File

@@ -1,40 +1,43 @@
# editorconfig.org # editorconfig.org
# top-most EditorConfig file # top-most EditorConfig file
root = true root = true
# Default settings: # Default settings:
# A newline ending every file # A newline ending every file
# Use 4 spaces as indentation # Use 4 spaces as indentation
[*] [*]
insert_final_newline = true insert_final_newline = true
end_of_line = crlf end_of_line = crlf
indent_style = space indent_style = space
indent_size = 4 indent_size = 4
# Trim trailing whitespace, limited support. # Trim trailing whitespace, limited support.
# https://github.com/editorconfig/editorconfig/wiki/Property-research:-Trim-trailing-spaces # https://github.com/editorconfig/editorconfig/wiki/Property-research:-Trim-trailing-spaces
trim_trailing_whitespace = true trim_trailing_whitespace = true
[*.{cs,vb}] [*.{cs,vb}]
dotnet_style_predefined_type_for_locals_parameters_members = true:error dotnet_style_predefined_type_for_locals_parameters_members = true:error
dotnet_naming_rule.private_members_with_underscore.symbols = private_fields dotnet_naming_rule.private_members_with_underscore.symbols = private_fields
dotnet_naming_rule.private_members_with_underscore.style = prefix_underscore dotnet_naming_rule.private_members_with_underscore.style = prefix_underscore
dotnet_naming_rule.private_members_with_underscore.severity = suggestion dotnet_naming_rule.private_members_with_underscore.severity = suggestion
dotnet_naming_symbols.private_fields.applicable_kinds = field dotnet_naming_symbols.private_fields.applicable_kinds = field
dotnet_naming_symbols.private_fields.applicable_accessibilities = private dotnet_naming_symbols.private_fields.applicable_accessibilities = private
dotnet_naming_style.prefix_underscore.capitalization = camel_case dotnet_naming_style.prefix_underscore.capitalization = camel_case
dotnet_naming_style.prefix_underscore.required_prefix = _ dotnet_naming_style.prefix_underscore.required_prefix = _
# https://github.com/MicrosoftDocs/visualstudio-docs/blob/master/docs/ide/editorconfig-code-style-settings-reference.md # https://github.com/MicrosoftDocs/visualstudio-docs/blob/master/docs/ide/editorconfig-code-style-settings-reference.md
[*.cs] [*.cs]
csharp_style_var_for_built_in_types = true:suggestion csharp_style_var_for_built_in_types = true:suggestion
csharp_style_var_when_type_is_apparent = true:suggestion csharp_style_var_when_type_is_apparent = true:suggestion
csharp_style_var_elsewhere = true:suggestion csharp_style_var_elsewhere = true:suggestion
csharp_prefer_braces = false : none csharp_prefer_braces = false : none
[*.{js,less}] [*.js]
trim_trailing_whitespace = true
[*.less]
trim_trailing_whitespace = false trim_trailing_whitespace = false

1
src/Umbraco.Web.UI.Client/src/common/directives/validation/valpropertymsg.directive.js
View File

@@ -171,7 +171,6 @@ function valPropertyMsg(serverValidationManager, localizationService, angularHel
// we find all ngModel controls recursively on this form (but stop recursing before we get to the next) // we find all ngModel controls recursively on this form (but stop recursing before we get to the next)
// umbProperty form). Then for each ngModelController we assign a new $validator. This $validator // umbProperty form). Then for each ngModelController we assign a new $validator. This $validator
// will execute whenever the value is changed which allows us to check and reset the server validator // will execute whenever the value is changed which allows us to check and reset the server validator
// TODO: Is this even needed?
function startWatch() { function startWatch() {
if (!watcher) { if (!watcher) {

2
src/Umbraco.Web.UI.Client/src/common/directives/validation/valservermatch.directive.js
View File

@@ -49,7 +49,7 @@ function valServerMatch(serverValidationManager) {
// if we have reached this part, and there is no culture, then lets fallback to invariant. To get the validation feedback for invariant language. // if we have reached this part, and there is no culture, then lets fallback to invariant. To get the validation feedback for invariant language.
currentCulture = currentCulture || "invariant"; currentCulture = currentCulture || "invariant";
var unsubscribe = []; var unsubscribe = [];
function bindCallback(validationKey, matchVal, matchType) { function bindCallback(validationKey, matchVal, matchType) {

1
src/Umbraco.Web.UI.Client/src/common/services/contenteditinghelper.service.js
View File

@@ -634,7 +634,6 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, editorSt
formHelper.handleServerValidation(args.err.data.ModelState); formHelper.handleServerValidation(args.err.data.ModelState);
//add model state errors to notifications //add model state errors to notifications
// TODO: Need to ignore complex messages
if (args.showNotifications) { if (args.showNotifications) {
showNotificationsForModelsState(args.err.data.ModelState); showNotificationsForModelsState(args.err.data.ModelState);
} }