From 9b36bc40978d4bb98375f18fbef5b19dd40dd686 Mon Sep 17 00:00:00 2001 From: Shannon Date: Fri, 7 Jun 2019 13:13:52 +1000 Subject: [PATCH] Fixes notifications when publishing fails and warnings are issues - these were not being displayed --- src/Umbraco.Web/Editors/ContentController.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Web/Editors/ContentController.cs b/src/Umbraco.Web/Editors/ContentController.cs index de65689353..4c920626a6 100644 --- a/src/Umbraco.Web/Editors/ContentController.cs +++ b/src/Umbraco.Web/Editors/ContentController.cs @@ -741,7 +741,7 @@ namespace Umbraco.Web.Editors //global notifications AddMessageForPublishStatus(publishStatus, globalNotifications, successfulCultures); //variant specific notifications - foreach (var c in successfulCultures) + foreach (var c in successfulCultures ?? Array.Empty()) AddMessageForPublishStatus(publishStatus, notifications.GetOrCreate(c), successfulCultures); } break; @@ -762,7 +762,7 @@ namespace Umbraco.Web.Editors //global notifications AddMessageForPublishStatus(publishStatus, globalNotifications, successfulCultures); //variant specific notifications - foreach (var c in successfulCultures) + foreach (var c in successfulCultures ?? Array.Empty()) AddMessageForPublishStatus(publishStatus, notifications.GetOrCreate(c), successfulCultures); } break; @@ -1143,7 +1143,7 @@ namespace Umbraco.Web.Editors var publishStatus = Services.ContentService.SaveAndPublishBranch(contentItem.PersistedContent, force, userId: Security.CurrentUser.Id); // TODO: Deal with multiple cancellations wasCancelled = publishStatus.Any(x => x.Result == PublishResultType.FailedPublishCancelledByEvent); - successfulCultures = Array.Empty(); + successfulCultures = null; //must be null! this implies invariant return publishStatus; }