diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts index c0a803ed71..92e7a2a5c7 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts @@ -14,12 +14,13 @@ export class UmbPropertyEditorUIBlockGridAreaTypePermissionElement implements UmbPropertyEditorUiElement { @property({ type: Array }) - public get value(): Array { - return this._value; - } public set value(value: Array) { this._value = value ?? []; } + public get value(): Array { + return this._value; + } + @state() private _value: Array = []; @@ -151,7 +152,7 @@ export class UmbPropertyEditorUIBlockGridAreaTypePermissionElement By default, all block types are allowed in an Area, Use this option to allow only selected types. - ` + ` : nothing} `; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-areas-config/property-editor-ui-block-grid-areas-config.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-areas-config/property-editor-ui-block-grid-areas-config.element.ts index 551ee938fb..b464d72a0b 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-areas-config/property-editor-ui-block-grid-areas-config.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-areas-config/property-editor-ui-block-grid-areas-config.element.ts @@ -24,19 +24,17 @@ export class UmbPropertyEditorUIBlockGridAreasConfigElement #defaultAreaGridColumns: number = 12; #valueOfAreaGridColumns?: number | null; - #workspaceModal: UmbModalRouteRegistrationController; - @property({ type: Array }) - public get value(): Array { - return this._value; - } public set value(value: Array) { this._value = value ?? []; } + public get value(): Array { + return this._value; + } + @state() private _value: Array = []; - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { const defaultAreaGridColumns = config?.getValueByAlias('defaultAreaGridColumns'); if (typeof defaultAreaGridColumns === 'number' && defaultAreaGridColumns > 0) { @@ -59,7 +57,7 @@ export class UmbPropertyEditorUIBlockGridAreasConfigElement constructor() { super(); - this.#workspaceModal = new UmbModalRouteRegistrationController(this, UMB_BLOCK_GRID_AREA_TYPE_WORKSPACE_MODAL) + new UmbModalRouteRegistrationController(this, UMB_BLOCK_GRID_AREA_TYPE_WORKSPACE_MODAL) .addAdditionalPath('block-grid-area-type') .onSetup(() => { return { data: { entityType: 'block-grid-area-type', preset: {} }, modal: { size: 'large' } }; diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-column-span/property-editor-ui-block-grid-column-span.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-column-span/property-editor-ui-block-grid-column-span.element.ts index d4a4030b26..69bcdf527e 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-column-span/property-editor-ui-block-grid-column-span.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-column-span/property-editor-ui-block-grid-column-span.element.ts @@ -13,7 +13,6 @@ export class UmbPropertyEditorUIBlockGridColumnSpanElement extends UmbLitElement @state() private _columnsArray = Array.from(Array(12).keys()); - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { const maxColumns = config?.getValueByAlias('maxColumns'); if (typeof maxColumns === 'number') { diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts index ae7ab63921..7da4fc8061 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-editor/property-editor-ui-block-grid.element.ts @@ -26,7 +26,6 @@ export class UmbPropertyEditorUIBlockGridElement extends UmbLitElement implement settingsData: [], }; - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { if (!config) return; @@ -56,9 +55,6 @@ export class UmbPropertyEditorUIBlockGridElement extends UmbLitElement implement private _layoutColumns?: number; @property({ attribute: false }) - public get value(): UmbBlockGridValueModel { - return this._value; - } public set value(value: UmbBlockGridValueModel | undefined) { const buildUpValue: Partial = value ? { ...value } : {}; buildUpValue.layout ??= {}; @@ -70,6 +66,9 @@ export class UmbPropertyEditorUIBlockGridElement extends UmbLitElement implement this.#context.setContents(buildUpValue.contentData); this.#context.setSettings(buildUpValue.settingsData); } + public get value(): UmbBlockGridValueModel { + return this._value; + } constructor() { super(); diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-group-configuration/property-editor-ui-block-grid-group-configuration.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-group-configuration/property-editor-ui-block-grid-group-configuration.element.ts index c4d9db8862..a38f9966e8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-group-configuration/property-editor-ui-block-grid-group-configuration.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-group-configuration/property-editor-ui-block-grid-group-configuration.element.ts @@ -14,14 +14,13 @@ export class UmbPropertyEditorUIBlockGridGroupConfigurationElement private _value: Array = []; @property({ type: Array }) - public get value(): Array { - return this._value; - } public set value(value: Array) { this._value = value || []; } + public get value(): Array { + return this._value; + } - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) {} #addGroup() { diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-layout-stylesheet/property-editor-ui-block-grid-layout-stylesheet.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-layout-stylesheet/property-editor-ui-block-grid-layout-stylesheet.element.ts index b32bb507ea..b5e2ab09fe 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-layout-stylesheet/property-editor-ui-block-grid-layout-stylesheet.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-layout-stylesheet/property-editor-ui-block-grid-layout-stylesheet.element.ts @@ -17,18 +17,18 @@ export class UmbPropertyEditorUIBlockGridLayoutStylesheetElement private _value: Array = []; @property({ type: Array }) - public get value(): Array { - return this._value; - } public set value(value: Array) { this._value = value || []; } + public get value(): Array { + return this._value; + } @property({ attribute: false }) - public set config(config: UmbPropertyEditorConfigCollection | undefined) {} + public config?: UmbPropertyEditorConfigCollection; private _onChange(event: CustomEvent) { - this.value = (event.target as UmbInputStaticFileElement).selectedPaths; + this.value = (event.target as UmbInputStaticFileElement).selection; this.dispatchEvent(new CustomEvent('property-value-change')); } @@ -37,7 +37,7 @@ export class UmbPropertyEditorUIBlockGridLayoutStylesheetElement return html`
diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts index c6f17862c9..d1ec621370 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts @@ -51,9 +51,6 @@ export class UmbPropertyEditorUIBlockListElement extends UmbLitElement implement }; @property({ attribute: false }) - public get value(): UmbBlockListValueModel { - return this._value; - } public set value(value: UmbBlockListValueModel | undefined) { const buildUpValue: Partial = value ? { ...value } : {}; buildUpValue.layout ??= {}; @@ -65,11 +62,13 @@ export class UmbPropertyEditorUIBlockListElement extends UmbLitElement implement this.#managerContext.setContents(buildUpValue.contentData); this.#managerContext.setSettings(buildUpValue.settingsData); } + public get value(): UmbBlockListValueModel { + return this._value; + } @state() private _createButtonLabel = this.localize.term('content_createEmpty'); - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { if (!config) return; diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-type/components/input-block-type/input-block-type.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-type/components/input-block-type/input-block-type.element.ts index af2608a99a..5643b99105 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-type/components/input-block-type/input-block-type.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-type/components/input-block-type/input-block-type.element.ts @@ -13,12 +13,12 @@ export class UmbInputBlockTypeElement< BlockType extends UmbBlockTypeBaseModel = UmbBlockTypeBaseModel, > extends UmbLitElement { @property({ type: Array, attribute: false }) - public get value() { - return this._items; - } public set value(items) { this._items = items ?? []; } + public get value() { + return this._items; + } @property({ type: String }) workspacePath?: string; @@ -26,6 +26,7 @@ export class UmbInputBlockTypeElement< @state() private _items: Array = []; + // TODO: Seems no need to have these initially, then can be retrieved inside the `create` method. [NL] #datasetContext?: UmbPropertyDatasetContext; #filter: Array = []; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/field-dropdown-list/field-dropdown-list.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/field-dropdown-list/field-dropdown-list.element.ts index 370ccd8e0a..837006de80 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/field-dropdown-list/field-dropdown-list.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/field-dropdown-list/field-dropdown-list.element.ts @@ -39,15 +39,15 @@ export class UmbFieldDropdownListElement extends UmbLitElement { private _value: FieldPickerValue | undefined; @property({ type: Object }) - public get value(): FieldPickerValue | undefined { - return this._value; - } public set value(val: FieldPickerValue | undefined) { const oldVal = this._value; this._value = val; this.requestUpdate('value', oldVal); this.dispatchEvent(new UmbChangeEvent()); } + public get value(): FieldPickerValue | undefined { + return this._value; + } @state() private _type?: FieldType; @@ -168,7 +168,7 @@ export class UmbFieldDropdownListElement extends UmbLitElement { display-value=${this.localize.term('content_mediatype')}> ${this.localize.term('content_mediatype')} ${this.localize.term('defaultdialogs_treepicker')} - ` + ` : nothing} diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-multi-url/input-multi-url.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-multi-url/input-multi-url.element.ts index 38b14583f7..d2ceeabca2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-multi-url/input-multi-url.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-multi-url/input-multi-url.element.ts @@ -22,11 +22,17 @@ export class UmbInputMultiUrlElement extends FormControlMixin(UmbLitElement) { public set alias(value: string | undefined) { this.myModalRegistration.setUniquePathValue('propertyAlias', value); } + public get alias(): string | undefined { + return this.myModalRegistration.getUniquePathValue('propertyAlias'); + } @property() public set variantId(value: string | UmbVariantId | undefined) { this.myModalRegistration.setUniquePathValue('variantId', value?.toString()); } + public get variantId(): string | undefined { + return this.myModalRegistration.getUniquePathValue('variantId'); + } /** * This is a minimum amount of selected items in this input. @@ -91,8 +97,7 @@ export class UmbInputMultiUrlElement extends FormControlMixin(UmbLitElement) { this._urls = [...data]; // Unfreeze data coming from State, so we can manipulate it. super.value = this._urls.map((x) => x.url).join(','); } - - get urls() { + get urls(): Array { return this._urls; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-number-range/input-number-range.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-number-range/input-number-range.element.ts index 3a5c17e825..ca4f086e89 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-number-range/input-number-range.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-number-range/input-number-range.element.ts @@ -54,9 +54,8 @@ export class UmbInputNumberRangeElement extends FormControlMixin(UmbLitElement) this.maxValue = getNumberOrUndefined(splittedValue[1]); } } - - constructor() { - super(); + public get value(): string { + return this.minValue || this.maxValue ? (this.minValue || '') + ',' + (this.maxValue || '') : ''; } protected getFormElement() { diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-radio-button-list/input-radio-button-list.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-radio-button-list/input-radio-button-list.element.ts index 8c0bb4f7ed..7d1f356ac4 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-radio-button-list/input-radio-button-list.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-radio-button-list/input-radio-button-list.element.ts @@ -8,17 +8,17 @@ export class UmbInputRadioButtonListElement extends FormControlMixin(UmbLitEleme /** * List of items. */ - @property() + @property({ attribute: false }) public list: Array<{ key: string; sortOrder: number; value: string }> = []; #selected = ''; - public get selected(): string { - return this.#selected; - } public set selected(key: string) { this.#selected = key; super.value = key; } + public get selected(): string { + return this.#selected; + } @property() public set value(key: string) { @@ -26,6 +26,9 @@ export class UmbInputRadioButtonListElement extends FormControlMixin(UmbLitEleme this.selected = key; } } + public get value(): string { + return this.selected; + } protected getFormElement() { return undefined; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-toggle/input-toggle.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-toggle/input-toggle.element.ts index b2a8579b1f..6b7f5c856b 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-toggle/input-toggle.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-toggle/input-toggle.element.ts @@ -32,10 +32,6 @@ export class UmbInputToggleElement extends FormControlMixin(UmbLitElement) { return undefined; } - constructor() { - super(); - } - connectedCallback(): void { super.connectedCallback(); this.#updateLabel(); diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-text-string-input/input-multiple-text-string.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-text-string-input/input-multiple-text-string.element.ts index 93b381c130..e014cbeba7 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-text-string-input/input-multiple-text-string.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/multiple-text-string-input/input-multiple-text-string.element.ts @@ -126,12 +126,12 @@ export class UmbInputMultipleTextStringElement extends FormControlMixin(UmbLitEl // How do we handle this? /* @property() - public get value() { - throw new Error(`${this} does not support to get the value directly. Use items instead.`); - } public set value(value: FormDataEntryValue | FormData) { throw new Error(`${this} does not support to set the value directly. Use items instead.`); } + public get value() { + throw new Error(`${this} does not support to get the value directly. Use items instead.`); + } */ #onAdd() { diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/default/entity-action.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/default/entity-action.element.ts index b382785a33..e0c639c52c 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/default/entity-action.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/entity-action/default/entity-action.element.ts @@ -12,16 +12,17 @@ export class UmbEntityActionElement< > extends UmbLitElement { #api?: ApiType; + // TODO: Do these need to be properties? [NL] @property({ type: String }) entityType?: string | null; + // TODO: Do these need to be properties? [NL] @property({ type: String }) public unique?: string | null; @property({ attribute: false }) public manifest?: ManifestEntityAction; - @property({ attribute: false }) public set api(api: ApiType | undefined) { this.#api = api; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal-base.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal-base.element.ts index 20dd262981..c4a1defa21 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal-base.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal-base.element.ts @@ -38,21 +38,21 @@ export abstract class UmbModalBaseElement< #modalContext?: UmbModalContext | undefined; @property({ attribute: false }) - public get data(): ModalDataType | undefined { - return this._data; - } public set data(value: ModalDataType | undefined) { this._data = value; } + public get data(): ModalDataType | undefined { + return this._data; + } private _data?: ModalDataType | undefined; @property({ attribute: false }) - public get value(): ModalValueType { - return this.#value; - } public set value(value: ModalValueType) { this.#modalContext?.setValue(value); } + public get value(): ModalValueType { + return this.#value; + } public updateValue(partialValue: Partial) { this.#modalContext?.updateValue(partialValue); diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/modal/route-registration/modal-route-registration.controller.ts b/src/Umbraco.Web.UI.Client/src/packages/core/modal/route-registration/modal-route-registration.controller.ts index 8a0c7903b4..d5377f7e45 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/modal/route-registration/modal-route-registration.controller.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/modal/route-registration/modal-route-registration.controller.ts @@ -118,6 +118,9 @@ export class UmbModalRouteRegistrationController; - @property({ attribute: false }) public set api(api: ApiType | undefined) { this.#api = api; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/checkbox-list/property-editor-ui-checkbox-list.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/checkbox-list/property-editor-ui-checkbox-list.element.ts index 00776a8210..491688eb1b 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/checkbox-list/property-editor-ui-checkbox-list.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/checkbox-list/property-editor-ui-checkbox-list.element.ts @@ -12,14 +12,13 @@ import type { UmbPropertyEditorConfigCollection } from '@umbraco-cms/backoffice/ export class UmbPropertyEditorUICheckboxListElement extends UmbLitElement implements UmbPropertyEditorUiElement { #value: Array = []; @property({ type: Array }) - public get value(): Array { - return this.#value; - } public set value(value: Array) { this.#value = value ?? []; } + public get value(): Array { + return this.#value; + } - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { if (!config) return; const listData: Record | undefined = config.getValueByAlias('items'); @@ -52,7 +51,7 @@ export class UmbPropertyEditorUICheckboxListElement extends UmbLitElement implem render() { return html``; } } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/property-editor-ui-collection-view.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/property-editor-ui-collection-view.element.ts index 98877f738f..b423bf9ebb 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/property-editor-ui-collection-view.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/property-editor-ui-collection-view.element.ts @@ -1,17 +1,14 @@ -import type { - UmbCollectionBulkActionPermissions, - UmbCollectionConfiguration, -} from '../../../../core/collection/types.js'; import type { UmbPropertyEditorConfigCollection } from '../../config/index.js'; import { html, customElement, property, state } from '@umbraco-cms/backoffice/external/lit'; import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element'; import { UMB_DOCUMENT_COLLECTION_ALIAS } from '@umbraco-cms/backoffice/document'; -import { UMB_MEDIA_COLLECTION_ALIAS } from '@umbraco-cms/backoffice/media'; import { UMB_PROPERTY_CONTEXT } from '@umbraco-cms/backoffice/property'; -import { UMB_WORKSPACE_CONTEXT, UMB_WORKSPACE_COLLECTION_CONTEXT } from '@umbraco-cms/backoffice/workspace'; -import type { UmbDocumentWorkspaceContext } from '@umbraco-cms/backoffice/document'; -import type { UmbMediaWorkspaceContext } from '@umbraco-cms/backoffice/media'; +import { UMB_WORKSPACE_COLLECTION_CONTEXT } from '@umbraco-cms/backoffice/workspace'; import type { UmbPropertyEditorUiElement } from '@umbraco-cms/backoffice/extension-registry'; +import type { + UmbCollectionBulkActionPermissions, + UmbCollectionConfiguration, +} from '@umbraco-cms/backoffice/collection'; /** * @element umb-property-editor-ui-collection-view @@ -27,7 +24,6 @@ export class UmbPropertyEditorUICollectionViewElement extends UmbLitElement impl @state() private _config?: UmbCollectionConfiguration; - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { this._config = this.#mapDataTypeConfigToCollectionConfig(config); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-picker/property-editor-ui-color-picker.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-picker/property-editor-ui-color-picker.element.ts index d0d796877b..04cca387c0 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-picker/property-editor-ui-color-picker.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-picker/property-editor-ui-color-picker.element.ts @@ -21,7 +21,6 @@ export class UmbPropertyEditorUIColorPickerElement extends UmbLitElement impleme @state() private _swatches: UmbSwatchDetails[] = []; - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { this._showLabels = config?.getValueByAlias('useLabel') ?? this.#defaultShowLabels; this._swatches = config?.getValueByAlias('items') ?? []; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-swatches-editor/property-editor-ui-color-swatches-editor.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-swatches-editor/property-editor-ui-color-swatches-editor.element.ts index d2d4f13a77..ac9c9df30a 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-swatches-editor/property-editor-ui-color-swatches-editor.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/color-swatches-editor/property-editor-ui-color-swatches-editor.element.ts @@ -18,7 +18,6 @@ export class UmbPropertyEditorUIColorSwatchesEditorElement extends UmbLitElement @state() private _showLabels = this.#defaultShowLabels; - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { this._showLabels = config?.getValueByAlias('useLabel') ?? this.#defaultShowLabels; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/date-picker/property-editor-ui-date-picker.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/date-picker/property-editor-ui-date-picker.element.ts index 560353a64e..ebbbe7daa9 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/date-picker/property-editor-ui-date-picker.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/date-picker/property-editor-ui-date-picker.element.ts @@ -26,7 +26,6 @@ export class UmbPropertyEditorUIDatePickerElement extends UmbLitElement implemen this._valueString = undefined; } } - get value() { return this._valueString; } @@ -53,7 +52,6 @@ export class UmbPropertyEditorUIDatePickerElement extends UmbLitElement implemen private _offsetTime?: boolean; - @property({ attribute: false }) public set config(config: UmbPropertyEditorConfigCollection | undefined) { if (!config) return; const oldVal = this._inputType; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/dropdown/property-editor-ui-dropdown.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/dropdown/property-editor-ui-dropdown.element.ts index e310cb10d5..c200e6b562 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/dropdown/property-editor-ui-dropdown.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/dropdown/property-editor-ui-dropdown.element.ts @@ -11,12 +11,12 @@ import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element'; export class UmbPropertyEditorUIDropdownElement extends UmbLitElement implements UmbPropertyEditorUiElement { #value = ''; @property({ type: String }) - public get value(): string { - return this.#value; - } public set value(value: string | undefined) { this.#value = value?.trim() || ''; } + public get value(): string { + return this.#value; + } @state() _multiple?: boolean; @@ -24,7 +24,6 @@ export class UmbPropertyEditorUIDropdownElement extends UmbLitElement implements @state() private _list: Array