From 9e5ff305c8a969856f27cf3f63f0e85ad3033e14 Mon Sep 17 00:00:00 2001
From: Sven Geusens <geusens@gmail.com>
Date: Tue, 7 Nov 2023 10:49:46 +0100
Subject: [PATCH] Batched bulk WhereIn query to avoid To mana paramaters error
 (#15004)

Co-authored-by: Sven Geusens <sge@umbraco.dk>
---
 .../Implement/ContentTypeRepositoryBase.cs            | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs b/src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs
index 3e92a4ae7f..59aa92bb82 100644
--- a/src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs
+++ b/src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ContentTypeRepositoryBase.cs
@@ -1385,10 +1385,15 @@ AND umbracoNode.id <> @id",
         }
 
         // Now bulk update the umbracoDocument table
-        foreach (IGrouping<bool, KeyValuePair<int, bool>> editValue in editedDocument.GroupBy(x => x.Value))
+        // we need to do this in batches as the WhereIn Npoco method translates to all the nodeIds being passed in as parameters when using the SqlClient provider
+        // this results in to many parameters (>2100) being passed to the client when there are a lot of documents being normalized
+        foreach (IGrouping<bool, KeyValuePair<int, bool>> groupByValue in editedDocument.GroupBy(x => x.Value))
         {
-            Database.Execute(Sql().Update<DocumentDto>(u => u.Set(x => x.Edited, editValue.Key))
-                .WhereIn<DocumentDto>(x => x.NodeId, editValue.Select(x => x.Key)));
+            foreach (IEnumerable<KeyValuePair<int, bool>> batch in groupByValue.InGroupsOf(2000))
+            {
+                Database.Execute(Sql().Update<DocumentDto>(u => u.Set(x => x.Edited, groupByValue.Key))
+                    .WhereIn<DocumentDto>(x => x.NodeId, batch.Select(x => x.Key)));
+            }
         }
     }