diff --git a/src/Umbraco.Infrastructure/Security/MemberRoleStore.cs b/src/Umbraco.Infrastructure/Security/MemberRoleStore.cs
index 9b0618e8dd..d76f3b5c7b 100644
--- a/src/Umbraco.Infrastructure/Security/MemberRoleStore.cs
+++ b/src/Umbraco.Infrastructure/Security/MemberRoleStore.cs
@@ -69,13 +69,13 @@ namespace Umbraco.Cms.Core.Security
try
{
cancellationToken.ThrowIfCancellationRequested();
+ ThrowIfDisposed();
+
if (role == null)
{
throw new ArgumentNullException(nameof(role));
}
- ThrowIfDisposed();
-
if (!int.TryParse(role.Id, out int roleId))
{
return Task.FromResult(IdentityResult.Failed(_intParseError));
@@ -205,36 +205,10 @@ namespace Umbraco.Cms.Core.Security
}
///
- public Task GetNormalizedRoleNameAsync(TRole role, CancellationToken cancellationToken = default)
- {
- cancellationToken.ThrowIfCancellationRequested();
- ThrowIfDisposed();
-
- if (role == null)
- {
- throw new ArgumentNullException(nameof(role));
- }
-
- //TODO: are we utilising NormalizedRoleName?
- return Task.FromResult(role.NormalizedName);
- }
+ public Task GetNormalizedRoleNameAsync(TRole role, CancellationToken cancellationToken = default) => GetRoleNameAsync(role, cancellationToken);
///
- public Task SetNormalizedRoleNameAsync(TRole role, string normalizedName, CancellationToken cancellationToken = default)
- {
- cancellationToken.ThrowIfCancellationRequested();
- ThrowIfDisposed();
-
- if (role == null)
- {
- throw new ArgumentNullException(nameof(role));
- }
-
- //TODO: are we utilising NormalizedRoleName and do we need to set it in the memberGroupService?
- role.NormalizedName = normalizedName;
-
- return Task.CompletedTask;
- }
+ public Task SetNormalizedRoleNameAsync(TRole role, string normalizedName, CancellationToken cancellationToken = default) => SetRoleNameAsync(role, normalizedName, cancellationToken);
///
public Task FindByIdAsync(string roleId, CancellationToken cancellationToken = default)
@@ -280,8 +254,6 @@ namespace Umbraco.Cms.Core.Security
throw new ArgumentNullException(nameof(name));
}
IMemberGroup memberGroup = _memberGroupService.GetByName(name);
- //TODO: throw exception when not found?
-
return Task.FromResult(memberGroup == null ? null : MapFromMemberGroup(memberGroup));
}
diff --git a/src/Umbraco.Web.BackOffice/Controllers/ContentController.cs b/src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
index 00f2fff56c..c4c601593f 100644
--- a/src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
+++ b/src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
@@ -2435,7 +2435,7 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
.Select(_umbracoMapper.Map)
.ToArray();
- //TODO: change to role store
+ //TODO: change to role manager
var allGroups = _memberGroupService.GetAll().ToArray();
var groups = entry.Rules
.Where(rule => rule.RuleType == Constants.Conventions.PublicAccess.MemberRoleRuleType)
diff --git a/src/Umbraco.Web.Common/Umbraco.Web.Common.csproj b/src/Umbraco.Web.Common/Umbraco.Web.Common.csproj
index 0fe68d4cc9..738a9389dc 100644
--- a/src/Umbraco.Web.Common/Umbraco.Web.Common.csproj
+++ b/src/Umbraco.Web.Common/Umbraco.Web.Common.csproj
@@ -24,7 +24,6 @@
-