From 5d5c4c69041e730e5de44062199d7f92051cfc18 Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Tue, 27 Oct 2020 11:57:15 +0100 Subject: [PATCH 1/2] Remove build warnings Signed-off-by: Bjarke Berg --- .../Builders/AuditEntryBuilder.cs | 16 +++++++------- .../Builders/ContentVariantSaveBuilder.cs | 4 ++-- .../Umbraco.Tests.Common.csproj | 3 +-- src/Umbraco.Tests.Integration/Tests.cs | 21 ------------------- .../Umbraco.Tests.Integration.csproj | 1 - 5 files changed, 11 insertions(+), 34 deletions(-) delete mode 100644 src/Umbraco.Tests.Integration/Tests.cs diff --git a/src/Umbraco.Tests.Common/Builders/AuditEntryBuilder.cs b/src/Umbraco.Tests.Common/Builders/AuditEntryBuilder.cs index cf31c2a14f..6efdc8aca8 100644 --- a/src/Umbraco.Tests.Common/Builders/AuditEntryBuilder.cs +++ b/src/Umbraco.Tests.Common/Builders/AuditEntryBuilder.cs @@ -25,14 +25,14 @@ namespace Umbraco.Tests.Common.Builders private int? _id; private Guid? _key; private DateTime? _updateDate; - private string _affectedDetails; - private int? _affectedUserId; - private string _eventDetails; - private string _eventType; - private string _performingDetails; - private string _performingIp; - private DateTime? _eventDateUtc; - private int? _performingUserId; + private string _affectedDetails = null; + private int? _affectedUserId = null; + private string _eventDetails = null; + private string _eventType = null; + private string _performingDetails = null; + private string _performingIp = null; + private DateTime? _eventDateUtc = null; + private int? _performingUserId = null; public AuditEntryBuilder(TParent parentBuilder) : base(parentBuilder) { diff --git a/src/Umbraco.Tests.Common/Builders/ContentVariantSaveBuilder.cs b/src/Umbraco.Tests.Common/Builders/ContentVariantSaveBuilder.cs index da031a804c..4b7b4b3d2b 100644 --- a/src/Umbraco.Tests.Common/Builders/ContentVariantSaveBuilder.cs +++ b/src/Umbraco.Tests.Common/Builders/ContentVariantSaveBuilder.cs @@ -15,8 +15,8 @@ namespace Umbraco.Tests.Common.Builders private string _name; private CultureInfo _cultureInfo; - private bool? _save; - private bool? _publish; + private bool? _save = null; + private bool? _publish = null; public ContentVariantSaveBuilder(TParent parentBuilder) : base(parentBuilder) { diff --git a/src/Umbraco.Tests.Common/Umbraco.Tests.Common.csproj b/src/Umbraco.Tests.Common/Umbraco.Tests.Common.csproj index 5faf5a1279..aa39070cc7 100644 --- a/src/Umbraco.Tests.Common/Umbraco.Tests.Common.csproj +++ b/src/Umbraco.Tests.Common/Umbraco.Tests.Common.csproj @@ -6,10 +6,9 @@ - + - diff --git a/src/Umbraco.Tests.Integration/Tests.cs b/src/Umbraco.Tests.Integration/Tests.cs deleted file mode 100644 index 1bd39ebad6..0000000000 --- a/src/Umbraco.Tests.Integration/Tests.cs +++ /dev/null @@ -1,21 +0,0 @@ -using NUnit.Framework; -using Umbraco.Tests.Integration.Testing; - -namespace Umbraco.Tests.Integration -{ - [TestFixture] - public class Tests : UmbracoIntegrationTest - { - [Test] - public void Test__Stupid_test_that_only_is_used_to_check_how_long_time_we_spend_int_setup_and_teardown1() - { - - } - - [Test] - public void Test__Stupid_test_that_only_is_used_to_check_how_long_time_we_spend_int_setup_and_teardown2() - { - - } - } -} diff --git a/src/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj b/src/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj index b483d690f4..fb7e1b750c 100644 --- a/src/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj +++ b/src/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj @@ -41,7 +41,6 @@ - all From d4376e00c61fb272d7438c666f37189fa5718b0b Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Tue, 27 Oct 2020 12:01:17 +0100 Subject: [PATCH 2/2] removed test file Signed-off-by: Bjarke Berg --- .../create_slicing_filter_condition.sh | 25 ------------------- 1 file changed, 25 deletions(-) delete mode 100644 src/Umbraco.Tests.Integration/create_slicing_filter_condition.sh diff --git a/src/Umbraco.Tests.Integration/create_slicing_filter_condition.sh b/src/Umbraco.Tests.Integration/create_slicing_filter_condition.sh deleted file mode 100644 index 6b98271147..0000000000 --- a/src/Umbraco.Tests.Integration/create_slicing_filter_condition.sh +++ /dev/null @@ -1,25 +0,0 @@ -#!/bin/bash - -filterProperty="Name" - -tests=$1 -testCount=${#tests[@]} -totalAgents=$SYSTEM_TOTALJOBSINPHASE -agentNumber=$SYSTEM_JOBPOSITIONINPHASE - -if [ $totalAgents -eq 0 ]; then totalAgents=1; fi -if [ -z "$agentNumber" ]; then agentNumber=1; fi - -echo "Total agents: $totalAgents" -echo "Agent number: $agentNumber" -echo "Total tests: $testCount" - -echo "Target tests:" -for ((i=$agentNumber; i <= $testCount;i=$((i+$totalAgents)))); do -targetTestName=${tests[$i -1]} -echo "$targetTestName" -filter+="|${filterProperty}=${targetTestName}" -done -filter=${filter#"|"} - -echo "##vso[task.setvariable variable=targetTestsFilter]$filter"