From a14a32ee3c40020febf32508d8fa1644ccacaaaa Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Tue, 16 Aug 2022 11:22:20 +0200 Subject: [PATCH] change selectors to aria-label so that because Webkit discovers two elements with the same name and fails otherwise --- src/Umbraco.Web.UI.Client/e2e/installer.spec.ts | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/e2e/installer.spec.ts b/src/Umbraco.Web.UI.Client/e2e/installer.spec.ts index d75bc9ba31..9f701c17f3 100644 --- a/src/Umbraco.Web.UI.Client/e2e/installer.spec.ts +++ b/src/Umbraco.Web.UI.Client/e2e/installer.spec.ts @@ -30,25 +30,24 @@ test.describe('installer tests', () => { test.describe('test success and failure', () => { test.beforeEach(async ({ page }) => { - // User form - await expect(page.locator('[data-test="installer-user"]')).toBeVisible(); - await page.type('input[name="name"]', 'Test'); - await page.type('input[name="email"]', 'test@umbraco'); - await page.type('input[name="password"]', 'test123456'); + await page.waitForSelector('[data-test="installer-user"]'); + await page.fill('[aria-label="name"]', 'Test'); + await page.fill('[aria-label="email"]', 'test@umbraco'); + await page.fill('[aria-label="password"]', 'test123456'); await page.click('[name="subscribeToNewsletter"]'); // Go to the next step await page.click('[aria-label="Next"]'); // Set telemetry - await expect(page.locator('[data-test="installer-telemetry"]')).toBeVisible(); - expect(page.locator('[name="telemetryLevel"]')).toHaveAttribute('value', '2'); + await page.waitForSelector('[data-test="installer-telemetry"]'); + await page.waitForSelector('uui-slider[name="telemetryLevel"]'); // Click [aria-label="Next"] await page.click('[aria-label="Next"]'); // Database form - await expect(page.locator('[data-test="installer-database"]')).toBeVisible(); + await page.waitForSelector('[data-test="installer-database"]'); }); test('installer completes successfully', async ({ page }) => { @@ -86,7 +85,7 @@ test.describe('installer tests', () => { // Click reset button await page.click('#button-reset'); - await expect(page.locator('[data-test="installer-user"]')).toBeVisible(); + await page.waitForSelector('[data-test="installer-user"]'); }); }); });