Implements Public Access in netcore (#10137)

* Getting new netcore PublicAccessChecker in place * Adds full test coverage for PublicAccessChecker * remove PublicAccessComposer * adjust namespaces, ensure RoleManager works, separate public access controller, reduce content controller * Implements the required methods on IMemberManager, removes old migrated code * Updates routing to be able to re-route, Fixes middleware ordering ensuring endpoints are last, refactors pipeline options, adds public access middleware, ensures public access follows all hops * adds note * adds note * Cleans up ext methods, ensures that members identity is added on both front-end and back ends. updates how UmbracoApplicationBuilder works in that it explicitly starts endpoints at the time of calling. * Changes name to IUmbracoEndpointBuilder * adds note * Fixing tests, fixing error describers so there's 2x one for back office, one for members, fixes TryConvertTo, fixes login redirect * fixing build * Fixes keepalive, fixes PublicAccessMiddleware to not throw, updates startup code to be more clear and removes magic that registers middleware. * adds note * removes unused filter, fixes build * fixes WebPath and tests * Looks up entities in one query * remove usings * Fix test, remove stylesheet * Set status code before we write to response to avoid error * Ensures that users and members are validated when logging in. Shares more code between users and members. * Fixes RepositoryCacheKeys to ensure the keys are normalized * oops didn't mean to commit this * Fix casing issues with caching, stop boxing value types for all cache operations, stop re-creating string keys in DefaultRepositoryCachePolicy * bah, far out this keeps getting recommitted. sorry Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-20 15:11:45 +10:00
parent 385cc62523
commit a1624d26a3
150 changed files with 2715 additions and 2173 deletions
--- a/src/Umbraco.Web.Common/DependencyInjection/UmbracoBuilder.MembersIdentity.cs
+++ b/src/Umbraco.Web.Common/DependencyInjection/UmbracoBuilder.MembersIdentity.cs
@@ -0,0 +1,54 @@
+using System;
+using System.Linq;
+using Microsoft.AspNetCore.Identity;
+using Microsoft.Extensions.DependencyInjection;
+using Umbraco.Cms.Core.DependencyInjection;
+using Umbraco.Cms.Core.Security;
+using Umbraco.Cms.Web.Common.Security;
+
+namespace Umbraco.Extensions
+{
+    public static partial class UmbracoBuilderExtensions
+    {
+        /// <summary>
+        /// Adds Identity support for Umbraco members
+        /// </summary>
+        public static IUmbracoBuilder AddMembersIdentity(this IUmbracoBuilder builder)
+        {
+            IServiceCollection services = builder.Services;
+
+            // check if this has already been added, we cannot add twice but both front-end and back end
+            // depend on this so it's possible it can be called twice.
+            var distCacheBinder = new UniqueServiceDescriptor(typeof(IMemberManager), typeof(MemberManager), ServiceLifetime.Scoped);
+            if (builder.Services.Contains(distCacheBinder))
+            {
+                return builder;
+            }
+
+            // TODO: We may need to use services.AddIdentityCore instead if this is doing too much
+
+            services.AddIdentity<MemberIdentityUser, UmbracoIdentityRole>()
+                .AddDefaultTokenProviders()
+                .AddUserStore<MemberUserStore>()
+                .AddRoleStore<MemberRoleStore>()
+                .AddRoleManager<IMemberRoleManager, MemberRoleManager>()
+                .AddMemberManager<IMemberManager, MemberManager>()
+                .AddSignInManager<IMemberSignInManager, MemberSignInManager>()
+                .AddErrorDescriber<MembersErrorDescriber>()
+                .AddUserConfirmation<UmbracoUserConfirmation<MemberIdentityUser>>();
+
+            services.ConfigureOptions<ConfigureMemberIdentityOptions>();
+
+            services.ConfigureApplicationCookie(x =>
+            {
+                // TODO: We may want/need to configure these further
+
+                x.LoginPath = null;
+                x.AccessDeniedPath = null;
+                x.LogoutPath = null;
+            });
+
+            return builder;
+        }
+    }
+}