From a411d13d0e0cabf39854fc5e41bf8c8d607033af Mon Sep 17 00:00:00 2001
From: Mads Rasmussen <mads@umbraco.com>
Date: Fri, 7 Dec 2018 13:10:50 +0100
Subject: [PATCH] fix binding of documenttypes and templates

---
 .../src/views/packages/edit.controller.js              | 10 ++++++++++
 src/Umbraco.Web.UI.Client/src/views/packages/edit.html |  4 +---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/packages/edit.controller.js b/src/Umbraco.Web.UI.Client/src/views/packages/edit.controller.js
index 494c26e8e8..aa23b0209f 100644
--- a/src/Umbraco.Web.UI.Client/src/views/packages/edit.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/packages/edit.controller.js
@@ -54,11 +54,21 @@
 
             // get all doc types
             contentTypeResource.getAll().then(documentTypes => {
+                // a package stores the id as a string so we 
+                // need to convert all ids to string for comparison
+                documentTypes.forEach(documentType => {
+                    documentType.id = documentType.id.toString();
+                });
                 vm.documentTypes = documentTypes;
             });
 
             // get all templates
             templateResource.getAll().then(templates => {
+                // a package stores the id as a string so we 
+                // need to convert all ids to string for comparison
+                templates.forEach(template => {
+                    template.id = template.id.toString();
+                });
                 vm.templates = templates;
             });
 
diff --git a/src/Umbraco.Web.UI.Client/src/views/packages/edit.html b/src/Umbraco.Web.UI.Client/src/views/packages/edit.html
index 5f63d74fe7..4fc3ea74d1 100644
--- a/src/Umbraco.Web.UI.Client/src/views/packages/edit.html
+++ b/src/Umbraco.Web.UI.Client/src/views/packages/edit.html
@@ -132,13 +132,12 @@
                         </umb-control-group>
 
                         <umb-control-group label="Document Types">
-                                <pre>{{vm.documentTypes | json }} </pre>
                             <div ng-repeat="doctype in vm.documentTypes">
                                 <label>
                                     <input
                                         type="checkbox"
                                         ng-model="doctype.selected"
-                                        checklist-model="vm.package.contentTypes"
+                                        checklist-model="vm.package.documenttypes"
                                         checklist-value="doctype.id" />
                                     {{doctype.name}}
                                 </label>
@@ -146,7 +145,6 @@
                         </umb-control-group>
 
                         <umb-control-group label="Templates">
-                            <pre>{{vm.templates | json }} </pre>
                             <div ng-repeat="template in vm.templates">
                                 <label>
                                     <input