yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Decimal property editor: Flexibly parse decimal value with different separators (closes #20823) (#20828)

Browse Source 
* Flexibly parse decimal value with different separators.

* Applied suggestions from code review.
This commit is contained in:
Andy Butland
2025-11-14 02:20:12 +01:00
committed by GitHub
parent 73847d1eff
commit a4438e5b21
2 changed files with 53 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/DecimalPropertyValueEditorTests.cs
View File

@@ -161,7 +161,27 @@ public class DecimalPropertyValueEditorTests
Assert.AreEqual(1, result.Count());
var validationResult = result.First();
Assert.AreEqual(validationResult.ErrorMessage, "validation_outOfRangeMaximum");
Assert.AreEqual("validation_outOfRangeMaximum", validationResult.ErrorMessage);
}
}
[TestCase(1.8, true)]
[TestCase(2.2, false)]
[SetCulture("it-IT")] // Uses "," as the decimal separator.
public void Validates_Is_Less_Than_Or_Equal_To_Configured_Max_With_Comma_Decimal_Separator(object value, bool expectedSuccess)
{
var editor = CreateValueEditor(min: 1, max: 2);
var result = editor.Validate(value, false, null, PropertyValidationContext.Empty());
if (expectedSuccess)
{
Assert.IsEmpty(result);
}
else
{
Assert.AreEqual(1, result.Count());
var validationResult = result.First();
Assert.AreEqual("validation_outOfRangeMaximum", validationResult.ErrorMessage);
}
}