From a51d3d258f9885084ec1204b67c79561814d797c Mon Sep 17 00:00:00 2001
From: Mads Rasmussen <madsr@hey.com>
Date: Mon, 2 Jan 2023 21:42:34 +0100
Subject: [PATCH] move search header app into search domain

---
 .../backoffice-header-apps.element.ts         | 42 -------------------
 .../src/backoffice/core/index.ts              |  2 +
 .../src/backoffice/core/search/manifests.ts   | 18 ++++++++
 3 files changed, 20 insertions(+), 42 deletions(-)
 create mode 100644 src/Umbraco.Web.UI.Client/src/backoffice/core/search/manifests.ts

diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/core/components/backoffice-frame/backoffice-header-apps.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/core/components/backoffice-frame/backoffice-header-apps.element.ts
index a73dbb4036..0a0375f6d0 100644
--- a/src/Umbraco.Web.UI.Client/src/backoffice/core/components/backoffice-frame/backoffice-header-apps.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/core/components/backoffice-frame/backoffice-header-apps.element.ts
@@ -1,7 +1,6 @@
 import { UUITextStyles } from '@umbraco-ui/uui-css/lib';
 import { css, CSSResultGroup, html, LitElement } from 'lit';
 import { customElement } from 'lit/decorators.js';
-import { ManifestHeaderApp, umbExtensionsRegistry } from '@umbraco-cms/extensions-registry';
 
 @customElement('umb-backoffice-header-apps')
 export class UmbBackofficeHeaderApps extends LitElement {
@@ -16,47 +15,6 @@ export class UmbBackofficeHeaderApps extends LitElement {
 		`,
 	];
 
-	constructor() {
-		super();
-		this._registerHeaderApps();
-	}
-
-	// TODO: these registrations should be moved
-	private _registerHeaderApps() {
-		const headerApps: Array<ManifestHeaderApp> = [
-			{
-				type: 'headerApp',
-				alias: 'Umb.HeaderApp.Search',
-				name: 'Header App Search',
-				loader: () => import('../header-app/header-app-button.element'),
-				weight: 10,
-				meta: {
-					label: 'Search',
-					icon: 'search',
-					pathname: 'search',
-				},
-			},
-			{
-				type: 'headerApp',
-				alias: 'Umb.HeaderApp.Favorites',
-				name: 'Header App Favorites',
-				loader: () => import('../header-app/header-app-button.element'),
-				weight: 100,
-				meta: {
-					label: 'Favorites',
-					icon: 'favorite',
-					pathname: 'favorites',
-				},
-			},
-		];
-
-		// TODO: Can we make this functionality reuseable...
-		headerApps.forEach((headerApp) => {
-			if (umbExtensionsRegistry.isRegistered(headerApp.alias)) return;
-			umbExtensionsRegistry.register(headerApp);
-		});
-	}
-
 	render() {
 		return html` <umb-extension-slot id="apps" type="headerApp"></umb-extension-slot> `;
 	}
diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/core/index.ts b/src/Umbraco.Web.UI.Client/src/backoffice/core/index.ts
index f773d3ed03..b422a48be2 100644
--- a/src/Umbraco.Web.UI.Client/src/backoffice/core/index.ts
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/core/index.ts
@@ -6,6 +6,7 @@ import { manifests as languageManifests } from './languages/manifests';
 import { manifests as propertyActionManifests } from './property-actions/manifests';
 import { manifests as propertyEditorModelManifests } from './property-editors/models/manifests';
 import { manifests as propertyEditorUIManifests } from './property-editors/uis/manifests';
+import { manifests as searchManifests } from './search/manifests';
 
 import { ManifestTypes, umbExtensionsRegistry } from '@umbraco-cms/extensions-registry';
 
@@ -25,4 +26,5 @@ registerExtensions([
 	...propertyActionManifests,
 	...propertyEditorModelManifests,
 	...propertyEditorUIManifests,
+	...searchManifests,
 ]);
diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/core/search/manifests.ts b/src/Umbraco.Web.UI.Client/src/backoffice/core/search/manifests.ts
new file mode 100644
index 0000000000..fe92ce1b73
--- /dev/null
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/core/search/manifests.ts
@@ -0,0 +1,18 @@
+import type { ManifestHeaderApp } from '@umbraco-cms/models';
+
+const headerApps: Array<ManifestHeaderApp> = [
+	{
+		type: 'headerApp',
+		alias: 'Umb.HeaderApp.Search',
+		name: 'Header App Search',
+		loader: () => import('src/backoffice/core/components/header-app/header-app-button.element'),
+		weight: 10,
+		meta: {
+			label: 'Search',
+			icon: 'search',
+			pathname: 'search',
+		},
+	},
+];
+
+export const manifests = [...headerApps];