yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

WIP put the tabindex back to what it was before

Browse Source
This commit is contained in:
Warren Buckley
2018-10-24 11:57:02 +01:00
parent 62716fb417
commit a5b7e8b0ae
1 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/Umbraco.Web.UI.Client/src/common/directives/util/disabletabindex.directive.js
View File

@@ -6,6 +6,8 @@ angular.module("umbraco.directives")
scope: { disableTabindex: "<"},
link: function (scope, element, attrs) {
var tabIndexesToRollback = [];
function enableTest(){
//Add in observer code
@@ -34,7 +36,17 @@ angular.module("umbraco.directives")
console.log('item in loop', element);
//TODO: Get existing element & it's tabindex (if any set)
//Check if the element has an existing tab index
//If so store in a collection (that when this directive is disabled/toggled)
//The tabindex is returned back to normal
var currentTabIndex = angular.element(element).attr('tabindex');
console.log('currentTabIndex', currentTabIndex);
if(currentTabIndex){
//A value has been set - need to track it
var itemToRevert = { dom: element, tabindex: currentTabIndex };
tabIndexesToRollback.push(itemToRevert);
}
//TODO: Note we updating way too many times from the DOMSubtreeModified event - is this expensive?
angular.element(element).attr('tabindex', '-1');
@@ -58,6 +70,15 @@ angular.module("umbraco.directives")
if(newVal === true){
enableTest();
}else{
console.log('what do I need to revert', tabIndexesToRollback);
//Stop observation?
//TODO: Will it refire the observer?!
angular.forEach(tabIndexesToRollback, function(rollbackItem){
console.log('item in rollback', rollbackItem);
angular.element(rollbackItem.dom).attr('tabindex', rollbackItem.tabindex);
});
}
});