From a72ae2278dba8a58dacfd2d50bd50015a8cf588e Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Thu, 26 Mar 2020 19:52:40 +0100 Subject: [PATCH] Post merge + bugfix --- src/Umbraco.Tests/Models/PropertyTests.cs | 6 +++--- src/Umbraco.Web/UmbracoContext.cs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Tests/Models/PropertyTests.cs b/src/Umbraco.Tests/Models/PropertyTests.cs index a95afcdd5c..b9462db0db 100644 --- a/src/Umbraco.Tests/Models/PropertyTests.cs +++ b/src/Umbraco.Tests/Models/PropertyTests.cs @@ -13,7 +13,7 @@ namespace Umbraco.Tests.Models public void Can_Deep_Clone() { // needs to be within collection to support publishing - var ptCollection = new PropertyTypeCollection(true, new[] {new PropertyType("TestPropertyEditor", ValueStorageType.Nvarchar, "test") + var ptCollection = new PropertyTypeCollection(true, new[] {new PropertyType(ShortStringHelper,"TestPropertyEditor", ValueStorageType.Nvarchar, "test") { Id = 3, CreateDate = DateTime.Now, @@ -50,8 +50,8 @@ namespace Umbraco.Tests.Models { Assert.AreNotSame(property.Values.ElementAt(i), clone.Values.ElementAt(i)); } - - + + //This double verifies by reflection var allProps = clone.GetType().GetProperties(); foreach (var propertyInfo in allProps) diff --git a/src/Umbraco.Web/UmbracoContext.cs b/src/Umbraco.Web/UmbracoContext.cs index 9cc651f359..de3231fe2c 100644 --- a/src/Umbraco.Web/UmbracoContext.cs +++ b/src/Umbraco.Web/UmbracoContext.cs @@ -207,7 +207,7 @@ namespace Umbraco.Web { try { - return _httpContextAccessor.GetRequiredHttpContext().Request; + return _httpContextAccessor.HttpContext?.Request; } catch (HttpException) {