Moved from angular.IsNumber to Utilities.IsNumber (#7925)

This commit is contained in:
Matthew-Wise
2020-04-10 16:57:33 +01:00
committed by GitHub
parent 3e9c759426
commit a977cfdc3f
8 changed files with 8 additions and 8 deletions

View File

@@ -80,7 +80,7 @@
} }
// Advanced options // Advanced options
if (Utilities.isDefined(opts.firstLineNumber)) { if (Utilities.isDefined(opts.firstLineNumber)) {
if (angular.isNumber(opts.firstLineNumber)) { if (Utilities.isNumber(opts.firstLineNumber)) {
session.setOption('firstLineNumber', opts.firstLineNumber); session.setOption('firstLineNumber', opts.firstLineNumber);
} else if (angular.isFunction(opts.firstLineNumber)) { } else if (angular.isFunction(opts.firstLineNumber)) {
session.setOption('firstLineNumber', opts.firstLineNumber()); session.setOption('firstLineNumber', opts.firstLineNumber());

View File

@@ -610,7 +610,7 @@ function contentResource($q, $http, umbDataFormatter, umbRequestHelper) {
//converts the value to a js bool //converts the value to a js bool
function toBool(v) { function toBool(v) {
if (angular.isNumber(v)) { if (Utilities.isNumber(v)) {
return v > 0; return v > 0;
} }
if (angular.isString(v)) { if (angular.isString(v)) {

View File

@@ -348,7 +348,7 @@ function mediaResource($q, $http, umbDataFormatter, umbRequestHelper) {
//converts the value to a js bool //converts the value to a js bool
function toBool(v) { function toBool(v) {
if (angular.isNumber(v)) { if (Utilities.isNumber(v)) {
return v > 0; return v > 0;
} }
if (angular.isString(v)) { if (angular.isString(v)) {

View File

@@ -53,7 +53,7 @@ function memberResource($q, $http, umbDataFormatter, umbRequestHelper) {
//converts the value to a js bool //converts the value to a js bool
function toBool(v) { function toBool(v) {
if (angular.isNumber(v)) { if (Utilities.isNumber(v)) {
return v > 0; return v > 0;
} }
if (angular.isString(v)) { if (angular.isString(v)) {

View File

@@ -10,7 +10,7 @@ function contentEditingHelper(fileManager, $q, $location, $routeParams, editorSt
function isValidIdentifier(id) { function isValidIdentifier(id) {
//empty id <= 0 //empty id <= 0
if (angular.isNumber(id)) { if (Utilities.isNumber(id)) {
if (id === 0) { if (id === 0) {
return false; return false;
} }

View File

@@ -242,7 +242,7 @@
var currUsers = saveModel.users; var currUsers = saveModel.users;
var formattedUsers = []; var formattedUsers = [];
for (var j = 0; j < currUsers.length; j++) { for (var j = 0; j < currUsers.length; j++) {
if (!angular.isNumber(currUsers[j])) { if (!Utilities.isNumber(currUsers[j])) {
formattedUsers.push(currUsers[j].id); formattedUsers.push(currUsers[j].id);
} }
else { else {

View File

@@ -128,7 +128,7 @@ angular.module('umbraco.services')
function setUserTimeoutInternal(newTimeout) { function setUserTimeoutInternal(newTimeout) {
var asNumber = parseFloat(newTimeout); var asNumber = parseFloat(newTimeout);
if (!isNaN(asNumber) && currentUser && angular.isNumber(asNumber)) { if (!isNaN(asNumber) && currentUser && Utilities.isNumber(asNumber)) {
currentUser.remainingAuthSeconds = newTimeout; currentUser.remainingAuthSeconds = newTimeout;
lastServerTimeoutSet = new Date(); lastServerTimeoutSet = new Date();
} }

View File

@@ -47,7 +47,7 @@ angular.module("umbraco").controller("Umbraco.PrevalueEditors.CropSizesControlle
$scope.setFocus = true; $scope.setFocus = true;
if ($scope.newItem && $scope.newItem.alias && if ($scope.newItem && $scope.newItem.alias &&
angular.isNumber($scope.newItem.width) && angular.isNumber($scope.newItem.height) && Utilities.isNumber($scope.newItem.width) && Utilities.isNumber($scope.newItem.height) &&
$scope.newItem.width > 0 && $scope.newItem.height > 0) { $scope.newItem.width > 0 && $scope.newItem.height > 0) {
var exists = _.find($scope.model.value, function (item) { return $scope.newItem.alias === item.alias; }); var exists = _.find($scope.model.value, function (item) { return $scope.newItem.alias === item.alias; });