From ad9d0fad4f94fb52e026b6f52cd33bcbde5c6495 Mon Sep 17 00:00:00 2001 From: Shannon Date: Thu, 23 Jul 2020 23:06:58 +1000 Subject: [PATCH] Adds notes with links back to PR about server side validation --- .../src/common/services/servervalidationmgr.service.js | 4 ++++ .../Validation/ComplexEditorElementTypeValidationResult.cs | 4 ++++ .../Validation/ComplexEditorPropertyTypeValidationResult.cs | 4 ++++ .../Validation/ComplexEditorValidationResult.cs | 5 ++++- .../Validation/ContentPropertyValidationResult.cs | 5 ++++- .../PropertyEditors/Validation/ValidationResultConverter.cs | 3 +++ 6 files changed, 23 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/common/services/servervalidationmgr.service.js b/src/Umbraco.Web.UI.Client/src/common/services/servervalidationmgr.service.js index 7f8212f2c6..2a889d676d 100644 --- a/src/Umbraco.Web.UI.Client/src/common/services/servervalidationmgr.service.js +++ b/src/Umbraco.Web.UI.Client/src/common/services/servervalidationmgr.service.js @@ -7,6 +7,10 @@ * Used to handle server side validation and wires up the UI with the messages. There are 2 types of validation messages, one * is for user defined properties (called Properties) and the other is for field properties which are attached to the native * model objects (not user defined). The methods below are named according to these rules: Properties vs Fields. + * + * For a more indepth explanation of how server side validation works with the angular app, see this GitHub PR: + * https://github.com/umbraco/Umbraco-CMS/pull/8339 + * */ function serverValidationManager($timeout) { diff --git a/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorElementTypeValidationResult.cs b/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorElementTypeValidationResult.cs index 17a1433db5..9c68deb7b5 100644 --- a/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorElementTypeValidationResult.cs +++ b/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorElementTypeValidationResult.cs @@ -7,6 +7,10 @@ namespace Umbraco.Web.PropertyEditors.Validation /// /// A collection of for an element type within complex editor represented by an Element Type /// + /// + /// For a more indepth explanation of how server side validation works with the angular app, see this GitHub PR: + /// https://github.com/umbraco/Umbraco-CMS/pull/8339 + /// public class ComplexEditorElementTypeValidationResult : ValidationResult { public ComplexEditorElementTypeValidationResult(string elementTypeAlias, Guid blockId) diff --git a/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorPropertyTypeValidationResult.cs b/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorPropertyTypeValidationResult.cs index 1872648f54..3036529fb7 100644 --- a/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorPropertyTypeValidationResult.cs +++ b/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorPropertyTypeValidationResult.cs @@ -8,6 +8,10 @@ namespace Umbraco.Web.PropertyEditors.Validation /// /// A collection of for a property type within a complex editor represented by an Element Type /// + /// + /// For a more indepth explanation of how server side validation works with the angular app, see this GitHub PR: + /// https://github.com/umbraco/Umbraco-CMS/pull/8339 + /// public class ComplexEditorPropertyTypeValidationResult : ValidationResult { public ComplexEditorPropertyTypeValidationResult(string propertyTypeAlias) diff --git a/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorValidationResult.cs b/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorValidationResult.cs index eb1efbc64f..178e1ec1f4 100644 --- a/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorValidationResult.cs +++ b/src/Umbraco.Web/PropertyEditors/Validation/ComplexEditorValidationResult.cs @@ -8,7 +8,10 @@ namespace Umbraco.Web.PropertyEditors.Validation /// A collection of for a complex editor represented by an Element Type /// /// - /// For example, each represents validation results for a row in Nested Content + /// For example, each represents validation results for a row in Nested Content. + /// + /// For a more indepth explanation of how server side validation works with the angular app, see this GitHub PR: + /// https://github.com/umbraco/Umbraco-CMS/pull/8339 /// public class ComplexEditorValidationResult : ValidationResult { diff --git a/src/Umbraco.Web/PropertyEditors/Validation/ContentPropertyValidationResult.cs b/src/Umbraco.Web/PropertyEditors/Validation/ContentPropertyValidationResult.cs index e161e277ac..0f161c5628 100644 --- a/src/Umbraco.Web/PropertyEditors/Validation/ContentPropertyValidationResult.cs +++ b/src/Umbraco.Web/PropertyEditors/Validation/ContentPropertyValidationResult.cs @@ -7,7 +7,10 @@ namespace Umbraco.Web.PropertyEditors.Validation /// Custom for content properties /// /// - /// This clones the original result and then ensures the nested result if it's the correct type + /// This clones the original result and then ensures the nested result if it's the correct type. + /// + /// For a more indepth explanation of how server side validation works with the angular app, see this GitHub PR: + /// https://github.com/umbraco/Umbraco-CMS/pull/8339 /// public class ContentPropertyValidationResult : ValidationResult { diff --git a/src/Umbraco.Web/PropertyEditors/Validation/ValidationResultConverter.cs b/src/Umbraco.Web/PropertyEditors/Validation/ValidationResultConverter.cs index 85f2c5f81e..2fb000e2ca 100644 --- a/src/Umbraco.Web/PropertyEditors/Validation/ValidationResultConverter.cs +++ b/src/Umbraco.Web/PropertyEditors/Validation/ValidationResultConverter.cs @@ -15,6 +15,9 @@ namespace Umbraco.Web.PropertyEditors.Validation /// /// This converter is specifically used to convert validation results for content in order to be able to have nested /// validation results for complex editors. + /// + /// For a more indepth explanation of how server side validation works with the angular app, see this GitHub PR: + /// https://github.com/umbraco/Umbraco-CMS/pull/8339 /// internal class ValidationResultConverter : JsonConverter {