From ae5a8496bbb2472f63d5462f97e0e7439a25bcb4 Mon Sep 17 00:00:00 2001
From: patrickdemooij9 <patrickdemooij98@hotmail.com>
Date: Fri, 30 Sep 2022 01:39:54 +0200
Subject: [PATCH] Use char instead of string for DetectJson (#13019)

* Use char instead of string for DetectJson

* Use faster method

* Change DetectIsJon method
---
 .../Extensions/StringExtensions.cs            |  3 +-
 .../DetectJsonBenchmarks.cs                   | 71 +++++++++++++++++++
 2 files changed, 72 insertions(+), 2 deletions(-)
 create mode 100644 tests/Umbraco.Tests.Benchmarks/DetectJsonBenchmarks.cs

diff --git a/src/Umbraco.Core/Extensions/StringExtensions.cs b/src/Umbraco.Core/Extensions/StringExtensions.cs
index 6842cc6681..0388bc8f68 100644
--- a/src/Umbraco.Core/Extensions/StringExtensions.cs
+++ b/src/Umbraco.Core/Extensions/StringExtensions.cs
@@ -129,8 +129,7 @@ public static class StringExtensions
         }
 
         input = input.Trim();
-        return (input.StartsWith("{") && input.EndsWith("}"))
-               || (input.StartsWith("[") && input.EndsWith("]"));
+        return (input[0] is '[' && input[^1] is ']') || (input[0] is '{' && input[^1] is '}');
     }
 
     public static bool DetectIsEmptyJson(this string input) =>
diff --git a/tests/Umbraco.Tests.Benchmarks/DetectJsonBenchmarks.cs b/tests/Umbraco.Tests.Benchmarks/DetectJsonBenchmarks.cs
new file mode 100644
index 0000000000..461616c7bd
--- /dev/null
+++ b/tests/Umbraco.Tests.Benchmarks/DetectJsonBenchmarks.cs
@@ -0,0 +1,71 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using BenchmarkDotNet.Attributes;
+using Umbraco.Tests.Benchmarks.Config;
+
+namespace Umbraco.Tests.Benchmarks;
+
+[QuickRunWithMemoryDiagnoserConfig]
+public class DetectJsonBenchmarks
+{
+    private string Input { get; set; }
+
+    [GlobalSetup]
+    public void Setup()
+    {
+        Input = "[{test: true},{test:false}]";
+    }
+
+    [Benchmark(Baseline = true)]
+    public bool StringDetectJson()
+    {
+        var input = Input.Trim();
+        return (input.StartsWith("{") && input.EndsWith("}"))
+               || (input.StartsWith("[") && input.EndsWith("]"));
+    }
+
+    [Benchmark]
+    public bool CharDetectJson()
+    {
+        var input = Input.Trim();
+        return (input.StartsWith('{') && input.EndsWith('}'))
+               || (input.StartsWith('[') && input.EndsWith(']'));
+    }
+
+    [Benchmark]
+    public bool CharRangeIndexDetectJson()
+    {
+        var input = Input.Trim();
+        return (input[0] is '[' && input[^1] is ']') || (input[0] is '{' && input[^1] is '}');
+    }
+
+
+    //This is the fastest, however we the check will be less good than before as it'll return true on things like this: [test or {test]
+    [Benchmark]
+    public bool CharRangeIndexDetectJsonBad()
+    {
+        var input = Input;
+        return input[0] is '{' or '[' || input[^1] is '}' or ']';
+    }
+
+    [Benchmark]
+    public bool CharDetectJsonTwoLookups()
+    {
+        var input = Input.Trim();
+        var firstChar = input[0];
+        var lastChar = input[^1];
+        return (firstChar is '[' && lastChar is ']') || (firstChar is '{' && lastChar is '}');
+    }
+
+
+//|                      Method |        Mean |     Error |    StdDev | Ratio | Allocated |
+//|---------------------------- |------------:|----------:|----------:|------:|----------:|
+//|            StringDetectJson | 103.7203 ns | 1.5370 ns | 0.0842 ns | 1.000 |         - |
+//|              CharDetectJson |   8.8119 ns | 1.0330 ns | 0.0566 ns | 0.085 |         - |
+//|    CharRangeIndexDetectJson |   7.8054 ns | 1.2396 ns | 0.0679 ns | 0.075 |         - |
+//| CharRangeIndexDetectJsonBad |   0.4597 ns | 0.1882 ns | 0.0103 ns | 0.004 |         - |
+//|    CharDetectJsonTwoLookups |   7.8292 ns | 1.7397 ns | 0.0954 ns | 0.075 |         - |
+}