From aed6e99246454eb5269b987850d0dedae5fde484 Mon Sep 17 00:00:00 2001 From: yv01p Date: Sat, 13 Dec 2025 00:37:22 +0000 Subject: [PATCH] test(strings): fix unit test expectations to match original behavior MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Updates Cyrillic transliteration test cases to match the original Utf8ToAsciiConverter behavior (Щ→Sh instead of Shch). The goal is behavioral equivalence, not improved transliteration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- .../Strings/Utf8ToAsciiConverterNewTests.cs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Strings/Utf8ToAsciiConverterNewTests.cs b/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Strings/Utf8ToAsciiConverterNewTests.cs index 1f9e9ec57d..2bcff40f15 100644 --- a/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Strings/Utf8ToAsciiConverterNewTests.cs +++ b/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Strings/Utf8ToAsciiConverterNewTests.cs @@ -59,10 +59,11 @@ public class Utf8ToAsciiConverterNewTests => Assert.That(_converter.Convert(input), Is.EqualTo(expected)); // === Cyrillic === + // Note: These match the original Utf8ToAsciiConverter behavior (non-standard transliteration) [TestCase("Москва", "Moskva")] - [TestCase("Борщ", "Borshch")] - [TestCase("Щука", "Shchuka")] + [TestCase("Борщ", "Borsh")] // Original uses Щ→Sh (non-standard) + [TestCase("Щука", "Shuka")] // Original uses Щ→Sh (non-standard) [TestCase("Привет", "Privet")] public void Convert_Cyrillic_TransliteratesCorrectly(string input, string expected) => Assert.That(_converter.Convert(input), Is.EqualTo(expected)); @@ -92,13 +93,13 @@ public class Utf8ToAsciiConverterNewTests [Test] public void Convert_SpanApi_HandlesExpansion() { - ReadOnlySpan input = "Щ"; // Expands to "Shch" (4 chars) + ReadOnlySpan input = "Щ"; // Expands to "Sh" (2 chars) in original Span output = stackalloc char[20]; var written = _converter.Convert(input, output); - Assert.That(written, Is.EqualTo(4)); - Assert.That(new string(output[..written]), Is.EqualTo("Shch")); + Assert.That(written, Is.EqualTo(2)); + Assert.That(new string(output[..written]), Is.EqualTo("Sh")); } // === Mixed Content ===