From b017e8690acf5025a2182fd05302e8d04edfcf67 Mon Sep 17 00:00:00 2001 From: Sebastiaan Janssen Date: Thu, 28 Feb 2013 09:53:57 -0100 Subject: [PATCH] Fix errors in log caused by no prevalues beind selected. --- src/umbraco.editorControls/DefaultDataKeyValue.cs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/umbraco.editorControls/DefaultDataKeyValue.cs b/src/umbraco.editorControls/DefaultDataKeyValue.cs index d8bcacf26f..03b5508369 100644 --- a/src/umbraco.editorControls/DefaultDataKeyValue.cs +++ b/src/umbraco.editorControls/DefaultDataKeyValue.cs @@ -22,9 +22,13 @@ namespace umbraco.editorControls string v = ""; try { - IRecordsReader dr = SqlHelper.ExecuteReader("Select [value] from cmsDataTypeprevalues where id in (" + SqlHelper.EscapeString(Value.ToString()) + ")"); + // Don't query if there's nothing to query for.. + if (string.IsNullOrWhiteSpace(Value.ToString()) == false) + { + IRecordsReader dr = SqlHelper.ExecuteReader("Select [value] from cmsDataTypeprevalues where id in (@id)", SqlHelper.CreateParameter("id", Value.ToString())); - while (dr.Read()) { + while (dr.Read()) + { if (v.Length == 0) v += dr.GetString("value"); else @@ -32,6 +36,7 @@ namespace umbraco.editorControls } dr.Close(); } + } catch {} return d.CreateCDataSection(v); }