From b1d1a2fcf2e8cb0d0d5726227592e312f0925b26 Mon Sep 17 00:00:00 2001 From: Chad Date: Tue, 31 Aug 2021 00:22:07 +1200 Subject: [PATCH] Avoid creating a new string for the log level every log message (#10934) --- .../Enrichers/Log4NetLevelMapperEnricher.cs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Umbraco.Core/Logging/Serilog/Enrichers/Log4NetLevelMapperEnricher.cs b/src/Umbraco.Core/Logging/Serilog/Enrichers/Log4NetLevelMapperEnricher.cs index 0c255fa8b4..327dc13526 100644 --- a/src/Umbraco.Core/Logging/Serilog/Enrichers/Log4NetLevelMapperEnricher.cs +++ b/src/Umbraco.Core/Logging/Serilog/Enrichers/Log4NetLevelMapperEnricher.cs @@ -11,7 +11,7 @@ namespace Umbraco.Core.Logging.Serilog.Enrichers { public void Enrich(LogEvent logEvent, ILogEventPropertyFactory propertyFactory) { - var log4NetLevel = string.Empty; + string log4NetLevel; switch (logEvent.Level) { @@ -28,21 +28,21 @@ namespace Umbraco.Core.Logging.Serilog.Enrichers break; case LogEventLevel.Information: - log4NetLevel = "INFO"; + log4NetLevel = "INFO "; //Padded string so that all log levels are 5 chars long (needed to keep the txt log file lined up nicely) break; case LogEventLevel.Verbose: - log4NetLevel = "ALL"; + log4NetLevel = "ALL "; //Padded string so that all log levels are 5 chars long (needed to keep the txt log file lined up nicely) break; case LogEventLevel.Warning: - log4NetLevel = "WARN"; + log4NetLevel = "WARN "; //Padded string so that all log levels are 5 chars long (needed to keep the txt log file lined up nicely) + break; + default: + log4NetLevel = string.Empty; break; } - //Pad string so that all log levels are 5 chars long (needed to keep the txt log file lined up nicely) - log4NetLevel = log4NetLevel.PadRight(5); - logEvent.AddPropertyIfAbsent(propertyFactory.CreateProperty("Log4NetLevel", log4NetLevel)); } }