From b2436bd9b6c19b9b5dc646340ddc26c1629f864e Mon Sep 17 00:00:00 2001 From: Declan Cook Date: Mon, 4 Aug 2014 13:40:11 +0100 Subject: [PATCH] Fix for issue U4-4162 - MacroContainer editing Allows editing of first element in a macro container. --- .../macrocontainer.controller.js | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.controller.js index 98cd8218ef..c18b3c5610 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/macrocontainer/macrocontainer.controller.js @@ -37,26 +37,26 @@ angular.module('umbraco') function openDialog(index){ var dialogData = {}; - if(index){ + if(index !== null && $scope.renderModel[index]) { var macro = $scope.renderModel[index]; dialogData = {macroData: macro}; } dialogService.macroPicker({ - dialogData : dialogData, - callback: function(data) { + dialogData : dialogData, + callback: function(data) { - collectDetails(data); + collectDetails(data); - //update the raw syntax and the list... - if(index){ - $scope.renderModel[index] = data; - }else{ - $scope.renderModel.push(data); - } - } - }); - } + //update the raw syntax and the list... + if(index !== null && $scope.renderModel[index]) { + $scope.renderModel[index] = data; + } else { + $scope.renderModel.push(data); + } + } + }); + }