From b28bb9bb94b7bee8e9a353e79037dd9440599115 Mon Sep 17 00:00:00 2001 From: Kenn Jacobsen Date: Mon, 25 May 2020 15:01:44 +0200 Subject: [PATCH] Listview "Order by" should not contain removed properties --- .../listview/includeproperties.prevalues.controller.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/includeproperties.prevalues.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/includeproperties.prevalues.controller.js index 216f1555e2..2eced1f660 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/includeproperties.prevalues.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/includeproperties.prevalues.controller.js @@ -53,10 +53,9 @@ function includePropsPreValsController($rootScope, $scope, localizationService, $scope.errorMsg = ""; } - $scope.removeField = function(e) { - $scope.model.value = _.reject($scope.model.value, function (x) { - return x.alias === e.alias; - }); + $scope.removeField = function (e) { + var index = $scope.model.value.indexOf(e); + $scope.model.value.splice(index, 1); } //now we'll localize these strings, for some reason the directive doesn't work inside of the select group with an ng-model declared